Skip to content

Create a UPP module for the global workflow#4174

Merged
DavidHuber-NOAA merged 5 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:fix/upp_mods
Oct 27, 2025
Merged

Create a UPP module for the global workflow#4174
DavidHuber-NOAA merged 5 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:fix/upp_mods

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

Description

This adds a global workflow module for upp jobs running on WCOSS2. This will ensure that the same crtm module (and other modules) used to build the UPP are loaded at runtime.

Resolves #4125

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Full testing suite on WCOS2/Cactus. Extended tests are still running, but have completed the first full cycle.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners

@DavidHuber-NOAA DavidHuber-NOAA changed the title Fix/upp mods Create a UPP module for the global workflow Oct 24, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

I verified that all C96_atm3DVar_extended GRIB2 products in COM are bitwise identical between this branch and develop through the 2nd full cycle (2021122100 through 2021122112) including GOES simulated imagery.

aerorahul
aerorahul previously approved these changes Oct 24, 2025
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A question and a suggestion.

Comment thread modulefiles/gw_upp.wcoss2.lua Outdated
Comment thread modulefiles/gw_upp.wcoss2.lua
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
aerorahul
aerorahul previously approved these changes Oct 24, 2025
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @DavidHuber-NOAA

Comment thread modulefiles/gw_upp.wcoss2.lua Outdated
load("wcoss2_intel")

load(pathJoin("cray-pals", "1.0.17"))
load(pathJoin("cfp", "2.0.4"))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cfp module is not needed in off-line post. It is only used in atmos_product.sh.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will remove this and rerun the upp jobs from the last cycle of the C96_atm3DVar_extended test to verify.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UPP jobs ran successfully.

Copy link
Copy Markdown
Contributor

@WenMeng-NOAA WenMeng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good to me.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 1de5262 into NOAA-EMC:develop Oct 27, 2025
5 checks passed
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Nov 5, 2025
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2

* 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud:
  reverse few changes
  re-sync with EMC repo
  Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203)
  Update Snow filenames to comply with EE2 (NOAA-EMC#4195)
  Rename files for JEDI atm EE2 (NOAA-EMC#4193)
  Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196)
  Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179)
  Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184)
  Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198)
  Remove replay from global workflow  (NOAA-EMC#4182)
  Add IODA stats text file to COM (NOAA-EMC#4176)
  Update UFS_UTILS submodule (NOAA-EMC#4178)
  Atm COM File Rename to Standardized Form  (NOAA-EMC#4117)
  Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130)
  Create a UPP module for the global workflow (NOAA-EMC#4174)
  Refactor marine DA tasks (NOAA-EMC#4160)
  Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167)
  Make options hashes
  Remove multiple option from static data template
  Fix static_data yaml (descriptions and labels)
  Fix static_data yaml (remove colon)
  Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164)
  Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162)
  Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149)
  Remove the snow analysis from archive (NOAA-EMC#4157)
  Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154)
  Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143)
  Update UFS Model  (NOAA-EMC#4138)
  Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
@DavidHuber-NOAA DavidHuber-NOAA deleted the fix/upp_mods branch November 18, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the module loading from dev/jobs/upp.sh to a new gw_upp.wcoss2.lua

3 participants