Rename files for JEDI atm EE2#4193
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DavidNew-NOAA
requested review from
DavidHuber-NOAA,
RussTreadon-NOAA,
TerrenceMcGuinness-NOAA and
aerorahul
as code owners
|
@aerorahul @DavidHuber-NOAA @CoryMartin-NOAA @RussTreadon-NOAA Hera CI completed successfully. I would like to expedite the review/merger of this PR to get JEDI atm CI running again. ******** C48_ATM ******** |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Thank you @DavidNew-NOAA for confirming that g-w CI, especially C96C48_ufs_hybatmDA, passes on Hera.
Approve.
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Looks good. Just one suggestion on a logger write.
|
Starting CI on |
|
To help expedite this, I will limit the tests on EDIT: |
DavidHuber-NOAA
added
the
CI-Wcoss2-Running
|
Thanks @DavidHuber-NOAA . I'm re-running C96C48_ufs_hybatmDA on Hera just to make sure my revisions didn't break anything. Then I'll be ready for retest |
DavidHuber-NOAA
removed
CI-Wcoss2-Passed
emcbot
added
CI-Gaeac6-Ready
|
Hera C96C48_ufs_hybatmDA passes. Triggering Ursa and C6 |
emcbot
added
CI-Gaeac6-Building
|
Additional GDASApp testing All ctests, including select g-w CI, Passed with Hera GDASApp stable-nightly testing using GDASApp branch |
|
@aerorahul CI is successful on Ursa and C6. I just need your approval to dismiss requested changes which have been addressed and then we can merge. |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
g-w CI passes on Gaea C6 and Ursa. GDASApp ctests pass on Hera.
Approve.
|
Merging. I believe all of @aerorahul's comments have been addressed. If not, I will address them in #4195. |
|
Thank you @DavidHuber-NOAA @aerorahul @RussTreadon-NOAA |
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2 * 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud: reverse few changes re-sync with EMC repo Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203) Update Snow filenames to comply with EE2 (NOAA-EMC#4195) Rename files for JEDI atm EE2 (NOAA-EMC#4193) Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196) Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179) Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184) Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198) Remove replay from global workflow (NOAA-EMC#4182) Add IODA stats text file to COM (NOAA-EMC#4176) Update UFS_UTILS submodule (NOAA-EMC#4178) Atm COM File Rename to Standardized Form (NOAA-EMC#4117) Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130) Create a UPP module for the global workflow (NOAA-EMC#4174) Refactor marine DA tasks (NOAA-EMC#4160) Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167) Make options hashes Remove multiple option from static data template Fix static_data yaml (descriptions and labels) Fix static_data yaml (remove colon) Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164) Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162) Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149) Remove the snow analysis from archive (NOAA-EMC#4157) Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154) Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143) Update UFS Model (NOAA-EMC#4138) Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
6 participants
Description
This PR makes changes to JEDI atm filenames to comply with EE2 standards and get JEDI atm DA working again in Global Workflow after changes made in #4117.
Resolves #4168
Type of change
Change characteristics
How has this been tested?
Hera clone, build, and full CI suite
Checklist