Skip to content

Generate pres_b files for RUN=gdas and update APCP to 598.#4196

Merged
DavidHuber-NOAA merged 11 commits into
NOAA-EMC:developfrom
aerorahul:feature/issue-4186
Oct 31, 2025
Merged

Generate pres_b files for RUN=gdas and update APCP to 598.#4196
DavidHuber-NOAA merged 11 commits into
NOAA-EMC:developfrom
aerorahul:feature/issue-4186

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul commented Oct 29, 2025 •
edited
Loading

Description

This PR:

Type of change

  • Bug fix (fixes something broken)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

On GaeaC6:

  • C48_ATM
  • C96_3DVar /gpfs/f6/drsa-precip4/world-shared/Rahul.Mahajan/RUNTESTS/4186/COMROOT/presa2

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@aerorahul aerorahul requested review from DavidHuber-NOAA and removed request for WenMeng-NOAA October 29, 2025 18:00
WenMeng-NOAA
WenMeng-NOAA reviewed Oct 29, 2025
View reviewed changes
Comment thread dev/parm/config/gcafs/config.atmos_products
WenMeng-NOAA
WenMeng-NOAA reviewed Oct 29, 2025
View reviewed changes
Comment thread scripts/exglobal_atmos_products.sh Outdated
DavidHuber-NOAA
DavidHuber-NOAA reviewed Oct 30, 2025
View reviewed changes
Comment thread dev/parm/config/gcafs/config.atmos_products
DavidHuber-NOAA
DavidHuber-NOAA previously approved these changes Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Oct 30, 2025

Launching tests on WCOSS2.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 label Oct 30, 2025
@WenMeng-NOAA
Copy link
Copy Markdown
Contributor

WenMeng-NOAA commented Oct 30, 2025

I have conducted the tests of ATMOS_PRODUCT for gfs and gdas and confirmed the changes solve the issues #3553 and #4186.

WenMeng-NOAA
WenMeng-NOAA previously approved these changes Oct 30, 2025
View reviewed changes
@aerorahul
Copy link
Copy Markdown
Contributor Author

aerorahul commented Oct 30, 2025

@WenMeng-NOAA
I have removed the wafs related files as requested via f63d0c3

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Oct 30, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Oct 31, 2025

All tests passed on WCOSS2. Merging.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 6355c59 into NOAA-EMC:develop Oct 31, 2025
5 checks passed
@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Oct 31, 2025
@aerorahul aerorahul deleted the feature/issue-4186 branch October 31, 2025 17:25
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Nov 5, 2025
@weihuang-jedi
Merge branch 'feature/use_container_spack-stack-1.9.2' of github.com:…
bd195a9 
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2

* 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud:
  reverse few changes
  re-sync with EMC repo
  Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203)
  Update Snow filenames to comply with EE2 (NOAA-EMC#4195)
  Rename files for JEDI atm EE2 (NOAA-EMC#4193)
  Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196)
  Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179)
  Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184)
  Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198)
  Remove replay from global workflow  (NOAA-EMC#4182)
  Add IODA stats text file to COM (NOAA-EMC#4176)
  Update UFS_UTILS submodule (NOAA-EMC#4178)
  Atm COM File Rename to Standardized Form  (NOAA-EMC#4117)
  Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130)
  Create a UPP module for the global workflow (NOAA-EMC#4174)
  Refactor marine DA tasks (NOAA-EMC#4160)
  Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167)
  Make options hashes
  Remove multiple option from static data template
  Fix static_data yaml (descriptions and labels)
  Fix static_data yaml (remove colon)
  Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164)
  Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162)
  Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149)
  Remove the snow analysis from archive (NOAA-EMC#4157)
  Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154)
  Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143)
  Update UFS Model  (NOAA-EMC#4138)
  Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

Assignees

No one assigned

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add pres_b products for the gdas cycle Wrong APCP generated in GFS ATMOS wgne dataset

3 participants

@aerorahul @DavidHuber-NOAA @WenMeng-NOAA