Skip to content

Update Snow filenames to comply with EE2#4195

Merged
DavidHuber-NOAA merged 42 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:feature/snow_ee2
Nov 1, 2025
Merged

Update Snow filenames to comply with EE2#4195
DavidHuber-NOAA merged 42 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:feature/snow_ee2

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Oct 29, 2025 •
edited
Loading

Description

This updates snow analysis, increment, and monitoring files to comply with EE2 standards. There's also a tiny fix for GEMPAK cleanup.

Resolves #4188
Resolves #4180
Partially addresses #4166

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • GDAS (PR to be created)

How has this been tested?

All tests ran to completion on Ursa.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

CoryMartin-NOAA commented Oct 29, 2025

Changes look good here, as likely known, similar changes need added to GDAS for the output file names to be consistent

This was referenced Oct 29, 2025
Merged
Merged
DavidNew-NOAA
DavidNew-NOAA requested changes Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment. Thanks @DavidHuber-NOAA

Comment thread ush/python/pygfs/task/snow_analysis.py
Comment thread ush/python/pygfs/task/snowens_analysis.py
@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Gaeac6-Running CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Oct 31, 2025
@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Gaeac6-Running CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Oct 31, 2025
@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Nov 1, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

DavidHuber-NOAA commented Nov 1, 2025

All tests passed on all platforms. Merging.

@DavidHuber-NOAA DavidHuber-NOAA merged commit d190541 into NOAA-EMC:develop Nov 1, 2025
6 checks passed
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Nov 1, 2025
Merged
7 tasks
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Nov 5, 2025
@weihuang-jedi
Merge branch 'feature/use_container_spack-stack-1.9.2' of github.com:…
bd195a9 
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2

* 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud:
  reverse few changes
  re-sync with EMC repo
  Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203)
  Update Snow filenames to comply with EE2 (NOAA-EMC#4195)
  Rename files for JEDI atm EE2 (NOAA-EMC#4193)
  Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196)
  Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179)
  Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184)
  Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198)
  Remove replay from global workflow  (NOAA-EMC#4182)
  Add IODA stats text file to COM (NOAA-EMC#4176)
  Update UFS_UTILS submodule (NOAA-EMC#4178)
  Atm COM File Rename to Standardized Form  (NOAA-EMC#4117)
  Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130)
  Create a UPP module for the global workflow (NOAA-EMC#4174)
  Refactor marine DA tasks (NOAA-EMC#4160)
  Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167)
  Make options hashes
  Remove multiple option from static data template
  Fix static_data yaml (descriptions and labels)
  Fix static_data yaml (remove colon)
  Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164)
  Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162)
  Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149)
  Remove the snow analysis from archive (NOAA-EMC#4157)
  Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154)
  Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143)
  Update UFS Model  (NOAA-EMC#4138)
  Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/snow_ee2 branch November 18, 2025 17:10
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Nov 18, 2025
Closed
DavidNew-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 6, 2026
@DavidHuber-NOAA
Update snow filenames to comply with EE2 standards (#201)
b706989 
This updates the output filenames for the observation statistics files
to comply with EE2 standards. Prerequisite for
NOAA-EMC/global-workflow#4195. Currently in
testing.
DavidNew-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 16, 2026
@DavidHuber-NOAA
Update to EE2 standards for snow file names (#1963)
f1f427c 
# Description

This updates the snow analysis, increment, and monitoring filenames to
comply with EE2 standards.

# Companion PRs

NOAA-EMC/global-workflow#4195
NOAA-EMC/jcb-gdas#201

# Issues

NOAA-EMC/global-workflow#4188

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [x] atm_jjob <!-- JEDI atm single cycle DA !-->
- [x] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [x] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [x] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@DavidNew-NOAA DavidNew-NOAA DavidNew-NOAA approved these changes

@aerorahul aerorahul aerorahul left review comments

@jiaruidong2017 jiaruidong2017 jiaruidong2017 left review comments

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees

No one assigned

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename snow files to follow EE2 naming conventions Annual CO2 update (GFS v16.3.28)

7 participants

@DavidHuber-NOAA @CoryMartin-NOAA @JessicaMeixner-NOAA @aerorahul @jiaruidong2017 @DavidNew-NOAA @emcbot