Add attributes to Gaussian grid sfcanl file#4149
Merged
DavidHuber-NOAA merged 7 commits intoOct 21, 2025
Merged
Conversation
aerorahul
requested changes
Oct 14, 2025
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Contributor
Author
|
Thanks for the suggestions @aerorahul, they make sense to me. Changes have been committed and starting CI on WCOSS2 and Gaea C6. |
aerorahul
approved these changes
Oct 14, 2025
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
lgtm. Thanks @CatherineThomas-NOAA
Contributor
Author
|
Tests on Gaea C6 have passed: WCOSS2 tests had a snag unrelated to this PR and are rerunning. |
Contributor
Author
|
@WenMeng-NOAA - Can you do a quick spot check on the upp side for the tests run on Gaea? The v17 CI test COMROOT is located here: |
Contributor
@CatherineThomas-NOAA Your test results look good to me. |
Contributor
Author
|
WCOSS2 CI tests (-G -E -S -C) were successful: Taking out of draft. |
CatherineThomas-NOAA
requested a review
from BrianCurtis-NOAA
as a code owner
WenMeng-NOAA
approved these changes
Oct 20, 2025
Contributor
WenMeng-NOAA
left a comment
WenMeng-NOAA
left a comment
There was a problem hiding this comment.
From the upp perspective, the inline post test results look good to me.
Contributor
Author
|
Merged in develop @aerorahul @DavidHuber-NOAA - Anything else needed for this PR? |
DavidHuber-NOAA
approved these changes
Oct 21, 2025
Contributor
|
Merging based on successful testing on WCOSS2. |
DavidHuber-NOAA
added
the
CI-Wcoss2-Passed (CM)
weihuang-jedi
added a commit
to NOAA-EPIC/global-workflow-cloud
that referenced
this pull request
Nov 5, 2025
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2 * 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud: reverse few changes re-sync with EMC repo Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203) Update Snow filenames to comply with EE2 (NOAA-EMC#4195) Rename files for JEDI atm EE2 (NOAA-EMC#4193) Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196) Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179) Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184) Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198) Remove replay from global workflow (NOAA-EMC#4182) Add IODA stats text file to COM (NOAA-EMC#4176) Update UFS_UTILS submodule (NOAA-EMC#4178) Atm COM File Rename to Standardized Form (NOAA-EMC#4117) Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130) Create a UPP module for the global workflow (NOAA-EMC#4174) Refactor marine DA tasks (NOAA-EMC#4160) Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167) Make options hashes Remove multiple option from static data template Fix static_data yaml (descriptions and labels) Fix static_data yaml (remove colon) Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164) Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162) Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149) Remove the snow analysis from archive (NOAA-EMC#4157) Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154) Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143) Update UFS Model (NOAA-EMC#4138) Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gaussian grid sfcanl file does not have the needed global attributes for upp. The attributes of imp_physics and landsfcmdl are missing and needed for upp to compute cloud and land fields consistently with the model. Upp assumes default values but the imp_physics default is inconsistent with what is used in GFSv17. This PR adds the needed attributes to the script and namelist for the gaussian sfcanl utility and updates the gfs_utils hash that allows the utility to read the new namelist.
Resolves #4113
Refs: NOAA-EMC/GFS#29 NOAA-EMC/gfs-utils#147
Type of change
Change characteristics
How has this been tested?
For NOAA-EMC/gfs-utils#148 - global-workflow CI tests (including cycling) on WCOSS2 as well as standalone UPP tests by @WenMeng-NOAA
Tested on WCOSS2 and Gaea C6 with latest g-w and gfs-utils changes - generate workflows -G -E -S -C tests passed. Output double checked by @WenMeng-NOAA.
Checklist