Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs/JGLOBAL_WAVE_* @JessicaMeixner-NOAA @sbanihash

# System-specific modules
modulefiles/gw_gsi_wcoss2.lua @RussTreadon-NOAA @CoryMartin-NOAA
modulefiles/gw_gsi_wcoss2.lua @RussTreadon-NOAA @CoryMartin-NOAA
modulefiles/gw_upp_wcoss2.lua @WenMeng-NOAA

# scripts
scripts/exgdas_aero_analysis_generate_bmatrix.py @CoryMartin-NOAA
Expand Down
37 changes: 4 additions & 33 deletions dev/jobs/upp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,10 @@ set -x
#if (( status != 0 )); then exit "${status}"; fi
# Temporarily load modules from UPP on WCOSS2
source "${HOMEgfs}/ush/detect_machine.sh"
if [[ "${MACHINE_ID}" == "wcoss2" ]]; then
set +x
source "${HOMEgfs}/ush/module-setup.sh"
module use "${HOMEgfs}/sorc/ufs_model.fd/UFSATM/upp/modulefiles"
module load "${MACHINE_ID}_intel"
module load prod_util
module load cray-pals
module load cfp
module load libjpeg
module load grib_util/1.2.3
module load wgrib2/2.0.8
export WGRIB2=wgrib2
module load python/3.8.6
if [[ "${UPP_RUN:-}" == "goes" ]]; then
module load crtm/2.4.0
fi
set -x

# Set up the PYTHONPATH to include wxflow from HOMEgfs
if [[ -d "${HOMEgfs}/sorc/wxflow/src" ]]; then
PYTHONPATH="${PYTHONPATH:+${PYTHONPATH}:}${HOMEgfs}/sorc/wxflow/src"
fi

# Add HOMEgfs/ush/python to PYTHONPATH
PYTHONPATH="${PYTHONPATH:+${PYTHONPATH}:}${HOMEgfs}/ush/python"
export PYTHONPATH

else
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}";
fi
source "${HOMEgfs}/dev/ush/load_modules.sh" upp
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}";
fi

export job="upp"
Expand Down
17 changes: 12 additions & 5 deletions dev/ush/load_modules.sh
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,10 @@ case "${MODULE_TYPE}" in
export PYTHONPATH
;;

"run" | "gsi" | "verif" | "setup")
# Source versions file for runtime
if [[ -f "${HOMEgfs}/versions/run.ver" ]]; then
source "${HOMEgfs}/versions/run.ver"
else
"run" | "gsi" | "verif" | "setup" | "upp")

# Test that the version file exists
if [[ ! -f "${HOMEgfs}/versions/run.ver" ]]; then
echo "FATAL ERROR: ${HOMEgfs}/versions/run.ver does not exist!"
echo "HINT: Run link_workflow.sh first."
exit 1
Expand All @@ -176,8 +175,16 @@ case "${MODULE_TYPE}" in
if ! module is-avail "${target_module}" 2>/dev/null; then
if [[ "${MODULE_TYPE}" != "run" ]]; then
echo "INFO: ${target_module} module not available, falling back to gw_run.${MACHINE_ID}"
mod_type="run"
fi
target_module="gw_run.${MACHINE_ID}"
else
mod_type="${MODULE_TYPE}"
fi

# Source versions file (except for upp)
if [[ "${mod_type}" != "upp" ]]; then
source "${HOMEgfs}/versions/run.ver"
fi

if [[ -n "${target_module}" ]]; then
Expand Down
26 changes: 26 additions & 0 deletions modulefiles/gw_upp.wcoss2.lua
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
help([[
Load environment to run the UPP on WCOSS2
]])

local homegfs=os.getenv("HOMEgfs") or ""
prepend_path("MODULEPATH", pathJoin(homegfs,"/sorc/ufs_model.fd/UFSATM/upp/modulefiles"))
-- Load UPP modules
load("wcoss2_intel")

load(pathJoin("cray-pals", "1.0.17"))
load(pathJoin("cfp", "2.0.4"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cfp module is not needed in off-line post. It is only used in atmos_product.sh.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will remove this and rerun the upp jobs from the last cycle of the C96_atm3DVar_extended test to verify.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UPP jobs ran successfully.

setenv("USE_CFP","YES")

-- Load workflow modules
load(pathJoin("prod_util", "2.0.9"))
load(pathJoin("python", "3.12.0"))
load(pathJoin("libjpeg", "9c"))
load(pathJoin("wgrib2", "2.0.8"))
load(pathJoin("grib_util","1.2.3"))
setenv("WGRIB2","wgrib2")

Comment thread
aerorahul marked this conversation as resolved.
-- Load the GW Python environment
prepend_path("MODULEPATH", "/apps/dev/modulefiles")
load(pathJoin("ve","gw", "1.0"))

whatis("Description: GFS run environment")
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated