Atm File Rename to Standardized Form #4117
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
The wave related changes here that I was tagged as a code-owner for review are okay. I'm not the best person to review the other changes, but I did look through them and did not see other red-flags beyond turning off tests.
WenMeng-NOAA
left a comment
WenMeng-NOAA
left a comment
There was a problem hiding this comment.
The updates in UPP and ATMOS_PRODUCT (pres_a and pres_b) look good to me, except for the missing pres_b dataset in the GDAS run, which will be addressed in a separate PR.
|
@WenMeng-NOAA I have opened #4186 to handle turning on |
| ecflow_client --event release_fcst | ||
| fi | ||
| echo "${rCDUMP} ${PDY}${cyc} atminc done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}loginc.txt" | ||
| echo "${rCDUMP} ${PDY}${cyc} atminc done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}analysis.done.txt" |
There was a problem hiding this comment.
This should have been increment.done.txt.
| fi | ||
|
|
||
| echo "${rCDUMP} ${PDY}${cyc} atmanl and sfcanl done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}loganl.txt" | ||
| echo "${rCDUMP} ${PDY}${cyc} atmanl and sfcanl done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}done.txt" |
There was a problem hiding this comment.
This should have been analysis.done.txt
| # Write analysis log file | ||
| formatted_date = datetime.now().strftime("%a %b %d %H:%M:%S %Z%Y") | ||
| log_file = os.path.join(self.task_config.COMOUT_ATMOS_ANALYSIS, f"{self.task_config.RUN}.t{self.task_config.cyc}z.loganl.txt") | ||
| log_file = os.path.join(self.task_config.COMOUT_ATMOS_ANALYSIS, f"{self.task_config.RUN}.t{self.task_config.cyc}z.done.txt") |
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}cnvstat.tar" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}abias_int.txt" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.dtf.a006.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.done.txt" |
There was a problem hiding this comment.
increment.done.txt
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}dtfanl.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}loginc.txt" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.dtf.a006.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.done.txt" |
There was a problem hiding this comment.
increment.done.txt
| - "{{ COMIN_ATMOS_GEMPAK | relpath(ROTDIR) }}/gfs_{{ cycle_YMDH }}.sfc" | ||
| - "{{ COMIN_ATMOS_GEMPAK | relpath(ROTDIR) }}/gfs_{{ cycle_YMDH }}.snd" | ||
| - "{{ COMIN_ATMOS_GEMPAK | relpath(ROTDIR) }}/gfs_{{ cycle_YMDH }}.sfc.bufr" | ||
| - "{{ COMIN_ATMOS_GEMPAK | relpath(ROTDIR) }}/gfs_{{ cycle_YMDH }}.soundings.bufr" |
There was a problem hiding this comment.
@JessicaMeixner-NOAA You are correct. #4271 is related to this update. The quick fix is to revert this change. However, the script that creates these files should be updated with the correct names.
FYI @BoCui-NOAA
There was a problem hiding this comment.
The script to create these files is ush/gfs_bfr2gpk.sh. The new correct names are gfs_{{ cycle_YMDH }}.sfc.bufr and gfs_{{ cycle_YMDH }}.soundings.bufr, right? @DavidHuber-NOAA @JessicaMeixner-NOAA
There was a problem hiding this comment.
I assume so, but am not the correct person to ask.
There was a problem hiding this comment.
The script to create these files is ush/gfs_bfr2gpk.sh. The new correct names are gfs_{{ cycle_YMDH }}.sfc.bufr and gfs_{{ cycle_YMDH }}.soundings.bufr, right? @DavidHuber-NOAA @JessicaMeixner-NOAA
@BoCui-NOAA Yes, that is the correct naming convention.
| @@ -4,11 +4,11 @@ gfs_downstream: | |||
| target: "{{ ATARDIR }}/{{ cycle_YMDH }}/gfs_downstream.tar" | |||
| required: | |||
| {% if DO_GEMPAK %} | |||
There was a problem hiding this comment.
Amending my comment from #4271, this line should be modified to use DO_BUFRSND and eliminate singular dependence on DO_GEMPAK with the following:
{% if DO_BUFRSND and DO_GEMPAK %}
There was a problem hiding this comment.
With this PR being closed, the suggested revision could be accomplished through #4258.
13 participants
Description
All intermediate and final atm output files are standardized according to the proposed format in the spreadsheet L80-139.
Resolves Rename atm files to standardized form #3271
Follow-on issues for TODOs:
Type of change
Change characteristics
How has this been tested?
Checklist