Refactor marine DA tasks#4160
Merged
DavidNew-NOAA merged 43 commits intoOct 25, 2025
Merged
Conversation
This was referenced Oct 20, 2025
DavidNew-NOAA
requested review from
AndrewEichmann-NOAA,
DavidHuber-NOAA,
RussTreadon-NOAA,
TerrenceMcGuinness-NOAA,
aerorahul and
guillaumevernieres
as code owners
DavidNew-NOAA
added
the
blocked
Contributor
Author
|
This PR and its companions are on hold until Rahul's https://github.com/NOAA-EMC/GDASApp/tree/feature/marine_rename branch is merged |
Contributor
Author
|
@DavidHuber-NOAA I've resolved any remaining issues with @aerorahul and this PR is ready for CI |
7 tasks
emcbot
added
CI-Gaeac6-Ready
TerrenceMcGuinness-NOAA
removed
CI-Gaeac6-Failed
aerorahul
reviewed
Oct 24, 2025
Comment on lines
+35
to
+36
| SOCA_INPUT_FIX_DIR: {{ HOMEgfs }}/fix/gdas/soca/1440x1080x75/soca | ||
| SOCA_ANL_GEOM: {{ HOMEgfs }}/fix/gdas/soca/720x540x75/soca |
Contributor
There was a problem hiding this comment.
Why are these not in config.base if they are used across so many jobs?
Contributor
Author
There was a problem hiding this comment.
Good point. I have another PR planned at some point to remove utilities from ush/python/pygfs/utils, so I will put them in config.base there.
emcbot
added
CI-Ursa-Running
Contributor
|
WCOSS2 g-w CI Install All jobs in all cases run on Cactus successfully completed all jobs with the exception of g-w CI case |
Contributor
Author
|
Thanks @RussTreadon-NOAA for the Cactus testing. Ursa and C6 pass as well. Merging |
Contributor
|
WCOSS2 g-w CI For the sake of consistency, document the fact that this PR successfully completed Thank you @DavidNew-NOAA for merging this PR in g-w |
This was referenced Oct 31, 2025
weihuang-jedi
added a commit
to NOAA-EPIC/global-workflow-cloud
that referenced
this pull request
Nov 5, 2025
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2 * 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud: reverse few changes re-sync with EMC repo Add master grib files to GFS HPSS archive for AIGFS (NOAA-EMC#4203) Update Snow filenames to comply with EE2 (NOAA-EMC#4195) Rename files for JEDI atm EE2 (NOAA-EMC#4193) Generate `pres_b` files for `RUN=gdas` and update `APCP` to `598`. (NOAA-EMC#4196) Update checks for MOM6 restarts when performing a re-run on failure (NOAA-EMC#4179) Decrease HPSS storage for GFS retros and address hpss bugs (NOAA-EMC#4184) Add noaacloud to ufsda case in dev/ush/load_modules (NOAA-EMC#4198) Remove replay from global workflow (NOAA-EMC#4182) Add IODA stats text file to COM (NOAA-EMC#4176) Update UFS_UTILS submodule (NOAA-EMC#4178) Atm COM File Rename to Standardized Form (NOAA-EMC#4117) Replace cp with cpfs/cpreq for atomic copies to COM directories (NOAA-EMC#4130) Create a UPP module for the global workflow (NOAA-EMC#4174) Refactor marine DA tasks (NOAA-EMC#4160) Delay ocean post-processing trigger to next-next forecast (NOAA-EMC#4167) Make options hashes Remove multiple option from static data template Fix static_data yaml (descriptions and labels) Fix static_data yaml (remove colon) Add Ursa to and remove C5 from list of HPCs in the bug report template (NOAA-EMC#4164) Rename marine (ocean/ice) files following EE2 conventions (NOAA-EMC#4162) Add attributes to Gaussian grid sfcanl file (NOAA-EMC#4149) Remove the snow analysis from archive (NOAA-EMC#4157) Update verif-global to fix pcp failures on special cases (NOAA-EMC#4154) Add CRTM fix directory paths to global-workflow (NOAA-EMC#4143) Update UFS Model (NOAA-EMC#4138) Add functionality to assimilate the new snow observations (NOAA-EMC#4132)
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 6, 2026
This PR, and companion to #1944 and NOAA-EMC/global-workflow#4160, does a few things: 1. It adds templates required for rendering the JEDI marine LETKF `local_ensemble_da` algorithm. 2. It adds a jinja switch to the marine obs YAMLs to turn on a halo distribution when running marine LETKF. 3. It adds the `marine_` prefix to two or three JCB variables.
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
# Description This PR does a couple things: 1. It consolidates all parm YAML files required for marine DA tasks into single master files for each task. 2. It adds parameters to the marine `jcb-base.yaml.j2` required for the marine LETKF templates to be rendered by JCB> 3. It removes the `MARINE_` prefix from `MARINE_WINDOW_*` input environment variables since these variables are now defined more generally in the new Python `Analysis` class in GW. # Companion PRs NOAA-EMC/jcb-gdas#194 NOAA-EMC/global-workflow#4160 # Issues ... # Automated CI tests to run in Global Workflow Will be tested with full GW CI suite with results posted to GW companion PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few changes, refactoring marine DA tasks:
Analysisclass. This class consolidates variables and methods universal to all JEDI DA tasks.Jediclass.marineanlletkf(required but missed until now) dependency to theearc_tarstask.Resolves #4161
Type of change
Change characteristics
How has this been tested?
Clone and build on Hera
Run all CI tests
Checklist