JCB companion to Global Workflow marine refactoring#194
Merged
Conversation
DavidNew-NOAA
requested review from
AndrewEichmann-NOAA,
guillaumevernieres and
shlyaeva
Contributor
Author
|
This PR and its companions are on hold until Rahul's https://github.com/NOAA-EMC/GDASApp/tree/feature/marine_rename branch is merged |
shlyaeva
approved these changes
Oct 21, 2025
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
Did not test; code changes look good to me.
AndrewEichmann-NOAA
approved these changes
Oct 21, 2025
Collaborator
AndrewEichmann-NOAA
left a comment
AndrewEichmann-NOAA
left a comment
There was a problem hiding this comment.
no complaints
guillaumevernieres
approved these changes
Oct 21, 2025
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @DavidNew-NOAA
Contributor
Author
|
Merging |
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Oct 23, 2025
# Description This PR does a couple things: 1. It consolidates all parm YAML files required for marine DA tasks into single master files for each task. 2. It adds parameters to the marine `jcb-base.yaml.j2` required for the marine LETKF templates to be rendered by JCB> 3. It removes the `MARINE_` prefix from `MARINE_WINDOW_*` input environment variables since these variables are now defined more generally in the new Python `Analysis` class in GW. # Companion PRs NOAA-EMC/jcb-gdas#194 NOAA-EMC/global-workflow#4160 # Issues ... # Automated CI tests to run in Global Workflow Will be tested with full GW CI suite with results posted to GW companion PR
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
# Description This PR does a couple things: 1. It consolidates all parm YAML files required for marine DA tasks into single master files for each task. 2. It adds parameters to the marine `jcb-base.yaml.j2` required for the marine LETKF templates to be rendered by JCB> 3. It removes the `MARINE_` prefix from `MARINE_WINDOW_*` input environment variables since these variables are now defined more generally in the new Python `Analysis` class in GW. # Companion PRs NOAA-EMC/jcb-gdas#194 NOAA-EMC/global-workflow#4160 # Issues ... # Automated CI tests to run in Global Workflow Will be tested with full GW CI suite with results posted to GW companion PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, and companion to NOAA-EMC/GDASApp#1944 and NOAA-EMC/global-workflow#4160, does a few things:
local_ensemble_daalgorithm.marine_prefix to two or three JCB variables.