Adding a gefs_arch task to GEFS workflow

[AntonMFernando-NOAA]

Description

• The gefs_arch task is not generated during the execution of the workflow setup scripts. It is only created when do_extractvars is set to true, with do_extractvars being false by default. This pull request ensures that the gefs_arch task will be created in the workflow regardless of the value of do_extractvars.

  Resolves The GEFS workflow does not create a gefs_arch task #3151

Type of change

• Bug fix (fixes something broken)
• New feature (adds functionality)
• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO
• Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)

How has this been tested?

• CI test on HERCULES and HERA

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have documented my code, including function, input, and output descriptions
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test or a new one has been added
• Any new scripts have been added to the .github/CODEOWNERS file with owners
• I have made corresponding changes to the system documentation if necessary

[WalterKolczynski-NOAA]

It's coming back to me why we only had the archive task when extract_vars is on: the archive job doesn't do much for GEFS right now when extract_vars is off (well, now it may archive the expdir). If you look at parm/archive/master_gefs.yaml.j2, all of the non-expdir included lists are extracted ones. There is a parm/archive/gefs_arcdir.yaml.j2, but it doesn't seem to be included anywhere.

I think to complete this, we need the following:

• The inclusion of the extracted files need to be hidden behind the DO_EXTRACTVARS flag (it should be failing right now if it is off)
• The gefs_arcdir file needs to be included when extract vars is off

@DavidHuber-NOAA @EricSinsky-NOAA please let me know if I'm incorrect here.

[DavidHuber-NOAA]

@WalterKolczynski-NOAA Yes, I think you are correct. There would need to be an if-block around

global-workflow/parm/archive/master_gefs.yaml.j2

Lines 7 to 12 in f1afac9

	{% filter indent(width=4) %}
	{% include "gefs_extracted_atmos.yaml.j2" %}
	{% include "gefs_extracted_ocean.yaml.j2" %}
	{% include "gefs_extracted_ice.yaml.j2" %}
	{% include "gefs_extracted_wave.yaml.j2" %}
	{% endfilter %}

[EricSinsky-NOAA]

To make things more simple, I believe we can remove the gefs_extracted* yaml files and only use gefs_arcdir.yaml.j2. The only place these gefs_extracted* yaml files are needed are in the feature/gefs_reforecast branch. I do not believe they are needed in develop if we use gefs_arcdir.yaml.j2.

[AntonMFernando-NOAA]

@WalterKolczynski-NOAA A CI test passed in HERCULES. @EricSinsky-NOAA Are you satisfied with the changes? If so we can go ahead and run CIs in the PR.

[EricSinsky-NOAA]

These changes look good. Thank you, @AntonMFernando-NOAA.

[emcbot]

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3211/RUNTESTS/EXPDIR/C48_S2SWA_gefs_59fb602b

[emcbot]

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3211

Experiment C96_S2SWA_gefs_replay_ics_59fb602b Completed 1 Cycles: *SUCCESS* at Thu Jan 16 10:38:46 UTC 2025
Experiment C48mx500_3DVarAOWCDA_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:44:50 UTC 2025
Experiment C48mx500_hybAOWCDA_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:50:55 UTC 2025
Experiment C48_ATM_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 10:50:56 UTC 2025
Experiment C96C48_hybatmaerosnowDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:04:27 UTC 2025
Experiment C48_S2SWA_gefs_59fb602b Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Thu Jan 16 12:04:54 UTC 2025
Experiment C48_S2SWA_gefs_59fb602b Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3211/RUNTESTS/COMROOT/C48_S2SWA_gefs_59fb602b/logs/2021032312/gefs_arch.log
Experiment C96_atm3DVar_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:10:20 UTC 2025
Experiment C96C48_hybatmDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:10:57 UTC 2025
Experiment C48_S2SW_59fb602b Completed 2 Cycles: *SUCCESS* at Thu Jan 16 12:28:42 UTC 2025
Experiment C96C48_ufs_hybatmDA_59fb602b Completed 3 Cycles: *SUCCESS* at Thu Jan 16 12:40:55 UTC 2025

[DavidHuber-NOAA]

@AntonMFernando-NOAA the parm/archive/gefs_extractvars* YAMLs should also be deleted. These will only be retained in the gefs_reforecast branch (not develop).

[DavidHuber-NOAA]

Changes look good to me. Will wait for @EricSinsky-NOAA's approval before starting CI testing.

[emcbot]

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3211

Experiment C48mx500_3DVarAOWCDA_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 18:58:29 UTC 2025
Experiment C48mx500_hybAOWCDA_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 19:04:47 UTC 2025
Experiment C48_ATM_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 19:10:48 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_c1b23a60 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 19:10:49 UTC 2025
Experiment C96C48_hybatmDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:19:12 UTC 2025
Experiment C96_atm3DVar_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:25:34 UTC 2025
Experiment C48_S2SWA_gefs_c1b23a60 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 20:26:22 UTC 2025
Experiment C96C48_hybatmaerosnowDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 20:31:48 UTC 2025
Experiment C48_S2SW_c1b23a60 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 20:57:59 UTC 2025
Experiment C96C48_ufs_hybatmDA_c1b23a60 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 21:11:18 UTC 2025