Set runtime shell requirements within Jenkins Pipeline#3171
Conversation
|
@AnilKumar-NOAA Oh I see now that you were referring to the |
|
Checkout Failed on Orion in Build# 6: Could not perform submodule update |
… a shell call to the node
|
CI Passed on Orion in Build# 1 |
… experment which should be its sole purpose, also did a which on gh incase it is not in ~/bin
aerorahul
left a comment
There was a problem hiding this comment.
changes to source gw_setup.sh are good.
A comment at the end of this PR re. GH might solve the shellnorm error. Please check.
Approve.
Yes, shellnorms spotted this too. Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
TerrenceMcGuinness-NOAA
left a comment
There was a problem hiding this comment.
committing update to launch script so exit works correctly when gh is not found
aerorahul
left a comment
There was a problem hiding this comment.
looks good.
@TerrenceMcGuinness-NOAA
Just a note here that "launch" is misspelled as "lanuch". Consequently, variables such as JENKINS_AGENT_LAUNCH_DIR is misspelled as JENKINS_AGENT_LANUCH_DIR. Not sure where that variable is defined.
This should probably be corrected in a future PR.
|
@TerrenceMcGuinness-NOAA |
* develop: Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199) Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171) Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193) Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197) Remove early-cycle EnKF forecast (NOAA-EMC#3185) Fix mod_icec bug in atmos_prod (NOAA-EMC#3167) Create compute build option (NOAA-EMC#3186) Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
Description
This PR updates the Jenkins Pipeline script to source
gw_setup.shfrom within the PR itself for when ever a shell command is issued that needs it.Currently the runtime bash shell environment requirements for running the global-workflow (set by sourcing
$HOMEgfs/workflow/gw_setup.sh) is established by the user's shell that makes the connection from the Java remote agent to the Jenkins Controller. This update simply sourcesgw_setup.shdirectly during run time when ever needed instead.NOTE: This does not apply for GitHub CLI and pyGitHub since they are not currently supported by Spack Stack and therefore not incorporated in to
gw_setup.sh. These remaining dependances are the responsibility of the role account holders that manage the Jenkins Controller to Node Agent connections.Type of change