Fix wave restarts and GEFS FHOUT/FHMAX#3009
Merged
DavidHuber-NOAA merged 15 commits intoOct 30, 2024
Merged
Conversation
Contributor
Author
|
ATTN: @weihuang-jedi |
aerorahul
reviewed
Oct 16, 2024
aerorahul
reviewed
Oct 16, 2024
aerorahul
requested changes
Oct 16, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
I think there is an issue in the forecast_postdet.sh part. Also a suggestion to break that into 2 parts.
Fixes some issues that were preventing wave restarts from operating
correctly.
First, the wave restart files were not being correctly linked from
`$DATA` to `$DATArestart`. The files are placed in the root of
`$DATA` instead of in `${DATA}/WAVE_RESTART`, so now links for the
individual files are created.
Second, the incorrect filenames were being searches for and copied
as part of a rerun. Filenames were geared towards multigrid waves,
which use the grid names, but single grid just uses a `ww3`. Since
multigrid waves are deprecated in workflow and will soon be removed
(NOAA-EMC#2637), these were updated only supporting the single-grid option.
These fixes allow forecast segments (and emergency restarts) to
work correctly when waves are on.
Resolves NOAA-EMC#3001
Removes an unnecessary loop when staging wave restarts and stops creating output links for restart files that were already copied in as ICs. Also updates FHMIN_WAV when running with segments to stop creating unneeded links from earlier in the forecast period.
WalterKolczynski-NOAA
force-pushed
the
hotfix/segs
branch
from
a11e004 to
6bbaa2b
Compare
Contributor
Author
|
Will need to add in additional fixes for GEFS perturbed members, as they are ignoring the segments. |
The gefs `config.efcs` still contained code from the enkf version of the file that was overwriting the FHMAX set for segments.
WalterKolczynski-NOAA
changed the title
weihuang-jedi
approved these changes
Oct 17, 2024
Contributor
|
I have test the PR code on Hercules. I worked as expected. Fixed the segments issue. |
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hercules-Building
Collaborator
|
Jenkins controller had technical difficulties and was off line. Clearing Hercules is under currently under maintenance. |
TerrenceMcGuinness-NOAA
removed
the
CI-Hercules-Building
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
WalterKolczynski-NOAA
added
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
|
Experiment C96_atm3DVar FAILED on Hercules in Build# 7 in |
|
Experiment C48_S2SW FAILED on Hercules in Build# 7 in |
|
Experiment C96C48_hybatmDA FAILED on Hercules in Build# 7 in |
|
Experiment C48_ATM FAILED on Hercules in Build# 7 in |
|
Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 7 in |
|
Experiment C48_S2SWA_gefs FAILED on Hercules in Build# 7 in |
emcbot
removed
the
CI-Hercules-Failed
|
CI Passed on Hercules in Build# 8 |
DavidHuber-NOAA
previously approved these changes
Oct 28, 2024
Contributor
|
I'm going to manually run just the GEFS tests on Hera. |
Contributor
|
All tests passed on Hera, but after a conversation with Walter and Kate, we will wait to merge this until an additional fix for the stage_ic job goes in. |
- Add elif for prior wave restart filename for when the new filename is not available in IC set. Refs NOAA-EMC#3001
|
CI Passed on Hercules in Build# 1 |
DavidHuber-NOAA
approved these changes
Oct 30, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some issues that were preventing wave restarts from operating correctly.
First, the wave restart files were not being correctly linked from
$DATAto$DATArestart. The files are placed in the root of$DATAinstead of in${DATA}/WAVE_RESTART, so now links for the individual files are created.Second, the incorrect filenames were being searches for and copied as part of a rerun. Filenames were geared towards multigrid waves, which use the grid names, but single grid just uses a
ww3. Since multigrid waves are deprecated in workflow and will soon be removed (#2637), these were updated only supporting the single-grid option.These fixes allow forecast segments (and emergency restarts) to work correctly when waves are on.
Additionally, the
FHMAX(andFHOUT) for perturbed GEFS members was being overwritten byconfig.efcsdue to remnant code from when it was copied from the EnKF version. This interfered with the segment setting for those GEFS members.Resolves #3001
Type of change
Change characteristics
How has this been tested?
Checklist