Add run and finalize methods to marine LETKF task by AndrewEichmann-NOAA · Pull Request #2944 · NOAA-EMC/global-workflow

AndrewEichmann-NOAA · 2024-09-19T19:03:30Z

Description

Adds run and finalize methods to marine LETKF task, experiment yaml for gw-ci in GDASApp, workflow additions, removes bugs found on the way, and completes the bulk of the work on LETKF task. Conversion of fields to increments pending.

Partially resolves NOAA-EMC/GDASApp#1091 and NOAA-EMC/GDASApp#1251

Mutual dependency with GDASApp PR NOAA-EMC/GDASApp#1287 and IC fix file issue #2944 (comment)

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)
- EMC verif-global
- GDAS
- GFS-utils
- GSI
- GSI-monitor
- GSI-utils
- UFS-utils
- UFS-weather-model
- wxflow

How has this been tested?

Example:

Cycled test on Hera

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

AndrewEichmann-NOAA · 2024-09-19T19:04:06Z

FYI @guillaumevernieres @CatherineThomas-NOAA

guillaumevernieres

We'll probably have to rearrange things between your PR and mine at some point, but this looks good to me. Thanks for doing this @AndrewEichmann-NOAA .

WalterKolczynski-NOAA · 2024-09-27T04:34:13Z

 declare -rx COM_OCEAN_RESTART_TMPL=${COM_BASE}'/model/ocean/restart'
 declare -rx COM_OCEAN_INPUT_TMPL=${COM_BASE}'/model/ocean/input'
 declare -rx COM_OCEAN_ANALYSIS_TMPL=${COM_BASE}'/analysis/ocean'
+declare -rx COM_OCEAN_LETKF_TMPL=${COM_BASE}'/analysis/ocean/letkf'


What files get written to the letkf directories vs the regular component analysis directories?

These are the analysis files from the LETKF, which are separate from the variational analysis files

WalterKolczynski-NOAA · 2024-10-30T08:04:00Z

Failed due to a system issue with modules we've seen before. Going to restart the test and also get started testing elsewhere since all other tests passed.

WalterKolczynski-NOAA · 2024-10-30T11:24:02Z

Running in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_2944

emcbot · 2024-10-30T12:38:57Z

CI Passed on Hercules in Build# 3
Built and ran in directory /work2/noaa/global/CI/HERCULES/2944


Experiment C48_ATM_9fa78132 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 05:12:25 CDT 2024
Experiment C96_S2SWA_gefs_replay_ics_9fa78132 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 05:36:51 CDT 2024
Experiment C96C48_hybatmDA_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 06:25:30 CDT 2024
Experiment C96_atm3DVar_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 06:31:22 CDT 2024
Experiment C48_S2SW_9fa78132 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 07:31:48 CDT 2024
Experiment C48_S2SWA_gefs_9fa78132 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 07:38:46 CDT 2024

emcbot · 2024-10-30T12:47:41Z

CI Passed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI/2944


Experiment C96_S2SWA_gefs_replay_ics_9fa78132 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 10:31:09 UTC 2024
Experiment C48_ATM_9fa78132 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 10:43:12 UTC 2024
Experiment C48mx500_3DVarAOWCDA_9fa78132 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 10:43:13 UTC 2024
Experiment C96C48_hybatmaerosnowDA_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 11:58:51 UTC 2024
Experiment C96C48_hybatmDA_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:04:20 UTC 2024
Experiment C96_atm3DVar_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:04:20 UTC 2024
Experiment C48_S2SWA_gefs_9fa78132 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 12:17:28 UTC 2024
Experiment C48_S2SW_9fa78132 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 12:47:31 UTC 2024
Experiment C96C48_ufs_hybatmDA_9fa78132 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:47:31 UTC 2024

Completes LETKF task, adds WCDA CI test Mutually dependent on NOAA-EMC/global-workflow#2944 --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov> Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>

* develop: Remove WAFS files and references from `develop` (NOAA-EMC#3263) fix intel stack version number on c5 (NOAA-EMC#3258) Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252) Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255) Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235) Only run METplus in the 3Dvar tests (NOAA-EMC#3245) Clone, build, and run C48_ATM and C48_S2SW on Gaea C5 and C6 (NOAA-EMC#3106) Add echgres as a dependency only for RUN=enkfgdas, not enkfgfs (NOAA-EMC#3246) Add domain level to wave gridded COM path (NOAA-EMC#3137) CI JJOB Tests using CMake (NOAA-EMC#3214) Make assorted updates to waves (NOAA-EMC#3190) Move WCOSS2 LD_LIBRARY_PATH patches to load_ufsda_modules.sh (NOAA-EMC#3236) Adding a gefs_arch task to GEFS workflow (NOAA-EMC#3211) Add additional GEFS variables needed for AI/ML applications (NOAA-EMC#3221) Add bmat task dependency to marine LETKF task (NOAA-EMC#3224) Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206) Separate use of initial increment/perturbation file from REPLAY/+03 ICs (NOAA-EMC#3119) Update gsi_enkf hash and gsi_ver (NOAA-EMC#3207) Remove cpus-per-task from APRUN_OCNANALECEN on WCOSS2 (NOAA-EMC#3212) Remove 5WAVH from AWIPS GRIB2 parm files (NOAA-EMC#3146) Remove multi-grid wave support (NOAA-EMC#3188) Add echgres as a dependency for earc (NOAA-EMC#3202) Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199) Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171) Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193) Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197) Remove early-cycle EnKF forecast (NOAA-EMC#3185) Fix mod_icec bug in atmos_prod (NOAA-EMC#3167) Create compute build option (NOAA-EMC#3186) Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998) Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175) Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163) Update compression options for GEFS history files (NOAA-EMC#3184) Update compression options for high res history files (NOAA-EMC#3178) Turn DO_TEST_MODE off (NOAA-EMC#3177) Hotfix for gdas_arch div/0 (NOAA-EMC#3169) Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow (NOAA-EMC#3098) Switch Aerosol DA to use JCB and Jedi class (NOAA-EMC#3125) Update ufs-weather-model to 2024-12-06 commit (NOAA-EMC#3145) Enable traditional threading as an option (NOAA-EMC#3149) Update HPC_ACCOUNT on Hercules to fv3-cpu (NOAA-EMC#3164) Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test (NOAA-EMC#3120) Update GSI analysis jobs to use COMIN/COMOUT (NOAA-EMC#3092) Update HPC Tier Definitions (NOAA-EMC#3138) Add marine hybrid envar (NOAA-EMC#3041) Archive the experiment directory along with git status/diff output (NOAA-EMC#3105) Use stochastic restart patterns on rerun (NOAA-EMC#3077) Point Jenkinsfile back to CI/ (NOAA-EMC#3139) Fix wave restart for cold start and add ic version file (NOAA-EMC#3112) Allow users to override the default account at setup time (NOAA-EMC#3127) Refactor gridded wave post (NOAA-EMC#3014) Update docs related to NOAA CSPs (NOAA-EMC#3043) Allow APP to differ between RUNs (NOAA-EMC#2943) Run one executable for soca2cice (instead of two) (NOAA-EMC#3118) Speed up GSI analysis jobs in CI testing (NOAA-EMC#3115) Make aerosol output frequency variable (NOAA-EMC#2982) Add new stations to GFS BUFR sounding products (NOAA-EMC#3107) JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring (NOAA-EMC#2992) Enable tapering of atm ens perts at the model top (NOAA-EMC#3097) Update JGDAS ENKF POST job (NOAA-EMC#3090) SFS Runs at C96mx100 (NOAA-EMC#2960) Move machine-based options from config.base to host files (NOAA-EMC#3053) Remove RUNDIRS before running CI cases to cover re-run events (NOAA-EMC#3076) CI GitHub pipeline (hotfix) update for fetching repo name (NOAA-EMC#3084) Update JGDAS ENKF ECEN job (NOAA-EMC#3050) Update snow obs processing job (NOAA-EMC#3055) Update to action workflow pipeline in default repo for development (NOAA-EMC#3062) Update to action workflow pipeline in default repo for development (NOAA-EMC#3061) Update workflow pipeline (NOAA-EMC#3060) PW CI pipeline update5 ready for review so it can be merged and tested (NOAA-EMC#3059) Revert "GitHub CI Pipeline update for debugging forked PR support" (NOAA-EMC#3057) GitHub CI Pipeline update for debugging forked PR support (NOAA-EMC#3056) Add more ocean variables for post-processing in GEFS (NOAA-EMC#2995) Auto provisioning of PW clusters from GitHub CI added (NOAA-EMC#3051) Fix the name of the TC tracker filenames in archive.py (NOAA-EMC#3030) Make wxflow links static instead of from link_workflow (NOAA-EMC#3008) Update global jdas enkf diag job with COMIN/COMOUT for COM prefix (NOAA-EMC#2959) Add run and finalize methods to marine LETKF task (NOAA-EMC#2944) Fix wave restarts and GEFS FHOUT/FHMAX (NOAA-EMC#3009) Disabling hyper-threading (NOAA-EMC#2965) GitHub Actions Pipeline Updates for Self-Hosted Runners on PW (NOAA-EMC#3018) CI jekninsfile update hotfix (NOAA-EMC#3038) Update gdas.cd (NOAA-EMC#2978) Add ability to add tag to pslots with generate_workflows (NOAA-EMC#3036) CI update to shell environment with HOMEgfs to HOME_GFS for systems that need the path (NOAA-EMC#3013) Quick updated to Jenkins (health check) launch script (NOAA-EMC#3033) Document the generate_workflows.sh script (NOAA-EMC#3028) Replace gfs_cyc with an interval (NOAA-EMC#2928) Hotfix: Fix generate_workflows.sh optional build flags (NOAA-EMC#3024) Add a tool to run multiple YAML cases locally (NOAA-EMC#3004) Hotfix: Correctly set overwrite option when specified (NOAA-EMC#3021)

Completes LETKF task, adds WCDA CI test Mutually dependent on NOAA-EMC/global-workflow#2944 --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov> Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>

AndrewEichmann-NOAA added 14 commits August 21, 2024 18:01

debugging for ocean ensemble run

20e48a1

Merge branch 'develop' into feature/ens-WCDA-ctest

16d805f

fix ci stager for ensemble + DO_IAU

f749b3f

Merge branch 'develop' into feature/ens-WCDA-ctest

9501e74

removing ice var changer

6b1832a

Merge branch 'develop' into feature/ens-WCDA-ctest

7f30c33

the latests

581f1c3

Merge branch 'develop' into feature/ens-WCDA-ctest

0dcf183

removal of cruft

6a2cd3d

undo odd thing

fb55a4e

style

398ec22

style

f314c2a

style

c7cb09e

removed personal bits

1e53cb5

AndrewEichmann-NOAA mentioned this pull request Sep 19, 2024

Completes LETKF task, adds WCDA CI test NOAA-EMC/GDASApp#1287

Merged

guillaumevernieres reviewed Sep 19, 2024

View reviewed changes

Comment thread ush/python/pygfs/task/marine_letkf.py

guillaumevernieres reviewed Sep 19, 2024

View reviewed changes

Comment thread ush/python/pygfs/task/marine_letkf.py Outdated

Comment thread workflow/rocoto/gfs_tasks.py Outdated

Comment thread workflow/rocoto/gfs_tasks.py Outdated

AndrewEichmann-NOAA mentioned this pull request Sep 20, 2024

Add enkfgdas.20210324 to ICSDIR/C48mx500 #2945

Closed

4 tasks

AndrewEichmann-NOAA and others added 6 commits September 20, 2024 09:24

Merge branch 'develop' into feature/ens-WCDA-ctest

36fa89c

the great deawkwarding

c66994e

using communal ICs

1069b58

Merge branch 'develop' into feature/ens-WCDA-ctest

e77db56

renaming

5c21402

rearrange task deps

e6bc17b

AndrewEichmann-NOAA commented Sep 26, 2024

View reviewed changes

Comment thread workflow/rocoto/gfs_tasks.py

Merge branch 'develop' into feature/ens-WCDA-ctest

4472499

WalterKolczynski-NOAA requested changes Sep 27, 2024

View reviewed changes

AndrewEichmann-NOAA added 2 commits September 30, 2024 13:42

merge cleanup

b19d000

debugging after merge

926bbc3

WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Oct 30, 2024

WalterKolczynski-NOAA added the CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 label Oct 30, 2024

WalterKolczynski-NOAA added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Oct 30, 2024

emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Oct 30, 2024

guillaumevernieres approved these changes Oct 30, 2024

View reviewed changes

emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 30, 2024

WalterKolczynski-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Oct 30, 2024

WalterKolczynski-NOAA approved these changes Oct 30, 2024

View reviewed changes

WalterKolczynski-NOAA merged commit 0b3304e into NOAA-EMC:develop Oct 30, 2024

Conversation

AndrewEichmann-NOAA commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

AndrewEichmann-NOAA commented Sep 19, 2024

Uh oh!

Uh oh!

guillaumevernieres left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WalterKolczynski-NOAA Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

AndrewEichmann-NOAA Oct 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WalterKolczynski-NOAA commented Oct 30, 2024

Uh oh!

WalterKolczynski-NOAA commented Oct 30, 2024

Uh oh!

emcbot commented Oct 30, 2024

Uh oh!

emcbot commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AndrewEichmann-NOAA commented Sep 19, 2024 •

edited

Loading