Make aerosol output frequency variable#2982
Conversation
WalterKolczynski-NOAA
requested review from
CoryMartin-NOAA,
DavidHuber-NOAA and
aerorahul
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
I didn't test but this looks good to me
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Looks good.
Question:
Not for this PR to address -- how diffferent is the parm/ufs/gocart/AERO_HISTORY.rc file in the global-workflow from the one in ufs-weather-model?
@aerorahul Looks like they have already templated the one frequency we use, but not the others. A couple other small changes (also whitespace changes not shown): (This is against our develop, not the changes in this PR.) |
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
TerrenceMcGuinness-NOAA
removed
the
CI-Hera-Building
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Experiment C48_ATM FAILED on Hera in Build# 2 in |
|
Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 2 in |
|
Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 in |
|
Experiment C96_atm3DVar FAILED on Hera in Build# 2 in |
|
Experiment C48_S2SW FAILED on Hera in Build# 2 in |
|
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 2 in |
|
Experiment C96C48_hybatmDA FAILED on Hera in Build# 2 in |
|
Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 in |
emcbot
added
CI-Hera-Failed
|
Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 2 with error logs: Follow link here to view the contents of the above file(s): (link) |
|
Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 2 in |
|
CI Failed on Hercules in Build# 2 |
Moves computation of GOCART output times to postdet, since FHROT is not computed until then.
|
Build FAILED on Hercules in Build# 3 with error logs: Follow link here to view the contents of the above file(s): (link) |
Makes GOCART output times a function since it is needed in two places.
The defulats file for GEFS was missing an entry for aero to ensure @field@ get parsed at expt setup time. This was added to gfs as part of NOAA-EMC#3053, but gefs was missed.
|
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 with error logs: Follow link here to view the contents of the above file(s): (link) |
|
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 in |
|
CI Failed on Hera in Build# 4 |
|
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs: Follow link here to view the contents of the above file(s): (link) |
|
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in |
|
Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 1 in |
|
CI Failed on Hera in Build# 1 |
|
CI Passed on Hera in Build# 2 Experiment C96C48_ufs_hybatmDA_90b49ff2 Terminated with tasks failed and dead at Tue Nov 19 18:42:49 UTC 2024 |
|
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_2982/RUNTESTS on WCOSS |
|
CI Passed on Hercules in Build# 3 |
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
The content looks good, just some suggestions on comments and future issues.
7 participants
Description
The
AERO_HISTORY.rcfile that controls the GOCART output is turned into a template usint@[ ]syntax to allow for variable output times. A new "parsing" script is created for GOCART that handles parsing theAERO_HISTORY.rcfile throughatparse. Other manip- ulation of these files is also moved to the new parsing script to be consistent with other components.A new variable,
FHOUT_AEROis introduced to control the output frequency of the GOCART output. This is initially set to 3 to match other components (this is a change from the current value of 6). Since some aerosol fields are also included as part of the atmos output, it may be desirable to meld this back intoFHOUTlater. However, the atmos output has two frequencies (FHOUT_HFandFHOUT), a feature not supported by other components.The RUN lists for aero fcst, aero analysis, and waves is simplified to avoid confusion, since there is no need for them to only be set if the components are on.
Resolves #2072
Type of change
Change characteristics
How has this been tested?
AERO_FCST_RUN)Checklist