Move machine-based options from config.base to host files#3053
Conversation
|
This will break the |
|
There is an issue with the Marking ready for review. |
There was a problem hiding this comment.
This is a commendable PR and a key demonstration of how to refactor an "if-y diff-y" system specific configuration construct into a more centralized and pythonic approach. I particularly liked how you enhanced the formation of the defaulting overrides.
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
Minor things and one thing to sneak in (or leave for another time).
|
WCOSS is failing for a couple reasons:
Seems like the WCOSS upgrade changed something with jinja. CC @aerorahul |
Load Python module for WCOSS2 setup
|
Updated the WCOSS2 module files to load Python 3.8.6 into the environment. This should resolve the errors seen during CI testing and issue #3087. |
|
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3053/RUNTESTS on WCOSS |
aerorahul
left a comment
There was a problem hiding this comment.
looks good. Thanks for including the fix to the jinja2 error on wcoss2
|
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3053/RUNTESTS on WCOSS |
1 similar comment
|
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3053/RUNTESTS on WCOSS |
|
Other active tests pass. |
|
I disabled the UFS DA tests for WCOSS2 as part of this PR. Thanks for the heads up. |
|
@DavidHuber-NOAA |
|
Yes, I am confident in this PR. Here is a summary of testing done on WCOSS2:
|
|
@RussTreadon-NOAA |
|
I have a hunch (but no evidence) that #3124 may be related to this? |
Description
This moves all machine-specific options to the workflow/hosts files from the config.* files.
This also turns HPSS archiving on for WCOSS2 by default.
Resolves #2942
Resolves #3087
Type of change
Change characteristics
How has this been tested?
CI testing on Hercules. The tracker and genesis jobs did not run (as expected).
WCOSS2 testing still needs to be performed.
Checklist