Update g-w to cycle with C1152 ATM

[CatherineThomas-NOAA]

Description

There are a few updates needed to cycle with the C1152 atmospheric model:

• config.resources(.$machine): include C1152 case options for DA tasks
• gdasfcst config.ufs: WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GDAS=20
• source code update for calc_analysis (replace 3d array with 2d array in add_psfc_increment GSI-utils#59) for memory
• resource change needed for atmanl upp

Note that any needed changes to time limits for C1152 will be addressed at a later date.

Resolves #3173

Type of change

• New feature (adds functionality)

Change characteristics

• Is this a breaking change (a change in existing functionality)? YES
• Does this change require a documentation update? YES
• Does this change require an update to any of the following submodules? YES
  • GSI-utils replace 3d array with 2d array in add_psfc_increment GSI-utils#59

How has this been tested?

• Cycled C1152/C384 ATM-only on WCOSS2

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have documented my code, including function, input, and output descriptions
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test or a new one has been added
• Any new scripts have been added to the .github/CODEOWNERS file with owners
• I have made corresponding changes to the system documentation if necessary

[aerorahul]

looks good to me.

[aerorahul]

Running the CI on Hera and Hercules to cover the gsi-utils hash update. The other changes will not be tested in the CI

[emcbot]

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gdas_analcalc.log
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gfs_analcalc.log

Follow link here to view the contents of the above file(s): (link)

[emcbot]

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_c7b3010b

[RussTreadon-NOAA]

The gfs and gdas analcalc failures in C96C48_ufs_hybatmDA are true errors.

calc_anl.x aborts with

 Computing and Adding Surface Pressure Increment
 rank of data array != variable ndims (or ndims-1)
...
 rank of data array != variable ndims (or ndims-1)
99
srun: Received task exit notification for 31 tasks of StepId=4860606.2 (status=0x6300).
srun: error: h6c28: tasks 96-126: Exited with exit code 99

when processing ensemble resolution files.

[emcbot]

CI Failed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3206

Experiment C48_ATM_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:10:21 UTC 2025
Experiment C96C48_ufs_hybatmDA_c7b3010b Terminated with 0
FAIL
FAIL tasks failed and 2 dead at Tue Jan  7 00:16:16 UTC 2025
Experiment C96C48_ufs_hybatmDA_c7b3010b Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gdas_analcalc.log
/scratch1/NCEPDEV/global/CI/3206/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_c7b3010b/logs/2024022400/gfs_analcalc.log
Experiment C48mx500_3DVarAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:16:30 UTC 2025
Experiment C48mx500_hybAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:23:23 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_c7b3010b Completed 1 Cycles: *SUCCESS* at Tue Jan  7 00:23:35 UTC 2025
Experiment C96C48_hybatmDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:29:07 UTC 2025
Experiment C96C48_hybatmaerosnowDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:29:39 UTC 2025
Experiment C96_atm3DVar_c7b3010b Completed 3 Cycles: *SUCCESS* at Tue Jan  7 01:35:12 UTC 2025
Experiment C48_S2SW_c7b3010b Completed 2 Cycles: *SUCCESS* at Tue Jan  7 02:26:29 UTC 2025
Experiment C48_S2SWA_gefs_c7b3010b Completed 1 Cycles: *SUCCESS* at Tue Jan  7 02:57:23 UTC 2025

[emcbot]

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3206

Experiment C48_ATM_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:39:25 CST 2025
Experiment C48mx500_3DVarAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:45:33 CST 2025
Experiment C48mx500_hybAOWCDA_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:51:44 CST 2025
Experiment C96_S2SWA_gefs_replay_ics_c7b3010b Completed 1 Cycles: *SUCCESS* at Mon Jan  6 18:34:41 CST 2025
Experiment C96_atm3DVar_c7b3010b Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:46:13 CST 2025
Experiment C96C48_hybatmDA_c7b3010b Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:46:30 CST 2025
Experiment C48_S2SW_c7b3010b Completed 2 Cycles: *SUCCESS* at Mon Jan  6 19:23:11 CST 2025
Experiment C48_S2SWA_gefs_c7b3010b Completed 1 Cycles: *SUCCESS* at Mon Jan  6 21:19:23 CST 2025

[RussTreadon-NOAA]

Examine the guess and increment files read by the calc_analysis code. GSI based atmospheric increment files contain

float delp_inc(lev, lat, lon) ;

whereas GDASApp based atmospheric increment files contain

        double delp_inc(time, lev, lat, lon) ;

GDASApp increment files add a time dimension to the increment array.

[RussTreadon-NOAA]

@CatherineThomas-NOAA , the sorc/gsi_utils.fd hash in CatherineThomas-NOAA:c1152_cyc can be updated to f716012.

The changes in f716012 have been tested in g-w CI C96C48_hybatmDA and C96C48_ufs_hybatmDA on Cactus. gfs_analcalc and gdas_analcalc successfully ran to completion in both configurations.

[CatherineThomas-NOAA]

Thanks @RussTreadon-NOAA for the gsi_utils update.

I tested the gsi_utils update in my C1152 exp and had no issues. I've updated my fork with the new gsi_utils hash as well as merged in the latest g-w develop. I think this PR is ready to retest @aerorahul.

[emcbot]

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3206/RUNTESTS on WCOSS

[WalterKolczynski-NOAA]

This passed on Hera but the label didn't get set.