Merged
Conversation
chore(python): drop support for Python 3.8
chore: implement yaml settings inheritance
feat: add safeguards for partially validated transactions [part 2/2]
…WS_MAX_SUBS_ADDRS_EMPTY to infinite
This wasn't _exactly_ the case before this commit. On one side when using the deprecated module settings the same module would always be loaded, and the same `SETTINGS` property would be accessed, but reloading the module (or at least leaving that up to importlib) unnecessary. On the new YAML system the file is reloaded everytime, this is also unnecessary. This commit will make it the last HathorSettings instantiated will be returned, as long as the source is the same, otherwise an exception is raised. There is a little small caveat that is fixed in this commit is that in the YAML file could in theory be altered between different calls to HathorSettings, which would lead to different content being loaded silently. What happens now is that the first time it is loaded is what is used for every call, any change in the file won't have any effect.
refactor(settings): make HathorSettings always return the same instance
chore(bump): v0.54.0
Release-candidate v0.54.0-rc.1
Codecov Report
@@ Coverage Diff @@
## release #659 +/- ##
===========================================
+ Coverage 83.45% 83.95% +0.49%
===========================================
Files 221 240 +19
Lines 19144 20126 +982
Branches 2623 2743 +120
===========================================
+ Hits 15977 16896 +919
- Misses 2589 2635 +46
- Partials 578 595 +17
|
pedroferreira1
approved these changes
Jun 12, 2023
luislhl
approved these changes
Jun 12, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically promoting v0.54.0-rc1 to v0.54.0
Release candidates:
Changes: