feat: add safeguards for partially validated transactions [part 2/2]#617
Merged
feat: add safeguards for partially validated transactions [part 2/2]#617
Conversation
03f711b to
328e50b
Compare
msbrogli
requested changes
May 18, 2023
328e50b to
dedf8b5
Compare
msbrogli
requested changes
May 18, 2023
msbrogli
reviewed
May 18, 2023
msbrogli
previously approved these changes
May 19, 2023
87537d7 to
33fb275
Compare
a7609b1 to
95713b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 83.78% 83.84% +0.05%
==========================================
Files 238 237 -1
Lines 19990 20016 +26
Branches 2735 2731 -4
==========================================
+ Hits 16749 16782 +33
+ Misses 2642 2635 -7
Partials 599 599
|
msbrogli
requested changes
May 19, 2023
13c1243 to
e4ab48e
Compare
msbrogli
requested changes
May 23, 2023
e4ab48e to
f7b7cd8
Compare
8355781 to
201047e
Compare
msbrogli
approved these changes
May 24, 2023
glevco
approved these changes
May 24, 2023
31c3534 to
5005cb6
Compare
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was split out from #577. The main objective is to be able to do this:
This change is only exists to reduce the scope where the storage APIs accept reading/writing partially validated transactions so that the changes needed by sync-v2 can have a very reduced an limited impact on the rest of the node. The previous iteration of this protection was made using a
allow_partially_validated: boolargument on most APIs, that ended up being not only verbose, but more error prone and needed to carry thisallow_partially_validatedin a lot of places that shouldn't have to know about that.Acceptance Criteria