refactor(p2p): Build ConnectionsManager in builder#622
Merged
Conversation
743f4d9 to
6d1fe41
Compare
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 83.74% 83.63% -0.12%
==========================================
Files 236 232 -4
Lines 19949 19857 -92
Branches 2727 2712 -15
==========================================
- Hits 16707 16608 -99
- Misses 2643 2650 +7
Partials 599 599
|
glevco
previously approved these changes
May 22, 2023
jansegre
previously approved these changes
May 22, 2023
6d1fe41 to
f822d88
Compare
jansegre
approved these changes
May 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
ConnectionsManagerin builders.ssl: bool,enable_sync_v1,enable_sync_v1_1, andenable_sync_v2toConnectionsManager.HathorManager.server_factoryandHathorManager.client_factory.Note
There are still some network-related attributes and methods on
HathorManager. I'll move those on a separate refactor to keep this one small for reviewers. Some attributes and methods yet-to-be moved out ofHathorManagerare:listen_addresses: List[str]capabilitieshas_sync_version_capability()add_peer_to_whitelist()remove_peer_from_whitelist_and_disconnect()listen()do_discovery()