refactor: move hathor settings to yaml configuration files [part 1/2]#593
refactor: move hathor settings to yaml configuration files [part 1/2]#593
Conversation
31c24a8 to
103e8a5
Compare
9d41d0a to
49cd371
Compare
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 83.68% 83.65% -0.03%
==========================================
Files 231 232 +1
Lines 19622 19675 +53
Branches 2687 2695 +8
==========================================
+ Hits 16421 16460 +39
- Misses 2608 2619 +11
- Partials 593 596 +3
|
Makes sense, done in e0c35ad. I used
I created an issue for that in #614. I left it in the To Do column of our project I'll do it as soon as I close some of the current tasks. |
Acceptance Criteria
pyyamldependency (the go to, canonical yaml implementation for python, repo)HathorSettingsnamed tuple to create it from a dict or a yaml file, leveraging pydantic for validationyamlfiles to substitute python config files for all network settings (mainnet,testnet, andunitttests).get_settings.HathorSettings()to get settings from yaml files instead of python modules.yamlversions of settings are equal to their python versions, during the migration.