feat(events): realiable integration during the load phase#555
Merged
feat(events): realiable integration during the load phase#555
Conversation
fcbd809 to
f9d7168
Compare
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 83.63% 83.68% +0.04%
==========================================
Files 230 231 +1
Lines 19536 19622 +86
Branches 2681 2687 +6
==========================================
+ Hits 16339 16420 +81
- Misses 2607 2608 +1
- Partials 590 594 +4
|
msbrogli
requested changes
Apr 18, 2023
jansegre
reviewed
Apr 20, 2023
f9ab285 to
94e0f34
Compare
jansegre
previously approved these changes
Apr 25, 2023
1e93b80 to
975e1db
Compare
fbebb80 to
975e1db
Compare
aae98a1 to
33a1b40
Compare
975e1db to
64a7787
Compare
c10b442 to
3ee9570
Compare
64a7787 to
3887174
Compare
3887174 to
b55a59c
Compare
msbrogli
approved these changes
May 16, 2023
jansegre
approved these changes
May 16, 2023
10c380f to
75f3d66
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement changes described in HathorNetwork/rfcs#52
Acceptance Criteria:
EventStoragefunctionalityNodeStateHathorManagerevent_storagearg, makeevent_managerrequired, and addenable_event_queueEventManagerto support handling of LOAD phase events--x-emit-load-eventsCLI flag, as it's not necessary anymore in the way events are handled in the LOAD phasebytes_to_int()function intransaction.util