Skip to content

feat(events): realiable integration during the load phase#555

Merged
glevco merged 21 commits intomasterfrom
feat/reliable-integration-load
May 16, 2023
Merged

feat(events): realiable integration during the load phase#555
glevco merged 21 commits intomasterfrom
feat/reliable-integration-load

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Apr 13, 2023

Implement changes described in HathorNetwork/rfcs#52

Acceptance Criteria:

  • Implement new EventStorage functionality
    • Storage and retrieval of NodeState
    • Storage and retrieval of event queue feature state
    • Clearing events
  • Update HathorManager
    • Remove event_storage arg, make event_manager required, and add enable_event_queue
    • Initialization fails if it starts without the event queue feature, and it was enabled in a previous start
    • Handling of LOAD phase events
  • Update EventManager to support handling of LOAD phase events
  • Remove --x-emit-load-events CLI flag, as it's not necessary anymore in the way events are handled in the LOAD phase
  • New bytes_to_int() function in transaction.util

@glevco glevco self-assigned this Apr 13, 2023
@glevco glevco changed the title Feat/reliable integration load feat(events): realiable integration during the load phase Apr 13, 2023
@glevco glevco force-pushed the feat/reliable-integration-load branch from fcbd809 to f9d7168 Compare April 17, 2023 15:20
@glevco glevco marked this pull request as ready for review April 17, 2023 15:34
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #555 (75f3d66) into master (b455e74) will increase coverage by 0.04%.
The diff coverage is 89.91%.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   83.63%   83.68%   +0.04%     
==========================================
  Files         230      231       +1     
  Lines       19536    19622      +86     
  Branches     2681     2687       +6     
==========================================
+ Hits        16339    16420      +81     
- Misses       2607     2608       +1     
- Partials      590      594       +4     
Impacted Files Coverage Δ
hathor/builder/resources_builder.py 94.23% <0.00%> (ø)
hathor/pubsub.py 94.66% <ø> (ø)
hathor/manager.py 70.91% <70.00%> (-0.13%) ⬇️
hathor/builder/builder.py 90.87% <83.33%> (-0.25%) ⬇️
hathor/event/event_manager.py 90.74% <84.61%> (-5.69%) ⬇️
hathor/event/storage/rocksdb_storage.py 93.90% <96.66%> (+2.67%) ⬆️
hathor/builder/cli_builder.py 71.66% <100.00%> (-0.32%) ⬇️
hathor/event/model/node_state.py 100.00% <100.00%> (ø)
hathor/event/storage/event_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/memory_storage.py 100.00% <100.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

@glevco glevco force-pushed the feat/reliable-integration-load branch from f9ab285 to 94e0f34 Compare April 20, 2023 17:59
@jansegre jansegre changed the base branch from dev to master April 20, 2023 19:25
jansegre
jansegre previously approved these changes Apr 25, 2023
@glevco glevco force-pushed the feat/reliable-integration-load branch 2 times, most recently from 1e93b80 to 975e1db Compare April 26, 2023 20:09
@glevco glevco changed the base branch from master to chore/builder-methods April 27, 2023 03:40
@glevco glevco marked this pull request as draft April 27, 2023 03:40
@glevco glevco force-pushed the feat/reliable-integration-load branch from fbebb80 to 975e1db Compare April 27, 2023 15:18
@glevco glevco force-pushed the chore/builder-methods branch 3 times, most recently from aae98a1 to 33a1b40 Compare April 27, 2023 21:29
@glevco glevco force-pushed the feat/reliable-integration-load branch from 975e1db to 64a7787 Compare April 27, 2023 22:15
@glevco glevco force-pushed the chore/builder-methods branch from c10b442 to 3ee9570 Compare April 28, 2023 18:36
@glevco glevco force-pushed the feat/reliable-integration-load branch from 64a7787 to 3887174 Compare April 28, 2023 18:38
Base automatically changed from chore/builder-methods to master April 28, 2023 20:37
@glevco glevco force-pushed the feat/reliable-integration-load branch from 3887174 to b55a59c Compare May 2, 2023 02:19
@glevco glevco marked this pull request as ready for review May 2, 2023 03:33
@glevco glevco force-pushed the feat/reliable-integration-load branch from 10c380f to 75f3d66 Compare May 16, 2023 12:13
@glevco glevco merged commit 54a1969 into master May 16, 2023
@glevco glevco deleted the feat/reliable-integration-load branch May 16, 2023 16:23
@jansegre jansegre mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants