refactor(stratum): Build StratumFactory on builder#619
Merged
Conversation
213df11 to
7893401
Compare
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 83.66% 83.62% -0.04%
==========================================
Files 232 232
Lines 19781 19788 +7
Branches 2707 2707
==========================================
- Hits 16550 16548 -2
- Misses 2634 2640 +6
- Partials 597 600 +3
|
glevco
previously approved these changes
May 19, 2023
Contributor
glevco
left a comment
There was a problem hiding this comment.
I'm approving this, but I left two suggestion comments. I guess they could be done in the future, so feel free to resolve the threads.
7893401 to
efb8bbe
Compare
efb8bbe to
9ba84cc
Compare
glevco
approved these changes
May 19, 2023
jansegre
approved these changes
May 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
StratumFactoryin the builders.run_nodecli command.