Skip to content

refactor(stratum): Build StratumFactory on builder#619

Merged
msbrogli merged 1 commit intomasterfrom
refactor/builder-stratum
May 19, 2023
Merged

refactor(stratum): Build StratumFactory on builder#619
msbrogli merged 1 commit intomasterfrom
refactor/builder-stratum

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented May 19, 2023

Acceptance criteria

  1. Build StratumFactory in the builders.
  2. Listen to TCP port only on run_node cli command.

@msbrogli msbrogli self-assigned this May 19, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner May 19, 2023 05:49
@msbrogli msbrogli force-pushed the refactor/builder-stratum branch 3 times, most recently from 213df11 to 7893401 Compare May 19, 2023 06:17
@msbrogli msbrogli requested a review from glevco May 19, 2023 06:18
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #619 (9ba84cc) into master (33fb275) will decrease coverage by 0.04%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   83.66%   83.62%   -0.04%     
==========================================
  Files         232      232              
  Lines       19781    19788       +7     
  Branches     2707     2707              
==========================================
- Hits        16550    16548       -2     
- Misses       2634     2640       +6     
- Partials      597      600       +3     
Impacted Files Coverage Δ
hathor/builder/cli_builder.py 70.43% <20.00%> (-1.40%) ⬇️
hathor/builder/builder.py 91.11% <100.00%> (+0.24%) ⬆️
hathor/manager.py 70.64% <100.00%> (-0.27%) ⬇️
hathor/stratum/stratum.py 69.13% <100.00%> (-0.19%) ⬇️

... and 4 files with indirect coverage changes

glevco
glevco previously approved these changes May 19, 2023
Copy link
Contributor

@glevco glevco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but I left two suggestion comments. I guess they could be done in the future, so feel free to resolve the threads.

@msbrogli msbrogli force-pushed the refactor/builder-stratum branch from efb8bbe to 9ba84cc Compare May 19, 2023 16:00
@msbrogli msbrogli merged commit 9ba84cc into master May 19, 2023
@msbrogli msbrogli deleted the refactor/builder-stratum branch May 19, 2023 18:07
@jansegre jansegre mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants