Skip to content

chore: add yamllint to all files#598

Merged
glevco merged 2 commits intomasterfrom
chore/yaml-lint
May 17, 2023
Merged

chore: add yamllint to all files#598
glevco merged 2 commits intomasterfrom
chore/yaml-lint

Conversation

@glevco
Copy link
Copy Markdown
Contributor

@glevco glevco commented May 11, 2023

Acceptance Criteria

  • Install yamllint (repo)
  • Configure yamllint to lint all yaml files in the project, and update files accordingly

@glevco glevco self-assigned this May 11, 2023
@glevco glevco marked this pull request as ready for review May 11, 2023 17:43
@glevco glevco requested review from jansegre and msbrogli as code owners May 11, 2023 17:43
@glevco glevco requested review from luislhl and removed request for jansegre May 11, 2023 17:44
@codecov
Copy link
Copy Markdown

codecov bot commented May 11, 2023

Codecov Report

Merging #598 (51efcff) into master (54a1969) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   83.69%   83.69%   -0.01%     
==========================================
  Files         231      231              
  Lines       19622    19622              
  Branches     2687     2687              
==========================================
- Hits        16423    16422       -1     
  Misses       2607     2607              
- Partials      592      593       +1     

see 1 file with indirect coverage changes

luislhl
luislhl previously approved these changes May 15, 2023
@glevco glevco force-pushed the refactor/settings branch from 48715e3 to f1e1ae8 Compare May 15, 2023 22:48
@glevco glevco force-pushed the chore/yaml-lint branch from 9f0ff15 to 7e502d8 Compare May 15, 2023 22:53
msbrogli
msbrogli previously approved these changes May 16, 2023
@glevco glevco force-pushed the chore/yaml-lint branch from 7e502d8 to 915faa1 Compare May 16, 2023 21:35
@glevco glevco changed the base branch from refactor/settings to master May 16, 2023 21:36
@glevco glevco dismissed stale reviews from msbrogli and luislhl May 16, 2023 21:36

The base branch was changed.

@glevco glevco requested review from luislhl and msbrogli May 16, 2023 21:39
@glevco glevco force-pushed the chore/yaml-lint branch from 915faa1 to 51efcff Compare May 16, 2023 21:55
@glevco glevco merged commit 0b70976 into master May 17, 2023
@glevco glevco deleted the chore/yaml-lint branch May 17, 2023 14:19
@jansegre jansegre mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants