chore(python): drop support for Python 3.8#615
Merged
Conversation
glevco
approved these changes
May 17, 2023
msbrogli
approved these changes
May 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 83.68% 83.69% +0.01%
==========================================
Files 231 231
Lines 19622 19622
Branches 2687 2687
==========================================
+ Hits 16420 16422 +2
+ Misses 2609 2607 -2
Partials 593 593 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR we will be able to use annotations like
dict[str, int]instead ofDict[str, int](and having to importtyping.Dict).Acceptance Criteria