Rename packages for consistency #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/rename-package
branch
from
347a490 to
cee31b4
Compare
gpolaert
suggested changes
Jun 28, 2017
dd-java-agent/pom.xml
Outdated
| @@ -60,7 +60,7 @@ | |||
| <version>0.9.11</version> | |||
| </dependency> | |||
|
|
|||
| <!-- Server side instrumentation --> | |||
| <!-- Server sintegrationtion --> | |||
There was a problem hiding this comment.
Maybe something went wrong here
| package io.opentracing.contrib.agent; | ||
| package com.datadoghq.trace.agent; | ||
|
|
||
| import com.datadog.trace.Trace; |
|
|
||
| import com.datadoghq.trace.resolver.AgentTracerConfig; | ||
| import com.datadog.trace.Trace; |
| @@ -1,4 +1,4 @@ | |||
| package io.opentracing.contrib.agent; | |||
| package com.datadog.trace; | |||
Fix package names. Revert oddness in pom file.
|
Changes submitted. Please re-review. |
|
Was all good to me! |
This was referenced Jan 27, 2025
Draft
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of package renaming. Basically we decided to move everything back into a
com.datadoghqpackage namespace until we are ready to contribute.Might be good for @LotharSee or @palazzem to take a look too.