-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] improve setup of dev env on Windows #8180
Draft
lucaspimentel
wants to merge
10
commits into
master
Choose a base branch
from
lpimentel/improve-windows-devex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+353
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 10, 2025 23:43
edab42a
to
49b945c
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038493
Total [baseline] (10.545 s) : 0, 10545016
Agent [candidate] (1.044 s) : 0, 1044415
Total [candidate] (10.61 s) : 0, 10609754
section appsec
Agent [baseline] (1.18 s) : 0, 1179873
Total [baseline] (10.768 s) : 0, 10768362
Agent [candidate] (1.181 s) : 0, 1181154
Total [candidate] (10.804 s) : 0, 10804406
section iast
Agent [baseline] (1.167 s) : 0, 1166993
Total [baseline] (10.965 s) : 0, 10964784
Agent [candidate] (1.166 s) : 0, 1166013
Total [candidate] (11.045 s) : 0, 11045312
section profiling
Agent [baseline] (1.264 s) : 0, 1263680
Total [baseline] (10.872 s) : 0, 10871827
Agent [candidate] (1.257 s) : 0, 1256854
Total [candidate] (10.866 s) : 0, 10865697
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.713 ms) : 0, 715713
BytebuddyAgent [candidate] (719.666 ms) : 0, 719666
GlobalTracer [baseline] (238.989 ms) : 0, 238989
GlobalTracer [candidate] (240.836 ms) : 0, 240836
AppSec [baseline] (55.346 ms) : 0, 55346
AppSec [candidate] (55.829 ms) : 0, 55829
Remote Config [baseline] (709.163 µs) : 0, 709
Remote Config [candidate] (725.974 µs) : 0, 726
Telemetry [baseline] (12.779 ms) : 0, 12779
Telemetry [candidate] (12.286 ms) : 0, 12286
section appsec
BytebuddyAgent [baseline] (732.816 ms) : 0, 732816
BytebuddyAgent [candidate] (733.372 ms) : 0, 733372
GlobalTracer [baseline] (236.739 ms) : 0, 236739
GlobalTracer [candidate] (237.054 ms) : 0, 237054
AppSec [baseline] (175.559 ms) : 0, 175559
AppSec [candidate] (177.181 ms) : 0, 177181
Remote Config [baseline] (663.22 µs) : 0, 663
Remote Config [candidate] (659.105 µs) : 0, 659
Telemetry [baseline] (9.353 ms) : 0, 9353
Telemetry [candidate] (8.24 ms) : 0, 8240
IAST [baseline] (19.495 ms) : 0, 19495
IAST [candidate] (19.209 ms) : 0, 19209
section iast
BytebuddyAgent [baseline] (833.603 ms) : 0, 833603
BytebuddyAgent [candidate] (832.288 ms) : 0, 832288
GlobalTracer [baseline] (229.94 ms) : 0, 229940
GlobalTracer [candidate] (229.39 ms) : 0, 229390
AppSec [baseline] (57.893 ms) : 0, 57893
AppSec [candidate] (58.391 ms) : 0, 58391
Remote Config [baseline] (643.242 µs) : 0, 643
Remote Config [candidate] (657.274 µs) : 0, 657
Telemetry [baseline] (8.58 ms) : 0, 8580
Telemetry [candidate] (8.769 ms) : 0, 8769
IAST [baseline] (21.235 ms) : 0, 21235
IAST [candidate] (21.524 ms) : 0, 21524
section profiling
ProfilingAgent [baseline] (96.348 ms) : 0, 96348
ProfilingAgent [candidate] (95.899 ms) : 0, 95899
BytebuddyAgent [baseline] (709.678 ms) : 0, 709678
BytebuddyAgent [candidate] (705.378 ms) : 0, 705378
GlobalTracer [baseline] (350.642 ms) : 0, 350642
GlobalTracer [candidate] (349.878 ms) : 0, 349878
AppSec [baseline] (55.241 ms) : 0, 55241
AppSec [candidate] (54.07 ms) : 0, 54070
Remote Config [baseline] (714.163 µs) : 0, 714
Remote Config [candidate] (717.209 µs) : 0, 717
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (8.862 ms) : 0, 8862
Profiling [baseline] (96.371 ms) : 0, 96371
Profiling [candidate] (95.923 ms) : 0, 95923
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039193
Total [baseline] (8.64 s) : 0, 8639547
Agent [candidate] (1.036 s) : 0, 1035703
Total [candidate] (8.632 s) : 0, 8632213
section iast
Agent [baseline] (1.171 s) : 0, 1171090
Total [baseline] (9.208 s) : 0, 9207643
Agent [candidate] (1.168 s) : 0, 1167887
Total [candidate] (9.215 s) : 0, 9214973
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1165728
Total [baseline] (9.201 s) : 0, 9200797
Agent [candidate] (1.166 s) : 0, 1165887
Total [candidate] (9.159 s) : 0, 9158797
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169287
Total [baseline] (9.278 s) : 0, 9278055
Agent [candidate] (1.166 s) : 0, 1165894
Total [candidate] (9.268 s) : 0, 9267664
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.075 ms) : 0, 715075
BytebuddyAgent [candidate] (712.9 ms) : 0, 712900
GlobalTracer [baseline] (239.366 ms) : 0, 239366
GlobalTracer [candidate] (238.896 ms) : 0, 238896
AppSec [baseline] (55.487 ms) : 0, 55487
AppSec [candidate] (55.322 ms) : 0, 55322
Remote Config [baseline] (710.447 µs) : 0, 710
Remote Config [candidate] (712.469 µs) : 0, 712
Telemetry [baseline] (13.593 ms) : 0, 13593
Telemetry [candidate] (12.825 ms) : 0, 12825
section iast
BytebuddyAgent [baseline] (837.216 ms) : 0, 837216
BytebuddyAgent [candidate] (833.898 ms) : 0, 833898
GlobalTracer [baseline] (229.64 ms) : 0, 229640
GlobalTracer [candidate] (229.998 ms) : 0, 229998
AppSec [baseline] (58.359 ms) : 0, 58359
AppSec [candidate] (58.155 ms) : 0, 58155
IAST [baseline] (21.437 ms) : 0, 21437
IAST [candidate] (21.397 ms) : 0, 21397
Remote Config [baseline] (642.257 µs) : 0, 642
Remote Config [candidate] (651.671 µs) : 0, 652
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.726 ms) : 0, 8726
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.603 ms) : 0, 832603
BytebuddyAgent [candidate] (831.986 ms) : 0, 831986
GlobalTracer [baseline] (229.222 ms) : 0, 229222
GlobalTracer [candidate] (229.535 ms) : 0, 229535
AppSec [baseline] (58.196 ms) : 0, 58196
AppSec [candidate] (58.688 ms) : 0, 58688
IAST [baseline] (21.26 ms) : 0, 21260
IAST [candidate] (21.219 ms) : 0, 21219
Remote Config [baseline] (656.918 µs) : 0, 657
Remote Config [candidate] (649.216 µs) : 0, 649
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.779 ms) : 0, 8779
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.499 ms) : 0, 835499
BytebuddyAgent [candidate] (831.863 ms) : 0, 831863
GlobalTracer [baseline] (230.673 ms) : 0, 230673
GlobalTracer [candidate] (230.81 ms) : 0, 230810
AppSec [baseline] (57.931 ms) : 0, 57931
AppSec [candidate] (57.772 ms) : 0, 57772
IAST [baseline] (20.887 ms) : 0, 20887
IAST [candidate] (21.05 ms) : 0, 21050
Remote Config [baseline] (640.145 µs) : 0, 640
Remote Config [candidate] (643.18 µs) : 0, 643
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.619 ms) : 0, 8619
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.733 ms) : 1711, 1756
. : milestone, 1733,
appsec_no_iast (1.748 ms) : 1725, 1770
. : milestone, 1748,
iast (1.503 ms) : 1479, 1527
. : milestone, 1503,
profiling (1.531 ms) : 1505, 1556
. : milestone, 1531,
tracing (1.5 ms) : 1476, 1524
. : milestone, 1500,
section candidate
no_agent (1.36 ms) : 1340, 1379
. : milestone, 1360,
appsec (1.74 ms) : 1716, 1763
. : milestone, 1740,
appsec_no_iast (1.751 ms) : 1726, 1775
. : milestone, 1751,
iast (1.513 ms) : 1489, 1537
. : milestone, 1513,
profiling (1.5 ms) : 1476, 1524
. : milestone, 1500,
tracing (1.495 ms) : 1471, 1519
. : milestone, 1495,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section baseline
no_agent (374.62 µs) : 354, 395
. : milestone, 375,
iast (499.616 µs) : 477, 523
. : milestone, 500,
iast_FULL (744.493 µs) : 722, 767
. : milestone, 744,
iast_GLOBAL (546.924 µs) : 524, 570
. : milestone, 547,
iast_HARDCODED_SECRET_DISABLED (508.058 µs) : 485, 532
. : milestone, 508,
iast_INACTIVE (453.676 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (486.48 µs) : 464, 509
. : milestone, 486,
tracing (453.274 µs) : 431, 476
. : milestone, 453,
section candidate
no_agent (376.205 µs) : 356, 396
. : milestone, 376,
iast (506.755 µs) : 483, 530
. : milestone, 507,
iast_FULL (747.943 µs) : 726, 770
. : milestone, 748,
iast_GLOBAL (542.965 µs) : 522, 564
. : milestone, 543,
iast_HARDCODED_SECRET_DISABLED (499.008 µs) : 476, 522
. : milestone, 499,
iast_INACTIVE (452.206 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (490.973 µs) : 468, 514
. : milestone, 491,
tracing (448.167 µs) : 427, 469
. : milestone, 448,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.368 ms) : 2325, 2411
. : milestone, 2368,
iast (2.115 ms) : 2060, 2170
. : milestone, 2115,
iast_GLOBAL (2.162 ms) : 2108, 2217
. : milestone, 2162,
profiling (2.489 ms) : 2299, 2679
. : milestone, 2489,
tracing (1.958 ms) : 1917, 2000
. : milestone, 1958,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.362 ms) : 2319, 2404
. : milestone, 2362,
iast (2.112 ms) : 2058, 2166
. : milestone, 2112,
iast_GLOBAL (2.16 ms) : 2105, 2215
. : milestone, 2160,
profiling (1.998 ms) : 1953, 2042
. : milestone, 1998,
tracing (1.962 ms) : 1920, 2004
. : milestone, 1962,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~cf26bab041, baseline=1.46.0-SNAPSHOT~5bd6139a62
dateFormat X
axisFormat %s
section baseline
no_agent (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
appsec (14.882 s) : 14882000, 14882000
. : milestone, 14882000,
iast (18.561 s) : 18561000, 18561000
. : milestone, 18561000,
iast_GLOBAL (18.144 s) : 18144000, 18144000
. : milestone, 18144000,
profiling (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
section candidate
no_agent (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
appsec (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
iast (19.052 s) : 19052000, 19052000
. : milestone, 19052000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
tracing (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
|
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
3 times, most recently
from
January 14, 2025 22:16
ba49891
to
81367a6
Compare
lucaspimentel
changed the title
[docs] improve windows devex
[docs] improve devex on Windows
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
changed the title
[docs] improve devex on Windows
[docs] improve setup of dev env on Windows
Jan 17, 2025
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 25, 2025 00:00
7d6b4ed
to
cf26bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Try to improve the steps to set up the
dd-trace-java
development environment on Windows:setup.ps1
for quick check (same assetup.sh
)tooling/install-jdks-windows.ps1
to install required SDKs and environment variablesBUILDING.md
Motivation
I am working with
dd-trace-java
for the first time, and I have a Windows laptop, so I'm trying to cover some of the onboarding gaps for the next engineer 😅Additional Notes
These changes only cover docs and scripts to set up dev env on Windows. No code changes to the library itself. (i.e. tests required)
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]