-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] initial implementation and unit tests for inject/extract #8330
Draft
mhlidd
wants to merge
2
commits into
master
Choose a base branch
from
mhlidd/otel_baggage_extract/inject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+426
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhlidd
changed the title
initial implementation and unit tests for inject/extract
[WIP] initial implementation and unit tests for inject/extract
Feb 3, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039520
Total [baseline] (10.464 s) : 0, 10463984
Agent [candidate] (1.047 s) : 0, 1046578
Total [candidate] (10.506 s) : 0, 10505608
section appsec
Agent [baseline] (1.182 s) : 0, 1182040
Total [baseline] (10.734 s) : 0, 10733897
Agent [candidate] (1.184 s) : 0, 1184425
Total [candidate] (10.759 s) : 0, 10759237
section iast
Agent [baseline] (1.179 s) : 0, 1179301
Total [baseline] (10.962 s) : 0, 10962123
Agent [candidate] (1.179 s) : 0, 1179404
Total [candidate] (11.031 s) : 0, 11030829
section profiling
Agent [baseline] (1.261 s) : 0, 1260975
Total [baseline] (10.832 s) : 0, 10832264
Agent [candidate] (1.26 s) : 0, 1259572
Total [candidate] (10.864 s) : 0, 10864106
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.05 ms) : 0, 714050
BytebuddyAgent [candidate] (718.855 ms) : 0, 718855
GlobalTracer [baseline] (242.384 ms) : 0, 242384
GlobalTracer [candidate] (242.408 ms) : 0, 242408
AppSec [baseline] (55.086 ms) : 0, 55086
AppSec [candidate] (55.533 ms) : 0, 55533
Remote Config [baseline] (707.887 µs) : 0, 708
Remote Config [candidate] (723.314 µs) : 0, 723
Telemetry [baseline] (12.113 ms) : 0, 12113
Telemetry [candidate] (13.771 ms) : 0, 13771
section appsec
BytebuddyAgent [baseline] (730.916 ms) : 0, 730916
BytebuddyAgent [candidate] (734.628 ms) : 0, 734628
GlobalTracer [baseline] (239.993 ms) : 0, 239993
GlobalTracer [candidate] (238.782 ms) : 0, 238782
AppSec [baseline] (176.202 ms) : 0, 176202
AppSec [candidate] (175.873 ms) : 0, 175873
Remote Config [baseline] (650.713 µs) : 0, 651
Remote Config [candidate] (666.452 µs) : 0, 666
Telemetry [baseline] (8.299 ms) : 0, 8299
Telemetry [candidate] (8.317 ms) : 0, 8317
IAST [baseline] (21.551 ms) : 0, 21551
IAST [candidate] (21.793 ms) : 0, 21793
section iast
BytebuddyAgent [baseline] (839.101 ms) : 0, 839101
BytebuddyAgent [candidate] (841.032 ms) : 0, 841032
GlobalTracer [baseline] (234.652 ms) : 0, 234652
GlobalTracer [candidate] (233.937 ms) : 0, 233937
AppSec [baseline] (55.26 ms) : 0, 55260
AppSec [candidate] (54.661 ms) : 0, 54661
Remote Config [baseline] (637.136 µs) : 0, 637
Remote Config [candidate] (612.25 µs) : 0, 612
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (8.713 ms) : 0, 8713
IAST [baseline] (25.192 ms) : 0, 25192
IAST [candidate] (25.019 ms) : 0, 25019
section profiling
ProfilingAgent [baseline] (95.596 ms) : 0, 95596
ProfilingAgent [candidate] (95.477 ms) : 0, 95477
BytebuddyAgent [baseline] (705.264 ms) : 0, 705264
BytebuddyAgent [candidate] (705.877 ms) : 0, 705877
GlobalTracer [baseline] (353.326 ms) : 0, 353326
GlobalTracer [candidate] (352.254 ms) : 0, 352254
AppSec [baseline] (55.01 ms) : 0, 55010
AppSec [candidate] (54.206 ms) : 0, 54206
Remote Config [baseline] (709.008 µs) : 0, 709
Remote Config [candidate] (665.318 µs) : 0, 665
Telemetry [baseline] (8.872 ms) : 0, 8872
Telemetry [candidate] (8.916 ms) : 0, 8916
Profiling [baseline] (95.62 ms) : 0, 95620
Profiling [candidate] (95.501 ms) : 0, 95501
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052173
Total [baseline] (8.659 s) : 0, 8658566
Agent [candidate] (1.039 s) : 0, 1039240
Total [candidate] (8.599 s) : 0, 8599167
section iast
Agent [baseline] (1.17 s) : 0, 1170224
Total [baseline] (9.192 s) : 0, 9192218
Agent [candidate] (1.17 s) : 0, 1169513
Total [candidate] (9.219 s) : 0, 9219190
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170949
Total [baseline] (9.172 s) : 0, 9172095
Agent [candidate] (1.17 s) : 0, 1169639
Total [candidate] (9.173 s) : 0, 9173448
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180252
Total [baseline] (9.238 s) : 0, 9238097
Agent [candidate] (1.175 s) : 0, 1175358
Total [candidate] (9.184 s) : 0, 9183727
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.231 ms) : 0, 724231
BytebuddyAgent [candidate] (714.193 ms) : 0, 714193
GlobalTracer [baseline] (243.146 ms) : 0, 243146
GlobalTracer [candidate] (240.644 ms) : 0, 240644
AppSec [baseline] (55.744 ms) : 0, 55744
AppSec [candidate] (55.504 ms) : 0, 55504
Remote Config [baseline] (712.909 µs) : 0, 713
Remote Config [candidate] (726.141 µs) : 0, 726
Telemetry [baseline] (12.97 ms) : 0, 12970
Telemetry [candidate] (12.847 ms) : 0, 12847
section iast
BytebuddyAgent [baseline] (832.782 ms) : 0, 832782
BytebuddyAgent [candidate] (833.807 ms) : 0, 833807
GlobalTracer [baseline] (233.614 ms) : 0, 233614
GlobalTracer [candidate] (231.879 ms) : 0, 231879
AppSec [baseline] (54.484 ms) : 0, 54484
AppSec [candidate] (56.821 ms) : 0, 56821
Remote Config [baseline] (614.199 µs) : 0, 614
Remote Config [candidate] (608.504 µs) : 0, 609
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.663 ms) : 0, 8663
IAST [baseline] (24.816 ms) : 0, 24816
IAST [candidate] (22.436 ms) : 0, 22436
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.281 ms) : 0, 833281
BytebuddyAgent [candidate] (833.696 ms) : 0, 833696
GlobalTracer [baseline] (233.49 ms) : 0, 233490
GlobalTracer [candidate] (231.586 ms) : 0, 231586
AppSec [baseline] (54.841 ms) : 0, 54841
AppSec [candidate] (55.484 ms) : 0, 55484
Remote Config [baseline] (612.7 µs) : 0, 613
Remote Config [candidate] (610.563 µs) : 0, 611
Telemetry [baseline] (8.639 ms) : 0, 8639
Telemetry [candidate] (8.751 ms) : 0, 8751
IAST [baseline] (24.866 ms) : 0, 24866
IAST [candidate] (24.146 ms) : 0, 24146
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.416 ms) : 0, 837416
BytebuddyAgent [candidate] (838.384 ms) : 0, 838384
GlobalTracer [baseline] (237.274 ms) : 0, 237274
GlobalTracer [candidate] (232.731 ms) : 0, 232731
AppSec [baseline] (55.683 ms) : 0, 55683
AppSec [candidate] (53.971 ms) : 0, 53971
Remote Config [baseline] (641.643 µs) : 0, 642
Remote Config [candidate] (613.049 µs) : 0, 613
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.758 ms) : 0, 8758
IAST [baseline] (25.152 ms) : 0, 25152
IAST [candidate] (25.491 ms) : 0, 25491
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section baseline
no_agent (389.218 µs) : 369, 409
. : milestone, 389,
iast (519.97 µs) : 498, 542
. : milestone, 520,
iast_FULL (755.774 µs) : 734, 778
. : milestone, 756,
iast_GLOBAL (573.991 µs) : 550, 598
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (517.864 µs) : 496, 540
. : milestone, 518,
iast_INACTIVE (466.74 µs) : 445, 488
. : milestone, 467,
iast_TELEMETRY_OFF (513.637 µs) : 490, 537
. : milestone, 514,
tracing (468.817 µs) : 445, 493
. : milestone, 469,
section candidate
no_agent (381.876 µs) : 362, 401
. : milestone, 382,
iast (517.261 µs) : 496, 539
. : milestone, 517,
iast_FULL (759.064 µs) : 737, 781
. : milestone, 759,
iast_GLOBAL (561.111 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (517.577 µs) : 495, 540
. : milestone, 518,
iast_INACTIVE (465.942 µs) : 445, 487
. : milestone, 466,
iast_TELEMETRY_OFF (503.367 µs) : 481, 526
. : milestone, 503,
tracing (465.954 µs) : 444, 488
. : milestone, 466,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1376
. : milestone, 1355,
appsec (1.766 ms) : 1742, 1790
. : milestone, 1766,
appsec_no_iast (1.759 ms) : 1733, 1785
. : milestone, 1759,
iast (1.516 ms) : 1493, 1540
. : milestone, 1516,
profiling (1.513 ms) : 1489, 1537
. : milestone, 1513,
tracing (1.506 ms) : 1481, 1530
. : milestone, 1506,
section candidate
no_agent (1.358 ms) : 1338, 1379
. : milestone, 1358,
appsec (1.778 ms) : 1753, 1802
. : milestone, 1778,
appsec_no_iast (1.772 ms) : 1749, 1796
. : milestone, 1772,
iast (1.527 ms) : 1502, 1551
. : milestone, 1527,
profiling (1.527 ms) : 1504, 1549
. : milestone, 1527,
tracing (1.5 ms) : 1475, 1524
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.349 ms) : 2306, 2392
. : milestone, 2349,
iast (2.103 ms) : 2048, 2158
. : milestone, 2103,
iast_GLOBAL (2.158 ms) : 2102, 2214
. : milestone, 2158,
profiling (1.976 ms) : 1931, 2021
. : milestone, 1976,
tracing (1.95 ms) : 1907, 1992
. : milestone, 1950,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.376 ms) : 2332, 2419
. : milestone, 2376,
iast (2.106 ms) : 2051, 2161
. : milestone, 2106,
iast_GLOBAL (2.144 ms) : 2089, 2200
. : milestone, 2144,
profiling (1.975 ms) : 1931, 2018
. : milestone, 1975,
tracing (1.946 ms) : 1904, 1989
. : milestone, 1946,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~22bc0098de, baseline=1.47.0-SNAPSHOT~28acd37546
dateFormat X
axisFormat %s
section baseline
no_agent (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
appsec (14.669 s) : 14669000, 14669000
. : milestone, 14669000,
iast (18.713 s) : 18713000, 18713000
. : milestone, 18713000,
iast_GLOBAL (17.629 s) : 17629000, 17629000
. : milestone, 17629000,
profiling (15.629 s) : 15629000, 15629000
. : milestone, 15629000,
tracing (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
section candidate
no_agent (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
appsec (15.214 s) : 15214000, 15214000
. : milestone, 15214000,
iast (18.887 s) : 18887000, 18887000
. : milestone, 18887000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
. : milestone, 17930000,
profiling (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
tracing (15.215 s) : 15215000, 15215000
. : milestone, 15215000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]