-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert test run status in CI Vis instrumentation tests #8316
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/assert-test-run-status
Jan 31, 2025
Merged
Assert test run status in CI Vis instrumentation tests #8316
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/assert-test-run-status
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
comp: ci visibility
Continuous Integration Visibility
labels
Jan 30, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051970
Total [baseline] (10.534 s) : 0, 10533911
Agent [candidate] (1.041 s) : 0, 1041004
Total [candidate] (10.525 s) : 0, 10525107
section appsec
Agent [baseline] (1.187 s) : 0, 1186839
Total [baseline] (10.753 s) : 0, 10752764
Agent [candidate] (1.185 s) : 0, 1184621
Total [candidate] (10.854 s) : 0, 10853753
section iast
Agent [baseline] (1.184 s) : 0, 1183934
Total [baseline] (11.024 s) : 0, 11023738
Agent [candidate] (1.17 s) : 0, 1169502
Total [candidate] (10.936 s) : 0, 10936247
section profiling
Agent [baseline] (1.265 s) : 0, 1264633
Total [baseline] (10.863 s) : 0, 10863310
Agent [candidate] (1.258 s) : 0, 1258197
Total [candidate] (10.848 s) : 0, 10848434
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.639 ms) : 0, 724639
BytebuddyAgent [candidate] (715.996 ms) : 0, 715996
GlobalTracer [baseline] (243.409 ms) : 0, 243409
GlobalTracer [candidate] (240.195 ms) : 0, 240195
AppSec [baseline] (56.108 ms) : 0, 56108
AppSec [candidate] (55.211 ms) : 0, 55211
Remote Config [baseline] (727.932 µs) : 0, 728
Remote Config [candidate] (707.768 µs) : 0, 708
Telemetry [baseline] (11.689 ms) : 0, 11689
Telemetry [candidate] (13.602 ms) : 0, 13602
section appsec
BytebuddyAgent [baseline] (735.357 ms) : 0, 735357
BytebuddyAgent [candidate] (735.259 ms) : 0, 735259
GlobalTracer [baseline] (239.039 ms) : 0, 239039
GlobalTracer [candidate] (238.28 ms) : 0, 238280
AppSec [baseline] (177.124 ms) : 0, 177124
AppSec [candidate] (175.538 ms) : 0, 175538
Remote Config [baseline] (665.175 µs) : 0, 665
Remote Config [candidate] (655.035 µs) : 0, 655
Telemetry [baseline] (8.357 ms) : 0, 8357
Telemetry [candidate] (8.67 ms) : 0, 8670
IAST [baseline] (21.921 ms) : 0, 21921
IAST [candidate] (21.739 ms) : 0, 21739
section iast
BytebuddyAgent [baseline] (843.984 ms) : 0, 843984
BytebuddyAgent [candidate] (834.28 ms) : 0, 834280
GlobalTracer [baseline] (234.602 ms) : 0, 234602
GlobalTracer [candidate] (231.332 ms) : 0, 231332
AppSec [baseline] (53.602 ms) : 0, 53602
AppSec [candidate] (54.375 ms) : 0, 54375
Remote Config [baseline] (618.4 µs) : 0, 618
Remote Config [candidate] (616.125 µs) : 0, 616
Telemetry [baseline] (8.793 ms) : 0, 8793
Telemetry [candidate] (8.712 ms) : 0, 8712
IAST [baseline] (26.689 ms) : 0, 26689
IAST [candidate] (24.874 ms) : 0, 24874
section profiling
ProfilingAgent [baseline] (95.13 ms) : 0, 95130
ProfilingAgent [candidate] (95.23 ms) : 0, 95230
BytebuddyAgent [baseline] (709.873 ms) : 0, 709873
BytebuddyAgent [candidate] (705.863 ms) : 0, 705863
GlobalTracer [baseline] (352.384 ms) : 0, 352384
GlobalTracer [candidate] (351.33 ms) : 0, 351330
AppSec [baseline] (55.037 ms) : 0, 55037
AppSec [candidate] (53.879 ms) : 0, 53879
Remote Config [baseline] (704.912 µs) : 0, 705
Remote Config [candidate] (692.437 µs) : 0, 692
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.87 ms) : 0, 8870
Profiling [baseline] (95.154 ms) : 0, 95154
Profiling [candidate] (95.254 ms) : 0, 95254
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038237
Total [baseline] (8.665 s) : 0, 8664700
Agent [candidate] (1.045 s) : 0, 1044657
Total [candidate] (8.671 s) : 0, 8670758
section iast
Agent [baseline] (1.175 s) : 0, 1174642
Total [baseline] (9.243 s) : 0, 9242534
Agent [candidate] (1.17 s) : 0, 1169805
Total [candidate] (9.218 s) : 0, 9217951
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178541
Total [baseline] (9.228 s) : 0, 9227578
Agent [candidate] (1.171 s) : 0, 1170681
Total [candidate] (9.287 s) : 0, 9286971
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168159
Total [baseline] (9.223 s) : 0, 9222949
Agent [candidate] (1.171 s) : 0, 1171035
Total [candidate] (9.246 s) : 0, 9245562
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.988 ms) : 0, 714988
BytebuddyAgent [candidate] (718.328 ms) : 0, 718328
GlobalTracer [baseline] (240.348 ms) : 0, 240348
GlobalTracer [candidate] (240.91 ms) : 0, 240910
AppSec [baseline] (55.568 ms) : 0, 55568
AppSec [candidate] (56.342 ms) : 0, 56342
Remote Config [baseline] (719.541 µs) : 0, 720
Remote Config [candidate] (720.164 µs) : 0, 720
Telemetry [baseline] (11.381 ms) : 0, 11381
Telemetry [candidate] (13.09 ms) : 0, 13090
section iast
BytebuddyAgent [baseline] (839.476 ms) : 0, 839476
BytebuddyAgent [candidate] (834.643 ms) : 0, 834643
GlobalTracer [baseline] (231.157 ms) : 0, 231157
GlobalTracer [candidate] (230.805 ms) : 0, 230805
IAST [baseline] (26.349 ms) : 0, 26349
IAST [candidate] (24.2 ms) : 0, 24200
AppSec [baseline] (52.968 ms) : 0, 52968
AppSec [candidate] (55.6 ms) : 0, 55600
Remote Config [baseline] (608.634 µs) : 0, 609
Remote Config [candidate] (607.83 µs) : 0, 608
Telemetry [baseline] (8.649 ms) : 0, 8649
Telemetry [candidate] (8.643 ms) : 0, 8643
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.014 ms) : 0, 840014
BytebuddyAgent [candidate] (834.829 ms) : 0, 834829
GlobalTracer [baseline] (232.652 ms) : 0, 232652
GlobalTracer [candidate] (230.998 ms) : 0, 230998
IAST [baseline] (24.513 ms) : 0, 24513
IAST [candidate] (26.736 ms) : 0, 26736
AppSec [baseline] (56.452 ms) : 0, 56452
AppSec [candidate] (53.352 ms) : 0, 53352
Remote Config [baseline] (628.467 µs) : 0, 628
Remote Config [candidate] (621.154 µs) : 0, 621
Telemetry [baseline] (8.875 ms) : 0, 8875
Telemetry [candidate] (8.872 ms) : 0, 8872
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.997 ms) : 0, 832997
BytebuddyAgent [candidate] (835.349 ms) : 0, 835349
GlobalTracer [baseline] (231.545 ms) : 0, 231545
GlobalTracer [candidate] (231.919 ms) : 0, 231919
IAST [baseline] (25.951 ms) : 0, 25951
IAST [candidate] (26.077 ms) : 0, 26077
AppSec [baseline] (53.087 ms) : 0, 53087
AppSec [candidate] (53.117 ms) : 0, 53117
Remote Config [baseline] (616.667 µs) : 0, 617
Remote Config [candidate] (632.97 µs) : 0, 633
Telemetry [baseline] (8.591 ms) : 0, 8591
Telemetry [candidate] (8.591 ms) : 0, 8591
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
. : milestone, 1359,
appsec (1.713 ms) : 1690, 1736
. : milestone, 1713,
appsec_no_iast (1.733 ms) : 1708, 1758
. : milestone, 1733,
iast (1.518 ms) : 1494, 1543
. : milestone, 1518,
profiling (1.557 ms) : 1532, 1582
. : milestone, 1557,
tracing (1.475 ms) : 1449, 1500
. : milestone, 1475,
section candidate
no_agent (1.363 ms) : 1343, 1383
. : milestone, 1363,
appsec (1.754 ms) : 1730, 1777
. : milestone, 1754,
appsec_no_iast (1.774 ms) : 1749, 1799
. : milestone, 1774,
iast (1.496 ms) : 1472, 1520
. : milestone, 1496,
profiling (1.52 ms) : 1495, 1544
. : milestone, 1520,
tracing (1.498 ms) : 1473, 1522
. : milestone, 1498,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section baseline
no_agent (391.217 µs) : 371, 411
. : milestone, 391,
iast (503.558 µs) : 480, 527
. : milestone, 504,
iast_FULL (740.615 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (550.85 µs) : 529, 573
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (503.625 µs) : 482, 526
. : milestone, 504,
iast_INACTIVE (455.381 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (488.198 µs) : 466, 510
. : milestone, 488,
tracing (451.496 µs) : 430, 473
. : milestone, 451,
section candidate
no_agent (370.743 µs) : 350, 392
. : milestone, 371,
iast (508.519 µs) : 485, 532
. : milestone, 509,
iast_FULL (738.77 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (561.757 µs) : 537, 587
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (506.566 µs) : 484, 529
. : milestone, 507,
iast_INACTIVE (453.953 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (487.985 µs) : 465, 511
. : milestone, 488,
tracing (451.073 µs) : 430, 472
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.352 ms) : 2310, 2395
. : milestone, 2352,
iast (2.119 ms) : 2065, 2174
. : milestone, 2119,
iast_GLOBAL (2.179 ms) : 2123, 2234
. : milestone, 2179,
profiling (1.976 ms) : 1932, 2019
. : milestone, 1976,
tracing (1.955 ms) : 1913, 1998
. : milestone, 1955,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.372 ms) : 2329, 2416
. : milestone, 2372,
iast (2.12 ms) : 2065, 2175
. : milestone, 2120,
iast_GLOBAL (2.161 ms) : 2106, 2217
. : milestone, 2161,
profiling (2.473 ms) : 2283, 2662
. : milestone, 2473,
tracing (1.961 ms) : 1918, 2003
. : milestone, 1961,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3e8d229110, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
dateFormat X
axisFormat %s
section baseline
no_agent (15.278 s) : 15278000, 15278000
. : milestone, 15278000,
appsec (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
iast (18.21 s) : 18210000, 18210000
. : milestone, 18210000,
iast_GLOBAL (18.162 s) : 18162000, 18162000
. : milestone, 18162000,
profiling (15.193 s) : 15193000, 15193000
. : milestone, 15193000,
tracing (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
section candidate
no_agent (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
appsec (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
iast (18.556 s) : 18556000, 18556000
. : milestone, 18556000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
|
nikita-tkachenko-datadog
requested review from
tonyredondo and
daniel-mohedano
and removed request for
a team and
tonyredondo
January 31, 2025 09:57
daniel-mohedano
approved these changes
Jan 31, 2025
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/assert-test-run-status
branch
January 31, 2025 10:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates CI Visibility instrumentation tests.
Now the tests assert the status of the run: successful or failed.
Motivation
Preparation for tests quarantining feature.
The main point of quarantining is avoiding failing the build if a quarantined test fails, so we will need to assert the status of the run.
Additional Notes
Also fixes a problem in Karate instrumentation: when doing auto-test retries the failure in the last attempt was not propagated to the build result.
Also removes a couple of redundant test cases for TestNG 6 (older TestNG versions do not support test retries).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1483