-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APPSEC_WAF_TELEMETRY to system-tests #8329
Open
Mariovido
wants to merge
1
commit into
master
Choose a base branch
from
mario.vidal/add_new_scenario
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariovido
added
type: enhancement
comp: asm waf
Application Security Management (WAF)
labels
Feb 3, 2025
smola
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
and removed
type: enhancement
labels
Feb 3, 2025
smola
approved these changes
Feb 3, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052253
Total [baseline] (8.697 s) : 0, 8696932
Agent [candidate] (1.041 s) : 0, 1041488
Total [candidate] (8.641 s) : 0, 8640626
section iast
Agent [baseline] (1.181 s) : 0, 1181394
Total [baseline] (9.248 s) : 0, 9248413
Agent [candidate] (1.179 s) : 0, 1178591
Total [candidate] (9.259 s) : 0, 9259340
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172179
Total [baseline] (9.201 s) : 0, 9200580
Agent [candidate] (1.18 s) : 0, 1180002
Total [candidate] (9.215 s) : 0, 9214967
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174699
Total [baseline] (9.263 s) : 0, 9262862
Agent [candidate] (1.182 s) : 0, 1182134
Total [candidate] (9.273 s) : 0, 9273211
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.133 ms) : 0, 721133
BytebuddyAgent [candidate] (715.947 ms) : 0, 715947
GlobalTracer [baseline] (245.04 ms) : 0, 245040
GlobalTracer [candidate] (243.011 ms) : 0, 243011
AppSec [baseline] (55.633 ms) : 0, 55633
AppSec [candidate] (55.024 ms) : 0, 55024
Remote Config [baseline] (730.215 µs) : 0, 730
Remote Config [candidate] (712.297 µs) : 0, 712
Telemetry [baseline] (14.427 ms) : 0, 14427
Telemetry [candidate] (11.485 ms) : 0, 11485
section iast
BytebuddyAgent [baseline] (841.038 ms) : 0, 841038
BytebuddyAgent [candidate] (839.048 ms) : 0, 839048
GlobalTracer [baseline] (235.06 ms) : 0, 235060
GlobalTracer [candidate] (235.21 ms) : 0, 235210
IAST [baseline] (23.647 ms) : 0, 23647
IAST [candidate] (25.633 ms) : 0, 25633
AppSec [baseline] (56.752 ms) : 0, 56752
AppSec [candidate] (53.842 ms) : 0, 53842
Remote Config [baseline] (629.908 µs) : 0, 630
Remote Config [candidate] (621.899 µs) : 0, 622
Telemetry [baseline] (8.804 ms) : 0, 8804
Telemetry [candidate] (8.817 ms) : 0, 8817
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.107 ms) : 0, 834107
BytebuddyAgent [candidate] (838.921 ms) : 0, 838921
GlobalTracer [baseline] (234.011 ms) : 0, 234011
GlobalTracer [candidate] (235.76 ms) : 0, 235760
IAST [baseline] (25.639 ms) : 0, 25639
IAST [candidate] (24.526 ms) : 0, 24526
AppSec [baseline] (53.839 ms) : 0, 53839
AppSec [candidate] (56.012 ms) : 0, 56012
Remote Config [baseline] (610.966 µs) : 0, 611
Remote Config [candidate] (626.068 µs) : 0, 626
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.837 ms) : 0, 8837
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.776 ms) : 0, 835776
BytebuddyAgent [candidate] (841.88 ms) : 0, 841880
GlobalTracer [baseline] (234.773 ms) : 0, 234773
GlobalTracer [candidate] (236.361 ms) : 0, 236361
IAST [baseline] (27.179 ms) : 0, 27179
IAST [candidate] (27.226 ms) : 0, 27226
AppSec [baseline] (52.402 ms) : 0, 52402
AppSec [candidate] (52.06 ms) : 0, 52060
Remote Config [baseline] (611.801 µs) : 0, 612
Remote Config [candidate] (602.203 µs) : 0, 602
Telemetry [baseline] (8.675 ms) : 0, 8675
Telemetry [candidate] (8.537 ms) : 0, 8537
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047063
Total [baseline] (10.411 s) : 0, 10411191
Agent [candidate] (1.047 s) : 0, 1047101
Total [candidate] (10.458 s) : 0, 10457588
section appsec
Agent [baseline] (1.182 s) : 0, 1182233
Total [baseline] (10.77 s) : 0, 10770414
Agent [candidate] (1.19 s) : 0, 1190131
Total [candidate] (10.782 s) : 0, 10782230
section iast
Agent [baseline] (1.17 s) : 0, 1170010
Total [baseline] (10.971 s) : 0, 10971100
Agent [candidate] (1.174 s) : 0, 1174194
Total [candidate] (11.021 s) : 0, 11020886
section profiling
Agent [baseline] (1.263 s) : 0, 1262951
Total [baseline] (10.84 s) : 0, 10840325
Agent [candidate] (1.268 s) : 0, 1268375
Total [candidate] (10.899 s) : 0, 10899325
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.19 ms) : 0, 719190
BytebuddyAgent [candidate] (719.823 ms) : 0, 719823
GlobalTracer [baseline] (244.21 ms) : 0, 244210
GlobalTracer [candidate] (244.23 ms) : 0, 244230
AppSec [baseline] (55.449 ms) : 0, 55449
AppSec [candidate] (56.138 ms) : 0, 56138
Remote Config [baseline] (719.14 µs) : 0, 719
Remote Config [candidate] (719.115 µs) : 0, 719
Telemetry [baseline] (12.158 ms) : 0, 12158
Telemetry [candidate] (10.825 ms) : 0, 10825
section appsec
BytebuddyAgent [baseline] (731.515 ms) : 0, 731515
BytebuddyAgent [candidate] (737.655 ms) : 0, 737655
GlobalTracer [baseline] (240.275 ms) : 0, 240275
GlobalTracer [candidate] (241.811 ms) : 0, 241811
IAST [baseline] (21.459 ms) : 0, 21459
IAST [candidate] (21.774 ms) : 0, 21774
AppSec [baseline] (175.533 ms) : 0, 175533
AppSec [candidate] (175.467 ms) : 0, 175467
Remote Config [baseline] (657.049 µs) : 0, 657
Remote Config [candidate] (658.449 µs) : 0, 658
Telemetry [baseline] (8.28 ms) : 0, 8280
Telemetry [candidate] (8.342 ms) : 0, 8342
section iast
BytebuddyAgent [baseline] (831.74 ms) : 0, 831740
BytebuddyAgent [candidate] (835.413 ms) : 0, 835413
GlobalTracer [baseline] (233.67 ms) : 0, 233670
GlobalTracer [candidate] (234.564 ms) : 0, 234564
IAST [baseline] (25.028 ms) : 0, 25028
IAST [candidate] (24.209 ms) : 0, 24209
AppSec [baseline] (54.928 ms) : 0, 54928
AppSec [candidate] (55.427 ms) : 0, 55427
Remote Config [baseline] (632.793 µs) : 0, 633
Remote Config [candidate] (612.084 µs) : 0, 612
Telemetry [baseline] (8.728 ms) : 0, 8728
Telemetry [candidate] (8.62 ms) : 0, 8620
section profiling
BytebuddyAgent [baseline] (706.593 ms) : 0, 706593
BytebuddyAgent [candidate] (711.721 ms) : 0, 711721
GlobalTracer [baseline] (353.927 ms) : 0, 353927
GlobalTracer [candidate] (354.755 ms) : 0, 354755
AppSec [baseline] (55.079 ms) : 0, 55079
AppSec [candidate] (54.288 ms) : 0, 54288
Remote Config [baseline] (690.621 µs) : 0, 691
Remote Config [candidate] (705.319 µs) : 0, 705
Telemetry [baseline] (8.857 ms) : 0, 8857
Telemetry [candidate] (8.886 ms) : 0, 8886
ProfilingAgent [baseline] (95.56 ms) : 0, 95560
ProfilingAgent [candidate] (95.413 ms) : 0, 95413
Profiling [baseline] (95.585 ms) : 0, 95585
Profiling [candidate] (95.438 ms) : 0, 95438
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.743 ms) : 1718, 1767
. : milestone, 1743,
appsec_no_iast (1.766 ms) : 1742, 1790
. : milestone, 1766,
iast (1.5 ms) : 1476, 1524
. : milestone, 1500,
profiling (1.555 ms) : 1530, 1580
. : milestone, 1555,
tracing (1.482 ms) : 1457, 1506
. : milestone, 1482,
section candidate
no_agent (1.322 ms) : 1303, 1342
. : milestone, 1322,
appsec (1.741 ms) : 1718, 1765
. : milestone, 1741,
appsec_no_iast (1.76 ms) : 1732, 1788
. : milestone, 1760,
iast (1.502 ms) : 1477, 1527
. : milestone, 1502,
profiling (1.55 ms) : 1525, 1575
. : milestone, 1550,
tracing (1.485 ms) : 1459, 1510
. : milestone, 1485,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section baseline
no_agent (378.735 µs) : 359, 398
. : milestone, 379,
iast (506.151 µs) : 484, 528
. : milestone, 506,
iast_FULL (741.24 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (546.628 µs) : 525, 568
. : milestone, 547,
iast_HARDCODED_SECRET_DISABLED (499.566 µs) : 478, 521
. : milestone, 500,
iast_INACTIVE (457.218 µs) : 436, 479
. : milestone, 457,
iast_TELEMETRY_OFF (493.694 µs) : 471, 516
. : milestone, 494,
tracing (457.619 µs) : 436, 480
. : milestone, 458,
section candidate
no_agent (374.088 µs) : 355, 394
. : milestone, 374,
iast (504.108 µs) : 482, 526
. : milestone, 504,
iast_FULL (737.873 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (552.982 µs) : 532, 574
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (507.967 µs) : 485, 531
. : milestone, 508,
iast_INACTIVE (457.907 µs) : 436, 479
. : milestone, 458,
iast_TELEMETRY_OFF (497.945 µs) : 473, 522
. : milestone, 498,
tracing (457.197 µs) : 435, 479
. : milestone, 457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section baseline
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
iast (18.379 s) : 18379000, 18379000
. : milestone, 18379000,
iast_GLOBAL (18.313 s) : 18313000, 18313000
. : milestone, 18313000,
profiling (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
tracing (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
section candidate
no_agent (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
appsec (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
iast (19.015 s) : 19015000, 19015000
. : milestone, 19015000,
iast_GLOBAL (18.34 s) : 18340000, 18340000
. : milestone, 18340000,
profiling (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
tracing (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4103ced691, baseline=1.47.0-SNAPSHOT~5d18c24208
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
. : milestone, 1468,
appsec (2.361 ms) : 2317, 2404
. : milestone, 2361,
iast (2.107 ms) : 2052, 2161
. : milestone, 2107,
iast_GLOBAL (2.145 ms) : 2091, 2200
. : milestone, 2145,
profiling (1.952 ms) : 1909, 1995
. : milestone, 1952,
tracing (1.941 ms) : 1899, 1983
. : milestone, 1941,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.35 ms) : 2307, 2394
. : milestone, 2350,
iast (2.11 ms) : 2055, 2165
. : milestone, 2110,
iast_GLOBAL (2.144 ms) : 2089, 2199
. : milestone, 2144,
profiling (2.464 ms) : 2274, 2653
. : milestone, 2464,
tracing (1.939 ms) : 1897, 1981
. : milestone, 1939,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This introduces a new scenario for running WAF telemetry tests within the system-tests.
Motivation
Currently, changes to WAF telemetry do not verify whether the system-tests execute correctly. We aim to prevent misalignment between the system-tests and the tracer.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-56478