Avoid unsupported API call for creating folders on windows #8304

jbachorik · 2025-01-29T16:04:20Z

What Does This Do

The Files.createDirectories(path, attributes) is using PosixFilePermissions to create the file attribute but this is not platform independent (although the FileAttribute looks like it might).

Therefore, we check for the presence of posix support and use the file attributes only if we are on posix.

Motivation

Allow running tracer on Windows again

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: PROF-11242

pr-commenter · 2025-01-29T16:42:52Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/tempfiles_1
git_commit_date	1738161747	1738166222
git_commit_sha	`a41d151`	`36d017f`
release_version	1.46.0-SNAPSHOT~a41d1512de	1.46.0-SNAPSHOT~36d017f9e1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738168643	1738168643
ci_job_id	785768581	785768581
ci_pipeline_id	54337387	54337387
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xcwqdre5-project-304-concurrent-0-gl3n7urz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xcwqdre5-project-304-concurrent-0-gl3n7urz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051496
Total [baseline] (8.651 s) : 0, 8650956
Agent [candidate] (1.041 s) : 0, 1040768
Total [candidate] (8.63 s) : 0, 8630178
section iast
Agent [baseline] (1.181 s) : 0, 1180795
Total [baseline] (9.258 s) : 0, 9258284
Agent [candidate] (1.17 s) : 0, 1169936
Total [candidate] (9.242 s) : 0, 9241631
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174334
Total [baseline] (9.238 s) : 0, 9238440
Agent [candidate] (1.179 s) : 0, 1178711
Total [candidate] (9.206 s) : 0, 9206449
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167056
Total [baseline] (9.236 s) : 0, 9235704
Agent [candidate] (1.166 s) : 0, 1165753
Total [candidate] (9.222 s) : 0, 9222392

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	iast	1.181 s	129.299 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	122.838 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.167 s	115.56 ms (11.0%)
Total	tracing	8.651 s	-
Total	iast	9.258 s	607.328 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.238 s	587.484 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.236 s	584.748 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.17 s	129.168 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	137.943 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.166 s	124.986 ms (12.0%)
Total	tracing	8.63 s	-
Total	iast	9.242 s	611.453 ms (7.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.206 s	576.271 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.222 s	592.214 ms (6.9%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.158 ms) : 0, 724158
BytebuddyAgent [candidate] (716.329 ms) : 0, 716329
GlobalTracer [baseline] (242.647 ms) : 0, 242647
GlobalTracer [candidate] (240.426 ms) : 0, 240426
AppSec [baseline] (56.824 ms) : 0, 56824
AppSec [candidate] (56.466 ms) : 0, 56466
Remote Config [baseline] (728.788 µs) : 0, 729
Remote Config [candidate] (722.812 µs) : 0, 723
Telemetry [baseline] (11.659 ms) : 0, 11659
Telemetry [candidate] (11.542 ms) : 0, 11542
section iast
BytebuddyAgent [baseline] (841.772 ms) : 0, 841772
BytebuddyAgent [candidate] (834.086 ms) : 0, 834086
GlobalTracer [baseline] (233.868 ms) : 0, 233868
GlobalTracer [candidate] (231.178 ms) : 0, 231178
IAST [baseline] (27.494 ms) : 0, 27494
IAST [candidate] (24.899 ms) : 0, 24899
AppSec [baseline] (52.576 ms) : 0, 52576
AppSec [candidate] (55.045 ms) : 0, 55045
Remote Config [baseline] (628.457 µs) : 0, 628
Remote Config [candidate] (631.381 µs) : 0, 631
Telemetry [baseline] (8.828 ms) : 0, 8828
Telemetry [candidate] (8.806 ms) : 0, 8806
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.556 ms) : 0, 839556
BytebuddyAgent [candidate] (841.459 ms) : 0, 841459
GlobalTracer [baseline] (230.578 ms) : 0, 230578
GlobalTracer [candidate] (232.535 ms) : 0, 232535
IAST [baseline] (26.344 ms) : 0, 26344
IAST [candidate] (26.588 ms) : 0, 26588
AppSec [baseline] (53.155 ms) : 0, 53155
AppSec [candidate] (53.129 ms) : 0, 53129
Remote Config [baseline] (617.56 µs) : 0, 618
Remote Config [candidate] (635.608 µs) : 0, 636
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (8.772 ms) : 0, 8772
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.045 ms) : 0, 832045
BytebuddyAgent [candidate] (831.117 ms) : 0, 831117
GlobalTracer [baseline] (230.599 ms) : 0, 230599
GlobalTracer [candidate] (230.836 ms) : 0, 230836
IAST [baseline] (26.169 ms) : 0, 26169
IAST [candidate] (24.465 ms) : 0, 24465
AppSec [baseline] (53.568 ms) : 0, 53568
AppSec [candidate] (54.888 ms) : 0, 54888
Remote Config [baseline] (615.7 µs) : 0, 616
Remote Config [candidate] (624.298 µs) : 0, 624
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.538 ms) : 0, 8538

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043901
Total [baseline] (10.624 s) : 0, 10623558
Agent [candidate] (1.039 s) : 0, 1039057
Total [candidate] (10.484 s) : 0, 10484361
section appsec
Agent [baseline] (1.185 s) : 0, 1184709
Total [baseline] (10.796 s) : 0, 10796112
Agent [candidate] (1.182 s) : 0, 1181656
Total [candidate] (10.731 s) : 0, 10731101
section iast
Agent [baseline] (1.172 s) : 0, 1171769
Total [baseline] (10.957 s) : 0, 10957467
Agent [candidate] (1.177 s) : 0, 1177101
Total [candidate] (10.948 s) : 0, 10947855
section profiling
Agent [baseline] (1.259 s) : 0, 1258717
Total [baseline] (10.829 s) : 0, 10828599
Agent [candidate] (1.259 s) : 0, 1259457
Total [candidate] (10.936 s) : 0, 10936348

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.185 s	140.808 ms (13.5%)
Agent	iast	1.172 s	127.868 ms (12.2%)
Agent	profiling	1.259 s	214.816 ms (20.6%)
Total	tracing	10.624 s	-
Total	appsec	10.796 s	172.554 ms (1.6%)
Total	iast	10.957 s	333.908 ms (3.1%)
Total	profiling	10.829 s	205.04 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	appsec	1.182 s	142.599 ms (13.7%)
Agent	iast	1.177 s	138.045 ms (13.3%)
Agent	profiling	1.259 s	220.4 ms (21.2%)
Total	tracing	10.484 s	-
Total	appsec	10.731 s	246.739 ms (2.4%)
Total	iast	10.948 s	463.493 ms (4.4%)
Total	profiling	10.936 s	451.987 ms (4.3%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.524 ms) : 0, 719524
BytebuddyAgent [candidate] (714.738 ms) : 0, 714738
GlobalTracer [baseline] (241.163 ms) : 0, 241163
GlobalTracer [candidate] (240.948 ms) : 0, 240948
AppSec [baseline] (55.535 ms) : 0, 55535
AppSec [candidate] (55.682 ms) : 0, 55682
Remote Config [baseline] (720.613 µs) : 0, 721
Remote Config [candidate] (722.298 µs) : 0, 722
Telemetry [baseline] (11.58 ms) : 0, 11580
Telemetry [candidate] (11.688 ms) : 0, 11688
section appsec
BytebuddyAgent [baseline] (734.365 ms) : 0, 734365
BytebuddyAgent [candidate] (732.663 ms) : 0, 732663
GlobalTracer [baseline] (238.329 ms) : 0, 238329
GlobalTracer [candidate] (237.766 ms) : 0, 237766
IAST [baseline] (21.821 ms) : 0, 21821
IAST [candidate] (21.606 ms) : 0, 21606
AppSec [baseline] (176.841 ms) : 0, 176841
AppSec [candidate] (175.919 ms) : 0, 175919
Remote Config [baseline] (657.717 µs) : 0, 658
Remote Config [candidate] (650.469 µs) : 0, 650
Telemetry [baseline] (8.325 ms) : 0, 8325
Telemetry [candidate] (8.616 ms) : 0, 8616
section iast
BytebuddyAgent [baseline] (836.739 ms) : 0, 836739
BytebuddyAgent [candidate] (840.614 ms) : 0, 840614
GlobalTracer [baseline] (231.073 ms) : 0, 231073
GlobalTracer [candidate] (231.686 ms) : 0, 231686
IAST [baseline] (26.219 ms) : 0, 26219
IAST [candidate] (25.801 ms) : 0, 25801
AppSec [baseline] (52.989 ms) : 0, 52989
AppSec [candidate] (54.096 ms) : 0, 54096
Remote Config [baseline] (627.236 µs) : 0, 627
Remote Config [candidate] (619.694 µs) : 0, 620
Telemetry [baseline] (8.752 ms) : 0, 8752
Telemetry [candidate] (8.85 ms) : 0, 8850
section profiling
BytebuddyAgent [baseline] (705.502 ms) : 0, 705502
BytebuddyAgent [candidate] (706.61 ms) : 0, 706610
GlobalTracer [baseline] (351.071 ms) : 0, 351071
GlobalTracer [candidate] (351.821 ms) : 0, 351821
AppSec [baseline] (55.002 ms) : 0, 55002
AppSec [candidate] (53.755 ms) : 0, 53755
Remote Config [baseline] (707.868 µs) : 0, 708
Remote Config [candidate] (688.398 µs) : 0, 688
Telemetry [baseline] (8.913 ms) : 0, 8913
Telemetry [candidate] (8.869 ms) : 0, 8869
ProfilingAgent [baseline] (95.262 ms) : 0, 95262
ProfilingAgent [candidate] (95.301 ms) : 0, 95301
Profiling [baseline] (95.289 ms) : 0, 95289
Profiling [candidate] (95.328 ms) : 0, 95328

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-29T16:09:17	2025-01-29T16:16:21
git_branch	master	jb/tempfiles_1
git_commit_date	1738161747	1738166222
git_commit_sha	`a41d151`	`36d017f`
release_version	1.46.0-SNAPSHOT~a41d1512de	1.46.0-SNAPSHOT~36d017f9e1
start_time	2025-01-29T16:09:04	2025-01-29T16:16:07

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738167739	1738167739
ci_job_id	785768583	785768583
ci_pipeline_id	54337387	54337387
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zsvuzntn-project-304-concurrent-0-281jjox1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zsvuzntn-project-304-concurrent-0-281jjox1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
.   : milestone, 1352,
appsec (1.737 ms) : 1713, 1760
.   : milestone, 1737,
appsec_no_iast (1.734 ms) : 1709, 1759
.   : milestone, 1734,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.559 ms) : 1534, 1584
.   : milestone, 1559,
tracing (1.504 ms) : 1478, 1529
.   : milestone, 1504,
section candidate
no_agent (1.353 ms) : 1333, 1373
.   : milestone, 1353,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.74 ms) : 1715, 1765
.   : milestone, 1740,
iast (1.505 ms) : 1481, 1528
.   : milestone, 1505,
profiling (1.545 ms) : 1520, 1570
.   : milestone, 1545,
tracing (1.486 ms) : 1461, 1512
.   : milestone, 1486,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.332 ms, 1.372 ms]	-
appsec	1.737 ms [1.713 ms, 1.76 ms]	384.691 µs (28.5%)
appsec_no_iast	1.734 ms [1.709 ms, 1.759 ms]	382.164 µs (28.3%)
iast	1.51 ms [1.486 ms, 1.534 ms]	158.375 µs (11.7%)
profiling	1.559 ms [1.534 ms, 1.584 ms]	206.79 µs (15.3%)
tracing	1.504 ms [1.478 ms, 1.529 ms]	151.793 µs (11.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.333 ms, 1.373 ms]	-
appsec	1.725 ms [1.701 ms, 1.749 ms]	372.532 µs (27.5%)
appsec_no_iast	1.74 ms [1.715 ms, 1.765 ms]	387.394 µs (28.6%)
iast	1.505 ms [1.481 ms, 1.528 ms]	151.951 µs (11.2%)
profiling	1.545 ms [1.52 ms, 1.57 ms]	192.367 µs (14.2%)
tracing	1.486 ms [1.461 ms, 1.512 ms]	133.596 µs (9.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (388.398 µs) : 369, 408
.   : milestone, 388,
iast (506.436 µs) : 484, 529
.   : milestone, 506,
iast_FULL (746.868 µs) : 724, 770
.   : milestone, 747,
iast_GLOBAL (556.346 µs) : 533, 579
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (511.09 µs) : 488, 534
.   : milestone, 511,
iast_INACTIVE (456.489 µs) : 436, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (497.708 µs) : 475, 521
.   : milestone, 498,
tracing (455.941 µs) : 434, 477
.   : milestone, 456,
section candidate
no_agent (375.654 µs) : 356, 395
.   : milestone, 376,
iast (512.072 µs) : 489, 535
.   : milestone, 512,
iast_FULL (740.742 µs) : 719, 763
.   : milestone, 741,
iast_GLOBAL (560.336 µs) : 536, 585
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (506.002 µs) : 483, 529
.   : milestone, 506,
iast_INACTIVE (465.17 µs) : 443, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (497.587 µs) : 474, 521
.   : milestone, 498,
tracing (452.122 µs) : 431, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	388.398 µs [368.67 µs, 408.127 µs]	-
iast	506.436 µs [483.751 µs, 529.121 µs]	118.037 µs (30.4%)
iast_FULL	746.868 µs [724.101 µs, 769.634 µs]	358.469 µs (92.3%)
iast_GLOBAL	556.346 µs [533.277 µs, 579.416 µs]	167.948 µs (43.2%)
iast_HARDCODED_SECRET_DISABLED	511.09 µs [488.076 µs, 534.105 µs]	122.692 µs (31.6%)
iast_INACTIVE	456.489 µs [435.634 µs, 477.344 µs]	68.091 µs (17.5%)
iast_TELEMETRY_OFF	497.708 µs [474.701 µs, 520.714 µs]	109.309 µs (28.1%)
tracing	455.941 µs [434.457 µs, 477.426 µs]	67.543 µs (17.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.654 µs [356.314 µs, 394.995 µs]	-
iast	512.072 µs [488.914 µs, 535.23 µs]	136.418 µs (36.3%)
iast_FULL	740.742 µs [718.829 µs, 762.654 µs]	365.087 µs (97.2%)
iast_GLOBAL	560.336 µs [535.78 µs, 584.892 µs]	184.681 µs (49.2%)
iast_HARDCODED_SECRET_DISABLED	506.002 µs [482.924 µs, 529.08 µs]	130.348 µs (34.7%)
iast_INACTIVE	465.17 µs [442.941 µs, 487.399 µs]	89.515 µs (23.8%)
iast_TELEMETRY_OFF	497.587 µs [474.32 µs, 520.854 µs]	121.933 µs (32.5%)
tracing	452.122 µs [430.929 µs, 473.314 µs]	76.467 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/tempfiles_1
git_commit_date	1738161747	1738166222
git_commit_sha	`a41d151`	`36d017f`
release_version	1.46.0-SNAPSHOT~a41d1512de	1.46.0-SNAPSHOT~36d017f9e1

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738168142	1738168142
ci_job_id	785768584	785768584
ci_pipeline_id	54337387	54337387
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xcwqdre5-project-304-concurrent-1-dylscq43 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xcwqdre5-project-304-concurrent-1-dylscq43 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
appsec (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
iast (18.882 s) : 18882000, 18882000
.   : milestone, 18882000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
.   : milestone, 18137000,
profiling (15.85 s) : 15850000, 15850000
.   : milestone, 15850000,
tracing (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
section candidate
no_agent (15.602 s) : 15602000, 15602000
.   : milestone, 15602000,
appsec (15.218 s) : 15218000, 15218000
.   : milestone, 15218000,
iast (18.332 s) : 18332000, 18332000
.   : milestone, 18332000,
iast_GLOBAL (17.574 s) : 17574000, 17574000
.   : milestone, 17574000,
profiling (15.652 s) : 15652000, 15652000
.   : milestone, 15652000,
tracing (14.706 s) : 14706000, 14706000
.   : milestone, 14706000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.941 s [14.941 s, 14.941 s]	-
appsec	15.242 s [15.242 s, 15.242 s]	301.0 ms (2.0%)
iast	18.882 s [18.882 s, 18.882 s]	3.941 s (26.4%)
iast_GLOBAL	18.137 s [18.137 s, 18.137 s]	3.196 s (21.4%)
profiling	15.85 s [15.85 s, 15.85 s]	909.0 ms (6.1%)
tracing	15.183 s [15.183 s, 15.183 s]	242.0 ms (1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.602 s [15.602 s, 15.602 s]	-
appsec	15.218 s [15.218 s, 15.218 s]	-384.0 ms (-2.5%)
iast	18.332 s [18.332 s, 18.332 s]	2.73 s (17.5%)
iast_GLOBAL	17.574 s [17.574 s, 17.574 s]	1.972 s (12.6%)
profiling	15.652 s [15.652 s, 15.652 s]	50.0 ms (0.3%)
tracing	14.706 s [14.706 s, 14.706 s]	-896.0 ms (-5.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~36d017f9e1, baseline=1.46.0-SNAPSHOT~a41d1512de
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
.   : milestone, 1480,
appsec (2.363 ms) : 2320, 2406
.   : milestone, 2363,
iast (2.112 ms) : 2057, 2167
.   : milestone, 2112,
iast_GLOBAL (2.167 ms) : 2112, 2223
.   : milestone, 2167,
profiling (1.98 ms) : 1936, 2023
.   : milestone, 1980,
tracing (1.947 ms) : 1905, 1989
.   : milestone, 1947,
section candidate
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (2.364 ms) : 2321, 2408
.   : milestone, 2364,
iast (2.119 ms) : 2064, 2174
.   : milestone, 2119,
iast_GLOBAL (2.164 ms) : 2108, 2219
.   : milestone, 2164,
profiling (2.457 ms) : 2269, 2644
.   : milestone, 2457,
tracing (1.958 ms) : 1916, 2001
.   : milestone, 1958,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.492 ms]	-
appsec	2.363 ms [2.32 ms, 2.406 ms]	882.985 µs (59.7%)
iast	2.112 ms [2.057 ms, 2.167 ms]	631.969 µs (42.7%)
iast_GLOBAL	2.167 ms [2.112 ms, 2.223 ms]	687.207 µs (46.4%)
profiling	1.98 ms [1.936 ms, 2.023 ms]	499.578 µs (33.8%)
tracing	1.947 ms [1.905 ms, 1.989 ms]	467.312 µs (31.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.469 ms, 1.492 ms]	-
appsec	2.364 ms [2.321 ms, 2.408 ms]	883.769 µs (59.7%)
iast	2.119 ms [2.064 ms, 2.174 ms]	638.154 µs (43.1%)
iast_GLOBAL	2.164 ms [2.108 ms, 2.219 ms]	683.166 µs (46.1%)
profiling	2.457 ms [2.269 ms, 2.644 ms]	976.226 µs (65.9%)
tracing	1.958 ms [1.916 ms, 2.001 ms]	477.849 µs (32.3%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

Fix TempLocationManager on windows

36d017f

jbachorik added type: bug comp: profiling Profiling labels Jan 29, 2025

jbachorik requested a review from a team as a code owner January 29, 2025 16:04

jbachorik added type: enhancement and removed type: enhancement labels Jan 29, 2025

MattAlp approved these changes Jan 29, 2025

View reviewed changes

jbachorik merged commit 0b52bd6 into master Jan 29, 2025
201 of 202 checks passed

jbachorik deleted the jb/tempfiles_1 branch January 29, 2025 17:38

github-actions bot added this to the 1.46.0 milestone Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid unsupported API call for creating folders on windows #8304

Avoid unsupported API call for creating folders on windows #8304

jbachorik commented Jan 29, 2025 •

edited

Loading

pr-commenter bot commented Jan 29, 2025

Avoid unsupported API call for creating folders on windows #8304

Avoid unsupported API call for creating folders on windows #8304

Conversation

jbachorik commented Jan 29, 2025 • edited Loading

What Does This Do

Motivation

Contributor Checklist

pr-commenter bot commented Jan 29, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jbachorik commented Jan 29, 2025 •

edited

Loading