-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tests quarantining #8320
Merged
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/test-quarantine
Jan 31, 2025
Merged
Implement tests quarantining #8320
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/test-quarantine
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: enhancement
comp: ci visibility
Continuous Integration Visibility
labels
Jan 31, 2025
nikita-tkachenko-datadog
requested review from
juan-fernandez and
daniel-mohedano
January 31, 2025 13:48
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041487
Total [baseline] (8.65 s) : 0, 8650489
Agent [candidate] (1.039 s) : 0, 1039324
Total [candidate] (8.624 s) : 0, 8623785
section iast
Agent [baseline] (1.171 s) : 0, 1170874
Total [baseline] (9.195 s) : 0, 9194553
Agent [candidate] (1.17 s) : 0, 1169782
Total [candidate] (9.211 s) : 0, 9210981
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177012
Total [baseline] (9.174 s) : 0, 9173702
Agent [candidate] (1.169 s) : 0, 1168727
Total [candidate] (9.17 s) : 0, 9169658
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163261
Total [baseline] (9.187 s) : 0, 9186727
Agent [candidate] (1.167 s) : 0, 1166532
Total [candidate] (9.201 s) : 0, 9200586
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.909 ms) : 0, 717909
BytebuddyAgent [candidate] (716.864 ms) : 0, 716864
GlobalTracer [baseline] (241.109 ms) : 0, 241109
GlobalTracer [candidate] (239.666 ms) : 0, 239666
AppSec [baseline] (55.297 ms) : 0, 55297
AppSec [candidate] (55.361 ms) : 0, 55361
Remote Config [baseline] (704.758 µs) : 0, 705
Remote Config [candidate] (721.792 µs) : 0, 722
Telemetry [baseline] (11.244 ms) : 0, 11244
Telemetry [candidate] (11.435 ms) : 0, 11435
section iast
BytebuddyAgent [baseline] (834.627 ms) : 0, 834627
BytebuddyAgent [candidate] (834.068 ms) : 0, 834068
GlobalTracer [baseline] (231.847 ms) : 0, 231847
GlobalTracer [candidate] (231.798 ms) : 0, 231798
AppSec [baseline] (55.54 ms) : 0, 55540
AppSec [candidate] (53.053 ms) : 0, 53053
Remote Config [baseline] (618.779 µs) : 0, 619
Remote Config [candidate] (604.708 µs) : 0, 605
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.688 ms) : 0, 8688
IAST [baseline] (24.218 ms) : 0, 24218
IAST [candidate] (26.309 ms) : 0, 26309
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.711 ms) : 0, 839711
BytebuddyAgent [candidate] (833.427 ms) : 0, 833427
GlobalTracer [baseline] (232.341 ms) : 0, 232341
GlobalTracer [candidate] (230.922 ms) : 0, 230922
AppSec [baseline] (54.106 ms) : 0, 54106
AppSec [candidate] (54.687 ms) : 0, 54687
Remote Config [baseline] (618.862 µs) : 0, 619
Remote Config [candidate] (610.69 µs) : 0, 611
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.669 ms) : 0, 8669
IAST [baseline] (25.916 ms) : 0, 25916
IAST [candidate] (25.128 ms) : 0, 25128
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.251 ms) : 0, 829251
BytebuddyAgent [candidate] (831.655 ms) : 0, 831655
GlobalTracer [baseline] (230.43 ms) : 0, 230430
GlobalTracer [candidate] (231.276 ms) : 0, 231276
AppSec [baseline] (53.822 ms) : 0, 53822
AppSec [candidate] (54.604 ms) : 0, 54604
Remote Config [baseline] (617.171 µs) : 0, 617
Remote Config [candidate] (613.443 µs) : 0, 613
Telemetry [baseline] (8.615 ms) : 0, 8615
Telemetry [candidate] (8.54 ms) : 0, 8540
IAST [baseline] (25.28 ms) : 0, 25280
IAST [candidate] (24.581 ms) : 0, 24581
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1036686
Total [baseline] (10.432 s) : 0, 10431982
Agent [candidate] (1.042 s) : 0, 1042256
Total [candidate] (10.497 s) : 0, 10496830
section appsec
Agent [baseline] (1.186 s) : 0, 1185559
Total [baseline] (10.777 s) : 0, 10776729
Agent [candidate] (1.191 s) : 0, 1191195
Total [candidate] (10.765 s) : 0, 10764796
section iast
Agent [baseline] (1.17 s) : 0, 1169570
Total [baseline] (10.999 s) : 0, 10999237
Agent [candidate] (1.168 s) : 0, 1168267
Total [candidate] (10.919 s) : 0, 10919091
section profiling
Agent [baseline] (1.259 s) : 0, 1259307
Total [baseline] (10.886 s) : 0, 10885606
Agent [candidate] (1.258 s) : 0, 1257609
Total [candidate] (10.811 s) : 0, 10810724
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.058 ms) : 0, 714058
BytebuddyAgent [candidate] (716.273 ms) : 0, 716273
GlobalTracer [baseline] (239.883 ms) : 0, 239883
GlobalTracer [candidate] (240.313 ms) : 0, 240313
AppSec [baseline] (55.264 ms) : 0, 55264
AppSec [candidate] (55.254 ms) : 0, 55254
Remote Config [baseline] (712.631 µs) : 0, 713
Remote Config [candidate] (711.727 µs) : 0, 712
Telemetry [baseline] (11.574 ms) : 0, 11574
Telemetry [candidate] (14.476 ms) : 0, 14476
section appsec
BytebuddyAgent [baseline] (735.38 ms) : 0, 735380
BytebuddyAgent [candidate] (738.996 ms) : 0, 738996
GlobalTracer [baseline] (238.561 ms) : 0, 238561
GlobalTracer [candidate] (239.709 ms) : 0, 239709
AppSec [baseline] (176.372 ms) : 0, 176372
AppSec [candidate] (177.188 ms) : 0, 177188
Remote Config [baseline] (651.554 µs) : 0, 652
Remote Config [candidate] (657.889 µs) : 0, 658
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (8.383 ms) : 0, 8383
IAST [baseline] (22.047 ms) : 0, 22047
IAST [candidate] (21.762 ms) : 0, 21762
section iast
BytebuddyAgent [baseline] (834.046 ms) : 0, 834046
BytebuddyAgent [candidate] (833.16 ms) : 0, 833160
GlobalTracer [baseline] (231.186 ms) : 0, 231186
GlobalTracer [candidate] (231.156 ms) : 0, 231156
AppSec [baseline] (53.08 ms) : 0, 53080
AppSec [candidate] (53.712 ms) : 0, 53712
Remote Config [baseline] (606.093 µs) : 0, 606
Remote Config [candidate] (603.69 µs) : 0, 604
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (8.704 ms) : 0, 8704
IAST [baseline] (26.696 ms) : 0, 26696
IAST [candidate] (25.664 ms) : 0, 25664
section profiling
BytebuddyAgent [baseline] (705.777 ms) : 0, 705777
BytebuddyAgent [candidate] (705.126 ms) : 0, 705126
GlobalTracer [baseline] (350.037 ms) : 0, 350037
GlobalTracer [candidate] (350.886 ms) : 0, 350886
AppSec [baseline] (55.981 ms) : 0, 55981
AppSec [candidate] (54.182 ms) : 0, 54182
Remote Config [baseline] (702.32 µs) : 0, 702
Remote Config [candidate] (699.735 µs) : 0, 700
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.931 ms) : 0, 8931
ProfilingAgent [baseline] (95.551 ms) : 0, 95551
ProfilingAgent [candidate] (95.531 ms) : 0, 95531
Profiling [baseline] (95.576 ms) : 0, 95576
Profiling [candidate] (95.555 ms) : 0, 95555
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.752 ms) : 1729, 1776
. : milestone, 1752,
appsec_no_iast (1.77 ms) : 1748, 1793
. : milestone, 1770,
iast (1.513 ms) : 1489, 1536
. : milestone, 1513,
profiling (1.513 ms) : 1490, 1537
. : milestone, 1513,
tracing (1.494 ms) : 1468, 1520
. : milestone, 1494,
section candidate
no_agent (1.36 ms) : 1340, 1379
. : milestone, 1360,
appsec (1.743 ms) : 1719, 1767
. : milestone, 1743,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.499 ms) : 1475, 1523
. : milestone, 1499,
profiling (1.526 ms) : 1503, 1549
. : milestone, 1526,
tracing (1.489 ms) : 1464, 1515
. : milestone, 1489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (389.992 µs) : 370, 410
. : milestone, 390,
iast (521.526 µs) : 498, 545
. : milestone, 522,
iast_FULL (750.216 µs) : 727, 773
. : milestone, 750,
iast_GLOBAL (564.479 µs) : 541, 588
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (518.937 µs) : 497, 541
. : milestone, 519,
iast_INACTIVE (463.058 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (499.602 µs) : 476, 523
. : milestone, 500,
tracing (463.895 µs) : 442, 485
. : milestone, 464,
section candidate
no_agent (381.511 µs) : 362, 401
. : milestone, 382,
iast (510.476 µs) : 487, 534
. : milestone, 510,
iast_FULL (750.15 µs) : 727, 774
. : milestone, 750,
iast_GLOBAL (562.411 µs) : 540, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (516.205 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (463.781 µs) : 443, 485
. : milestone, 464,
iast_TELEMETRY_OFF (498.039 µs) : 475, 521
. : milestone, 498,
tracing (453.08 µs) : 433, 474
. : milestone, 453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.365 ms) : 2322, 2409
. : milestone, 2365,
iast (2.109 ms) : 2053, 2164
. : milestone, 2109,
iast_GLOBAL (2.157 ms) : 2101, 2212
. : milestone, 2157,
profiling (1.994 ms) : 1949, 2039
. : milestone, 1994,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.369 ms) : 2326, 2413
. : milestone, 2369,
iast (2.114 ms) : 2059, 2169
. : milestone, 2114,
iast_GLOBAL (2.147 ms) : 2092, 2202
. : milestone, 2147,
profiling (1.962 ms) : 1918, 2005
. : milestone, 1962,
tracing (1.96 ms) : 1917, 2002
. : milestone, 1960,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6c76dc4a0f, baseline=1.47.0-SNAPSHOT~b24d15319f
dateFormat X
axisFormat %s
section baseline
no_agent (15.261 s) : 15261000, 15261000
. : milestone, 15261000,
appsec (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
iast (18.632 s) : 18632000, 18632000
. : milestone, 18632000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
profiling (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
tracing (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
section candidate
no_agent (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
appsec (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
iast (18.378 s) : 18378000, 18378000
. : milestone, 18378000,
iast_GLOBAL (18.093 s) : 18093000, 18093000
. : milestone, 18093000,
profiling (15.091 s) : 15091000, 15091000
. : milestone, 15091000,
tracing (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
|
daniel-mohedano
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implements tests quarantining.
A quarantined test case is run as usual, but if it fails the status of the build is not affected (i.e. if a quarantined test fails, the build can still be successful).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1483