Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equals/hashCode for CodeOrigin probe #8319

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix equals/hashCode for CodeOrigin probe #8319

merged 1 commit into from
Feb 3, 2025
+49 −24

Conversation

jpbempel
Copy link
Member

add toString

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1738601978 1738602362
end_time 2025-02-03T17:00:54 2025-02-03T17:07:19
git_branch master jpbempel/code-origin-eq-hc
git_commit_sha 5d18c24 d346a7c
start_time 2025-02-03T16:59:38 2025-02-03T17:06:03
See matching parameters
Baseline Candidate
ci_job_id 791673433 791673433
ci_pipeline_id 54739242 54739242
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1738601282 1738601282

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 8 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-772.054µs; -714.275µs] or [-7.201%; -6.662%]		 better
[-817.149µs; -732.100µs] or [-7.495%; -6.715%]		 better
[-836.807µs; -689.815µs] or [-7.603%; -6.268%]		 better
[-925.742µs; -550.286µs] or [-8.182%; -4.864%]		 better
[+5.180op/s; +7.999op/s] or [+5.724%; +8.839%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-82.321µs; +49.108µs] or [-27.844%; +16.610%]		 unstable
[-117.202µs; +69.575µs] or [-33.952%; +20.155%]		 unstable
[-391.291µs; +156.761µs] or [-86.240%; +34.550%]		 unstable
[-1093.058µs; +563.946µs] or [-111.440%; +57.496%]		 same
scenario:basic same unstable
[-42.974µs; +13.366µs] or [-13.266%; +4.126%]		 unstable
[-49.721µs; +15.172µs] or [-14.772%; +4.508%]		 unstable
[-932.995µs; +329.206µs] or [-110.363%; +38.941%]		 unstable
[-192.628op/s; +192.628op/s] or [-7.705%; +7.705%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (345.204 µs) : 233, 457
.   : milestone, 345,
basic (323.946 µs) : 287, 361
.   : milestone, 324,
loop (10.902 ms) : 10854, 10951
.   : milestone, 10902,
section candidate
noprobe (321.39 µs) : 264, 379
.   : milestone, 321,
basic (309.142 µs) : 298, 320
.   : milestone, 309,
loop (10.128 ms) : 10100, 10155
.   : milestone, 10128,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 345.204 µs [233.128 µs, 457.28 µs]
basic 323.946 µs [286.66 µs, 361.232 µs]
loop 10.902 ms [10.854 ms, 10.951 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 321.39 µs [264.055 µs, 378.725 µs]
basic 309.142 µs [297.981 µs, 320.303 µs]
loop 10.128 ms [10.1 ms, 10.155 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/code-origin-eq-hc
git_commit_date 1738600460 1738601282
git_commit_sha 5d18c24 d346a7c
release_version 1.47.0-SNAPSHOT~5d18c24208 1.47.0-SNAPSHOT~d346a7ca9c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738603741 1738603741
ci_job_id 791673427 791673427
ci_pipeline_id 54739242 54739242
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-yk6jynms-project-304-concurrent-0-ht3el5rx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-yk6jynms-project-304-concurrent-0-ht3el5rx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043338
Total [baseline] (10.534 s) : 0, 10534114
Agent [candidate] (1.042 s) : 0, 1042184
Total [candidate] (10.538 s) : 0, 10537515
section appsec
Agent [baseline] (1.19 s) : 0, 1190200
Total [baseline] (10.75 s) : 0, 10750400
Agent [candidate] (1.186 s) : 0, 1185681
Total [candidate] (10.79 s) : 0, 10790206
section iast
Agent [baseline] (1.175 s) : 0, 1175173
Total [baseline] (11.016 s) : 0, 11015628
Agent [candidate] (1.17 s) : 0, 1169516
Total [candidate] (11.026 s) : 0, 11025571
section profiling
Agent [baseline] (1.26 s) : 0, 1259627
Total [baseline] (10.875 s) : 0, 10874960
Agent [candidate] (1.267 s) : 0, 1267008
Total [candidate] (10.861 s) : 0, 10860725
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.19 s 146.862 ms (14.1%)
Agent iast 1.175 s 131.836 ms (12.6%)
Agent profiling 1.26 s 216.289 ms (20.7%)
Total tracing 10.534 s -
Total appsec 10.75 s 216.286 ms (2.1%)
Total iast 11.016 s 481.514 ms (4.6%)
Total profiling 10.875 s 340.846 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.186 s 143.497 ms (13.8%)
Agent iast 1.17 s 127.332 ms (12.2%)
Agent profiling 1.267 s 224.824 ms (21.6%)
Total tracing 10.538 s -
Total appsec 10.79 s 252.691 ms (2.4%)
Total iast 11.026 s 488.056 ms (4.6%)
Total profiling 10.861 s 323.211 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.226 ms) : 0, 716226
BytebuddyAgent [candidate] (716.051 ms) : 0, 716051
GlobalTracer [baseline] (243.599 ms) : 0, 243599
GlobalTracer [candidate] (242.44 ms) : 0, 242440
AppSec [baseline] (55.272 ms) : 0, 55272
AppSec [candidate] (55.78 ms) : 0, 55780
Remote Config [baseline] (709.142 µs) : 0, 709
Remote Config [candidate] (726.677 µs) : 0, 727
Telemetry [baseline] (12.287 ms) : 0, 12287
Telemetry [candidate] (12.07 ms) : 0, 12070
section appsec
BytebuddyAgent [baseline] (736.235 ms) : 0, 736235
BytebuddyAgent [candidate] (734.747 ms) : 0, 734747
GlobalTracer [baseline] (242.19 ms) : 0, 242190
GlobalTracer [candidate] (238.914 ms) : 0, 238914
IAST [baseline] (21.411 ms) : 0, 21411
IAST [candidate] (21.555 ms) : 0, 21555
AppSec [baseline] (176.835 ms) : 0, 176835
AppSec [candidate] (176.553 ms) : 0, 176553
Remote Config [baseline] (658.025 µs) : 0, 658
Remote Config [candidate] (664.943 µs) : 0, 665
Telemetry [baseline] (8.307 ms) : 0, 8307
Telemetry [candidate] (8.675 ms) : 0, 8675
section iast
BytebuddyAgent [baseline] (836.172 ms) : 0, 836172
BytebuddyAgent [candidate] (833.326 ms) : 0, 833326
GlobalTracer [baseline] (234.887 ms) : 0, 234887
GlobalTracer [candidate] (231.488 ms) : 0, 231488
IAST [baseline] (25.85 ms) : 0, 25850
IAST [candidate] (26.592 ms) : 0, 26592
AppSec [baseline] (53.647 ms) : 0, 53647
AppSec [candidate] (53.42 ms) : 0, 53420
Remote Config [baseline] (609.941 µs) : 0, 610
Remote Config [candidate] (617.545 µs) : 0, 618
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.724 ms) : 0, 8724
section profiling
BytebuddyAgent [baseline] (704.79 ms) : 0, 704790
BytebuddyAgent [candidate] (708.57 ms) : 0, 708570
GlobalTracer [baseline] (352.608 ms) : 0, 352608
GlobalTracer [candidate] (354.825 ms) : 0, 354825
AppSec [baseline] (55.416 ms) : 0, 55416
AppSec [candidate] (54.943 ms) : 0, 54943
Remote Config [baseline] (689.039 µs) : 0, 689
Remote Config [candidate] (709.953 µs) : 0, 710
Telemetry [baseline] (8.902 ms) : 0, 8902
Telemetry [candidate] (9.036 ms) : 0, 9036
ProfilingAgent [baseline] (95.108 ms) : 0, 95108
ProfilingAgent [candidate] (96.572 ms) : 0, 96572
Profiling [baseline] (95.135 ms) : 0, 95135
Profiling [candidate] (96.599 ms) : 0, 96599
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042449
Total [baseline] (8.654 s) : 0, 8654081
Agent [candidate] (1.036 s) : 0, 1035541
Total [candidate] (8.628 s) : 0, 8627589
section iast
Agent [baseline] (1.173 s) : 0, 1173445
Total [baseline] (9.218 s) : 0, 9218124
Agent [candidate] (1.171 s) : 0, 1171488
Total [candidate] (9.265 s) : 0, 9265062
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183363
Total [baseline] (9.256 s) : 0, 9255654
Agent [candidate] (1.17 s) : 0, 1170437
Total [candidate] (9.23 s) : 0, 9230017
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169020
Total [baseline] (9.248 s) : 0, 9248162
Agent [candidate] (1.165 s) : 0, 1165094
Total [candidate] (9.21 s) : 0, 9209800
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.173 s 130.996 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 140.914 ms (13.5%)
Agent iast_TELEMETRY_OFF 1.169 s 126.572 ms (12.1%)
Total tracing 8.654 s -
Total iast 9.218 s 564.044 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.256 s 601.574 ms (7.0%)
Total iast_TELEMETRY_OFF 9.248 s 594.082 ms (6.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent iast 1.171 s 135.947 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 134.896 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.165 s 129.552 ms (12.5%)
Total tracing 8.628 s -
Total iast 9.265 s 637.473 ms (7.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.23 s 602.428 ms (7.0%)
Total iast_TELEMETRY_OFF 9.21 s 582.211 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.746 ms) : 0, 715746
BytebuddyAgent [candidate] (714.194 ms) : 0, 714194
GlobalTracer [baseline] (243.516 ms) : 0, 243516
GlobalTracer [candidate] (240.093 ms) : 0, 240093
AppSec [baseline] (55.476 ms) : 0, 55476
AppSec [candidate] (55.312 ms) : 0, 55312
Remote Config [baseline] (727.791 µs) : 0, 728
Remote Config [candidate] (714.179 µs) : 0, 714
Telemetry [baseline] (11.742 ms) : 0, 11742
Telemetry [candidate] (9.973 ms) : 0, 9973
section iast
BytebuddyAgent [baseline] (834.6 ms) : 0, 834600
BytebuddyAgent [candidate] (835.415 ms) : 0, 835415
GlobalTracer [baseline] (234.409 ms) : 0, 234409
GlobalTracer [candidate] (232.039 ms) : 0, 232039
IAST [baseline] (23.442 ms) : 0, 23442
IAST [candidate] (24.938 ms) : 0, 24938
AppSec [baseline] (56.319 ms) : 0, 56319
AppSec [candidate] (54.566 ms) : 0, 54566
Remote Config [baseline] (626.865 µs) : 0, 627
Remote Config [candidate] (605.77 µs) : 0, 606
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (8.611 ms) : 0, 8611
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.885 ms) : 0, 842885
BytebuddyAgent [candidate] (834.693 ms) : 0, 834693
GlobalTracer [baseline] (235.476 ms) : 0, 235476
GlobalTracer [candidate] (231.614 ms) : 0, 231614
IAST [baseline] (25.919 ms) : 0, 25919
IAST [candidate] (25.673 ms) : 0, 25673
AppSec [baseline] (54.167 ms) : 0, 54167
AppSec [candidate] (53.7 ms) : 0, 53700
Remote Config [baseline] (620.054 µs) : 0, 620
Remote Config [candidate] (622.577 µs) : 0, 623
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (8.759 ms) : 0, 8759
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.557 ms) : 0, 831557
BytebuddyAgent [candidate] (830.637 ms) : 0, 830637
GlobalTracer [baseline] (234.049 ms) : 0, 234049
GlobalTracer [candidate] (231.224 ms) : 0, 231224
IAST [baseline] (25.39 ms) : 0, 25390
IAST [candidate] (24.135 ms) : 0, 24135
AppSec [baseline] (53.589 ms) : 0, 53589
AppSec [candidate] (54.69 ms) : 0, 54690
Remote Config [baseline] (613.574 µs) : 0, 614
Remote Config [candidate] (599.61 µs) : 0, 600
Telemetry [baseline] (8.587 ms) : 0, 8587
Telemetry [candidate] (8.509 ms) : 0, 8509
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-03T17:01:00 2025-02-03T17:08:05
git_branch master jpbempel/code-origin-eq-hc
git_commit_date 1738600460 1738601282
git_commit_sha 5d18c24 d346a7c
release_version 1.47.0-SNAPSHOT~5d18c24208 1.47.0-SNAPSHOT~d346a7ca9c
start_time 2025-02-03T17:00:46 2025-02-03T17:07:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738602844 1738602844
ci_job_id 791673428 791673428
ci_pipeline_id 54739242 54739242
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hf2spk2o-project-304-concurrent-0-y8l4pnld 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hf2spk2o-project-304-concurrent-0-y8l4pnld 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.99 µs) : 360, 400
.   : milestone, 380,
iast (513.335 µs) : 491, 535
.   : milestone, 513,
iast_FULL (738.486 µs) : 717, 760
.   : milestone, 738,
iast_GLOBAL (562.327 µs) : 540, 585
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (508.226 µs) : 486, 531
.   : milestone, 508,
iast_INACTIVE (466.031 µs) : 445, 487
.   : milestone, 466,
iast_TELEMETRY_OFF (500.923 µs) : 477, 525
.   : milestone, 501,
tracing (459.541 µs) : 438, 481
.   : milestone, 460,
section candidate
no_agent (388.159 µs) : 368, 408
.   : milestone, 388,
iast (510.039 µs) : 487, 533
.   : milestone, 510,
iast_FULL (756.571 µs) : 734, 779
.   : milestone, 757,
iast_GLOBAL (565.771 µs) : 542, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (514.428 µs) : 492, 537
.   : milestone, 514,
iast_INACTIVE (459.265 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (503.65 µs) : 480, 527
.   : milestone, 504,
tracing (456.24 µs) : 435, 477
.   : milestone, 456,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.99 µs [360.12 µs, 399.86 µs] -
iast 513.335 µs [491.302 µs, 535.368 µs] 133.345 µs (35.1%)
iast_FULL 738.486 µs [716.672 µs, 760.3 µs] 358.496 µs (94.3%)
iast_GLOBAL 562.327 µs [539.736 µs, 584.919 µs] 182.338 µs (48.0%)
iast_HARDCODED_SECRET_DISABLED 508.226 µs [485.887 µs, 530.566 µs] 128.237 µs (33.7%)
iast_INACTIVE 466.031 µs [444.79 µs, 487.271 µs] 86.041 µs (22.6%)
iast_TELEMETRY_OFF 500.923 µs [477.335 µs, 524.511 µs] 120.933 µs (31.8%)
tracing 459.541 µs [438.146 µs, 480.935 µs] 79.551 µs (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.159 µs [368.25 µs, 408.069 µs] -
iast 510.039 µs [486.67 µs, 533.409 µs] 121.88 µs (31.4%)
iast_FULL 756.571 µs [734.456 µs, 778.687 µs] 368.412 µs (94.9%)
iast_GLOBAL 565.771 µs [542.203 µs, 589.339 µs] 177.612 µs (45.8%)
iast_HARDCODED_SECRET_DISABLED 514.428 µs [491.529 µs, 537.326 µs] 126.269 µs (32.5%)
iast_INACTIVE 459.265 µs [438.297 µs, 480.233 µs] 71.106 µs (18.3%)
iast_TELEMETRY_OFF 503.65 µs [480.278 µs, 527.021 µs] 115.491 µs (29.8%)
tracing 456.24 µs [435.167 µs, 477.313 µs] 68.081 µs (17.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1382
.   : milestone, 1361,
appsec (1.754 ms) : 1731, 1777
.   : milestone, 1754,
appsec_no_iast (1.764 ms) : 1742, 1786
.   : milestone, 1764,
iast (1.499 ms) : 1474, 1525
.   : milestone, 1499,
profiling (1.513 ms) : 1489, 1537
.   : milestone, 1513,
tracing (1.481 ms) : 1456, 1506
.   : milestone, 1481,
section candidate
no_agent (1.366 ms) : 1345, 1386
.   : milestone, 1366,
appsec (1.769 ms) : 1746, 1793
.   : milestone, 1769,
appsec_no_iast (1.761 ms) : 1736, 1786
.   : milestone, 1761,
iast (1.51 ms) : 1485, 1534
.   : milestone, 1510,
profiling (1.534 ms) : 1512, 1557
.   : milestone, 1534,
tracing (1.487 ms) : 1461, 1512
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.382 ms] -
appsec 1.754 ms [1.731 ms, 1.777 ms] 392.593 µs (28.8%)
appsec_no_iast 1.764 ms [1.742 ms, 1.786 ms] 402.533 µs (29.6%)
iast 1.499 ms [1.474 ms, 1.525 ms] 137.955 µs (10.1%)
profiling 1.513 ms [1.489 ms, 1.537 ms] 151.363 µs (11.1%)
tracing 1.481 ms [1.456 ms, 1.506 ms] 119.68 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.345 ms, 1.386 ms] -
appsec 1.769 ms [1.746 ms, 1.793 ms] 403.22 µs (29.5%)
appsec_no_iast 1.761 ms [1.736 ms, 1.786 ms] 395.201 µs (28.9%)
iast 1.51 ms [1.485 ms, 1.534 ms] 143.663 µs (10.5%)
profiling 1.534 ms [1.512 ms, 1.557 ms] 168.489 µs (12.3%)
tracing 1.487 ms [1.461 ms, 1.512 ms] 120.731 µs (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/code-origin-eq-hc
git_commit_date 1738600460 1738601282
git_commit_sha 5d18c24 d346a7c
release_version 1.47.0-SNAPSHOT~5d18c24208 1.47.0-SNAPSHOT~d346a7ca9c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738603446 1738603446
ci_job_id 791673429 791673429
ci_pipeline_id 54739242 54739242
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-rt13twwf-project-304-concurrent-0-qb69wnld 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-rt13twwf-project-304-concurrent-0-qb69wnld 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.245 s) : 15245000, 15245000
.   : milestone, 15245000,
appsec (15.37 s) : 15370000, 15370000
.   : milestone, 15370000,
iast (18.857 s) : 18857000, 18857000
.   : milestone, 18857000,
iast_GLOBAL (18.078 s) : 18078000, 18078000
.   : milestone, 18078000,
profiling (15.614 s) : 15614000, 15614000
.   : milestone, 15614000,
tracing (14.938 s) : 14938000, 14938000
.   : milestone, 14938000,
section candidate
no_agent (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
appsec (15.217 s) : 15217000, 15217000
.   : milestone, 15217000,
iast (18.87 s) : 18870000, 18870000
.   : milestone, 18870000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
.   : milestone, 18113000,
profiling (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
tracing (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.245 s [15.245 s, 15.245 s] -
appsec 15.37 s [15.37 s, 15.37 s] 125.0 ms (0.8%)
iast 18.857 s [18.857 s, 18.857 s] 3.612 s (23.7%)
iast_GLOBAL 18.078 s [18.078 s, 18.078 s] 2.833 s (18.6%)
profiling 15.614 s [15.614 s, 15.614 s] 369.0 ms (2.4%)
tracing 14.938 s [14.938 s, 14.938 s] -307.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.052 s [15.052 s, 15.052 s] -
appsec 15.217 s [15.217 s, 15.217 s] 165.0 ms (1.1%)
iast 18.87 s [18.87 s, 18.87 s] 3.818 s (25.4%)
iast_GLOBAL 18.113 s [18.113 s, 18.113 s] 3.061 s (20.3%)
profiling 14.923 s [14.923 s, 14.923 s] -129.0 ms (-0.9%)
tracing 14.923 s [14.923 s, 14.923 s] -129.0 ms (-0.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d346a7ca9c, baseline=1.47.0-SNAPSHOT~5d18c24208
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.359 ms) : 2316, 2402
.   : milestone, 2359,
iast (2.109 ms) : 2055, 2163
.   : milestone, 2109,
iast_GLOBAL (2.144 ms) : 2089, 2199
.   : milestone, 2144,
profiling (2.476 ms) : 2283, 2669
.   : milestone, 2476,
tracing (1.94 ms) : 1898, 1982
.   : milestone, 1940,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.368 ms) : 2324, 2412
.   : milestone, 2368,
iast (2.1 ms) : 2045, 2154
.   : milestone, 2100,
iast_GLOBAL (2.151 ms) : 2095, 2206
.   : milestone, 2151,
profiling (1.969 ms) : 1925, 2013
.   : milestone, 1969,
tracing (1.942 ms) : 1901, 1984
.   : milestone, 1942,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.359 ms [2.316 ms, 2.402 ms] 889.598 µs (60.6%)
iast 2.109 ms [2.055 ms, 2.163 ms] 640.06 µs (43.6%)
iast_GLOBAL 2.144 ms [2.089 ms, 2.199 ms] 675.257 µs (46.0%)
profiling 2.476 ms [2.283 ms, 2.669 ms] 1.007 ms (68.6%)
tracing 1.94 ms [1.898 ms, 1.982 ms] 471.43 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.368 ms [2.324 ms, 2.412 ms] 898.387 µs (61.1%)
iast 2.1 ms [2.045 ms, 2.154 ms] 630.307 µs (42.9%)
iast_GLOBAL 2.151 ms [2.095 ms, 2.206 ms] 680.907 µs (46.3%)
profiling 1.969 ms [1.925 ms, 2.013 ms] 499.193 µs (34.0%)
tracing 1.942 ms [1.901 ms, 1.984 ms] 472.765 µs (32.2%)

@jpbempel jpbempel force-pushed the jpbempel/code-origin-eq-hc branch from b4ee69f to 713e05d Compare January 31, 2025 14:16
@jpbempel jpbempel force-pushed the jpbempel/code-origin-eq-hc branch from 713e05d to d346a7c Compare February 3, 2025 16:50
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug labels Feb 3, 2025
@jpbempel jpbempel marked this pull request as ready for review February 3, 2025 16:51
@jpbempel jpbempel requested a review from a team as a code owner February 3, 2025 16:51
@jpbempel jpbempel requested review from shatzi and removed request for a team February 3, 2025 16:51
shatzi
shatzi approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to show the tags in the toString for all other probes?

@jpbempel
Copy link
Member Author

jpbempel commented Feb 3, 2025 •
edited
Loading

don't we want to show the tags in the toString for all other probes?

we do show, Map is the map representation of the tag arrays, so it's a duplicate

@jpbempel jpbempel merged commit 28acd37 into master Feb 3, 2025
202 of 203 checks passed
@jpbempel jpbempel deleted the jpbempel/code-origin-eq-hc branch February 3, 2025 21:27
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi