[CDN] Add support for Rules engine feature #11521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2019 13:13
…rice (Azure#11494) * [Compute] Upgrade Python Compute SDK to 10.0.0; vm/vmss create: Add 'Spot' to 'Priority' enum property; [Breaking change] Rename '--max-billing' parameter to '--max-price', for both VM and VMSS, to be consistent with Swagger and Powershell cmdlets * [Compute] vm/vmss create: Update --priority help text * [Compute] vm/vmss update: Add --priority; vm/vmss update: Add --max-price * Fix min API version of priority
Contributor
|
Please take a look the ouput which CI thinks it's error. |
…port empty name. (Azure#11196) * Fix issue Azure#10965 - Allow empty Name - Allow multiple entries of same IP or Subnet * Move History entry to next version
* Support policy set definition grouping * Re-record managedapp test in 2019_03_01 profile * Record policy insights tests with new policy api-version
…account (Azure#11488) * feat: Add new commands to manage blob service properties for storage account. * add more help docs for group and command * make resource group as optional parameter * update help and history for new commands * make new commands as preview
Contributor
Author
|
hi @haroldrandom, I have fixed the CI errors. |
* cherry-pick changes from previous S75 PR * commit re-recorded tests * roll back GitHub error link * remove ResourceGroupPreparers from N/A botservice tests * refactor tests * use unittest.TestCase, rerecord scenario tests without defaults * fix style errors, rollback custom rg in tests * update history, mark some commands and groups as in preview * add 'az bot directline update' * add name availabilty check to az bot create * rerecord missed tests * rerecord failing tests without defaults * move botservice changes to correct location * fix lowercase bug on az bot prepare-deploy (Azure#11390) * address PR feedback * delete unused recording
…-deleted/list-versions` with parameter `--maxresults` do not work as intended (Azure#11531) * Fix Azure#8921 * Update history file * Fix linter errors * Split tests apart
* [Compute] Add disk-encryption-set command group * history; yaml * disk-encryption-set create/show * disk create: add disk encryption set support * Update test * Add list * Add disk encryption set support for vm create * Fix minor issue * Update history * Update help * Update test * Resolve review comments * Fix a small bug * Fix style * Add min_api for disk-encryption-set * Add --os-disk-encryption-set and --data-disk-encryption-sets to vmss create * Add disk-encryption-set update * disk-encryption-set update; add test * Add example
* updated CSProj * initial commit * updated csproj * Updated python version 3 requirement * Updated restore request, protected item * CLI Style fix * disable broad except * updated help file changes * updated changes in test workload * updated history.rst * updated history.rst * Added optional name parameter in vm policy set * Updated protectable_item_tpe allowed values * updated help message * Using correct restore request object * fixes for restore command * cli style fix * Added warning message for retain_until parameter * updated recoveryconfig show output * added resume protection command * linter fix
* Update adls version * Update requirements.txt
* Add support for importing certs from Key Vault * Added link to object ids
haroldrandom
approved these changes
Dec 13, 2019
Contributor
haroldrandom
left a comment
haroldrandom
left a comment
There was a problem hiding this comment.
LGTM. Need @Juliehzl @myronfanqiu double check
Collaborator
|
@Juliehzl please help with the PR. |
Contributor
Author
|
@Juliehzl can you help with this PR? |
mmyyrroonn
reviewed
Dec 21, 2019
Contributor
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#keyword-argument-reference
Please go through the reference, address the comments and align them to all arguments and codes.
hytao
requested review from
bgklein,
jaredmoo,
jiasli and
qwordy
as code owners
added 2 commits
December 30, 2019 14:53
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.