[Compute] vm/vmss update: Add --priority; vm/vmss update: Add --max-price #11494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Spot' to 'Priority' enum property; [Breaking change] Rename '--max-billing' parameter to '--max-price', for both VM and VMSS, to be consistent with Swagger and Powershell cmdlets
mmyyrroonn
reviewed
Dec 9, 2019
| "To enable Multitenant Hosting Rights for Windows 10, use 'Windows_Client'. " \ | ||
| "For more information see the Azure Windows VM online docs." | ||
| c.argument('license_type', help=license_msg, arg_type=get_enum_type(['Windows_Server', 'Windows_Client', 'None'])) | ||
| c.argument('priority', resource_type=ResourceType.MGMT_COMPUTE, min_api='2019-03-01', |
Contributor
There was a problem hiding this comment.
curious about the min_api. If the min_api is different in vm and vmss, should we keep them separated?
Member
Author
There was a problem hiding this comment.
Yes, we should. This the cause of error in Profile 2019-03-01, which uses 2017-12-01 for compute.
yungezz
approved these changes
Dec 9, 2019
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11187
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.