[BotService] Updates, enhancements and cleanup in az bot #11318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Juliehzl please review this PR when it's ready. |
stevengum
changed the title
Contributor
Author
|
@Juliehzl this PR is ready for review 🚀 |
Collaborator
Juliehzl
reviewed
Dec 1, 2019
Contributor
Author
jsntcy
reviewed
Dec 2, 2019
src/azure-cli/azure/cli/command_modules/botservice/channel_operations.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Dec 2, 2019
Juliehzl
reviewed
Dec 2, 2019
Juliehzl
reviewed
Dec 2, 2019
Juliehzl
reviewed
Dec 2, 2019
Juliehzl
reviewed
Dec 2, 2019
src/azure-cli/azure/cli/command_modules/botservice/channel_operations.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Dec 2, 2019
Juliehzl
reviewed
Dec 2, 2019
Contributor
|
@stevengum Please resolve the left comments and make CI pass, then I will approve. |
Contributor
|
Hi @@stevengum, please resolve conflicts. |
Contributor
Author
|
@Juliehzl I've rebased the branch and resolved the merge conflicts in HISTORY.rst |
Juliehzl
approved these changes
Dec 11, 2019
This was referenced Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--versionflag foraz bot create -k webapp(Only v4 bots are supported) (Fixes: AZ CLI: Remove --version flag from az bot create microsoft/botframework-sdk#5669)az bot create(Fixes: AZ CLI: Add name availability check to az bot create microsoft/botbuilder-tools#1287)--enable-enhanced-authflag toaz bot directline createaz bot directline update(Fixes: Add trusted origin to direct line channel without using Azure portal #9954)--passwordrequirement foraz bot create- it is only required for creating Web App Bots, not Registration Botsaz bot prepare-deploytests intoBotLocalErrorsTestsusing(unittest.TestCase)as these tests deal with local file creation for deploying bots to Azure.az bot prepare-deploychanging--proj-file-pathvalue to lower case (e.g."Test.csproj"to"test.csproj") (Fixes: az bot prepare-deploy changes assembly name to lowercase #11390)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.