feat: Add new commands to manage blob service properties for storage account #11488
Conversation
|
@Juliehzl please help review the PR. |
|
|
||
| with self.argument_context('storage account blob-service-properties update') as c: | ||
| c.argument('account_name', acct_name_type, id_part=None) | ||
| c.argument('enable_change_feed', arg_type=get_three_state_flag(), |
There was a problem hiding this comment.
Please give more detailed help message for ChangeFeed feature and use active voice.
There was a problem hiding this comment.
|
|
||
| with self.command_group('storage account blob-service-properties', blob_service_mgmt_sdk, | ||
| custom_command_type=storage_account_custom_type, | ||
| resource_type=ResourceType.MGMT_STORAGE, min_api='2019-04-01') as g: |
There was a problem hiding this comment.
Blob Service Properties are supported for a long time, and the correct min api version constraint for blob service properties should be 2018-07-01 I think.
But for changefeed feature it should be 2019-04-01.
There was a problem hiding this comment.
updated. @[email protected] Please help review again.
In reply to: 354647458 [](ancestors = 354647458)
|
Help message for update is missing. |
|
For |
|
Please run |
|
Updated. In reply to: 562439357 [](ancestors = 562439357) |
|
Updated. @[email protected] , please help review again. In reply to: 562439630 [](ancestors = 562439630) |
src/azure-cli/HISTORY.rst
Outdated
|
|
||
| * GA Release Large File Shares property for storage account create and update command | ||
| * GA Release User Delegation SAS token Support | ||
| * Add new commands to manage blob service properties for storage account. |
There was a problem hiding this comment.
How about we put the command group here: az storage account blob-service-properties
There was a problem hiding this comment.
Do we really need put so specific information here? Do we have a guideline on how to write history?
There was a problem hiding this comment.
Not really. We usually refer to the previous history entries.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@[email protected] , what's '/azp run' meaning? In reply to: 563201902 [](ancestors = 563201902) |
Manually rerun Azure DevOps from here. |
5 participants
This PR is to support #11423 which added the following two commands:
az storage account blob-service-properties show: Gets the properties of a storage account’s Blob service.az storage account blob-service-properties update --enable-change-feed: Enable/disable the change feed of a storage account’s Blob service.TODO: support updating other properties besides 'enable-change-feed'
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.