Skip to content

Backup support for SQL/SAP HANA - #11066

Merged
Zunli Hu (Juliehzl) merged 21 commits into
Azure:devfrom
MabOneSdk:users/sarath/clisaphana
Dec 11, 2019
Merged

Backup support for SQL/SAP HANA#11066
Zunli Hu (Juliehzl) merged 21 commits into
Azure:devfrom
MabOneSdk:users/sarath/clisaphana

Conversation

@sambitratha

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@yonzhan

Copy link
Copy Markdown
Collaborator

Zunli Hu (@Juliehzl) help to review first.

@sambitratha

Copy link
Copy Markdown
Contributor Author

In Python 3 environment tests are failing in pipeline but passing locally. Can anyone help? Thanks

@mmyyrroonn

Copy link
Copy Markdown
Contributor

Sambit Rath (@sambitratha) Do you need to bump the SDK version? Based on the error message, looks like you need to install a new version of Python SDK.

@sambitratha Sambit Rath (sambitratha) changed the title [DO NOT MERGE] Backup support for SQL/SAP HANA Backup support for SQL/SAP HANA Nov 4, 2019
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/_help.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/commands.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/commands.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/commands.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/custom_base.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/custom_wl.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/backup/custom_base.py Outdated
@qwordy

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Juliehzl Zunli Hu (Juliehzl) modified the milestones: S161, S162 Nov 25, 2019
@qwordy

Feiyue Yu (qwordy) commented Dec 10, 2019

Copy link
Copy Markdown
Member

ERROR: ************* Module azure.cli.command_modules.backup.custom_wl
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)

Imports should be grouped in the following order:

    Standard library imports.

    Related third party imports.

    Local application/library specific imports.

You should put a blank line between each group of imports.

@pvrk

Copy link
Copy Markdown
Member

CLI team: We need this PR to be part of next milestone. We opened this initially to target the release after Ignite but missed that. I also see that all review comments and fixes are checked in. Since the code complete is very near, I want the team to take a final look and sign-off this PR, so that it will be available in the next milestone.

@qwordy

Copy link
Copy Markdown
Member

ERROR: ************* Module azure.cli.command_modules.backup.custom_wl
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)

Imports should be grouped in the following order:

    Standard library imports.

    Related third party imports.

    Local application/library specific imports.

You should put a blank line between each group of imports.

It seems you have resolved this error 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants