Skip to content

Conversation

@sambitratha
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@yonzhan yonzhan added this to the S161 milestone Nov 2, 2019
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 2, 2019

@Juliehzl help to review first.

@sambitratha
Copy link
Contributor Author

In Python 3 environment tests are failing in pipeline but passing locally. Can anyone help? Thanks

@mmyyrroonn
Copy link
Contributor

@sambitratha Do you need to bump the SDK version? Based on the error message, looks like you need to install a new version of Python SDK.

@sambitratha sambitratha changed the title [DO NOT MERGE] Backup support for SQL/SAP HANA Backup support for SQL/SAP HANA Nov 4, 2019
@sambitratha sambitratha force-pushed the users/sarath/clisaphana branch from 6a25521 to ab3fa6a Compare November 11, 2019 10:17
@sambitratha sambitratha reopened this Nov 19, 2019
@qwordy
Copy link
Member

qwordy commented Nov 22, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Juliehzl Juliehzl modified the milestones: S161, S162 Nov 25, 2019
@qwordy
Copy link
Member

qwordy commented Dec 10, 2019

ERROR: ************* Module azure.cli.command_modules.backup.custom_wl
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)

Imports should be grouped in the following order:

    Standard library imports.

    Related third party imports.

    Local application/library specific imports.

You should put a blank line between each group of imports.

@pvrk
Copy link
Member

pvrk commented Dec 11, 2019

CLI team: We need this PR to be part of next milestone. We opened this initially to target the release after Ignite but missed that. I also see that all review comments and fixes are checked in. Since the code complete is very near, I want the team to take a final look and sign-off this PR, so that it will be available in the next milestone.

@qwordy
Copy link
Member

qwordy commented Dec 11, 2019

ERROR: ************* Module azure.cli.command_modules.backup.custom_wl
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py:16:0: C0412: Imports from package azure are not grouped (ungrouped-imports)

Imports should be grouped in the following order:

    Standard library imports.

    Related third party imports.

    Local application/library specific imports.

You should put a blank line between each group of imports.

It seems you have resolved this error 👍

@Juliehzl Juliehzl merged commit fc006c5 into Azure:dev Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants