App Service cmd for importing certs from Key Vault #11429
Conversation
|
Please run |
|
Hi @haroldrandom. I fixed the help error and some other styling. I also added a scenario test. The test works when I run it local, but fails in CI - the error is from creating an app service plan. The same lines of code found in numerous other tests. Any idea what is wrong? |
|
@madsd Have you edited the recording YAML file manually? |
|
@jiasli please help with the PR. |
|
No changes to the Yaml file, and I can run the tests in live mode on my machine without problems. The strange thing is, that it seem to fail on the basic appservice plan create. Don't know if there is a way to get more details on the exception. |
you can delete the YAML file locally & re-record & upload the new yaml. You can also do is do a azdevsetup -c again on your local machine & see if you see this failure locally as well. |
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
Thanks for doing this. Just one comment on updating the command name to reflect that this is for managed certs only. Please check with the PM as well to help us here.
madsd
changed the title
|
is it necessary to support version of cert? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No, the commands setups up the integration with KV and pulls the latest version - any future versions of the certs are handled directly between App Service and Key Vault. |
|
@yungezz, @haroldrandom requested changes has been implemented and the the latest History.rst conflict resolved. |
haroldrandom
left a comment
haroldrandom
left a comment
There was a problem hiding this comment.
LGTM.
Please @jiasli @panchagnula take a look
7 participants
App Service cmd for importing certs from Key Vault:
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.