Resource: Support policy set definition grouping #11503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Juliehzl please help with the PR. |
Juliehzl
reviewed
Dec 8, 2019
Juliehzl
reviewed
Dec 8, 2019
Contributor
There was a problem hiding this comment.
Why do you want to specify object size for response here?
Contributor
Author
There was a problem hiding this comment.
When listing policies to ensure the modified policy is present it retrieves all built-in policies that Microsoft publishes. This is a decent amount of content and was exceeding the default AllowLargeResponse size. We are in the process of adding filters and better pagination to these APIs which should allow me to cut these response sizes down in the tests in a future change.
Contributor
|
LGTM. If CI pass, I will agree. |
Contributor
Author
|
@Juliehzl CI checks have passed |
Juliehzl
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for policy set definition grouping in the "resource" command module.
Introduces a
--definition-groupsparameter to theaz policy set-definition createandaz policy set-definition updatecommands.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.