Plugging in HaTs survey #11526
Plugging in HaTs survey #11526
Conversation
|
let's merge it after PM's confirmation |
|
|
||
| BLACKLISTED_MODS = ['context', 'shell', 'documentdb', 'component'] | ||
|
|
||
| SURVEY_PROMPT = Fore.YELLOW + Style.BRIGHT + 'Please let us know how we are doing: ' + Fore.BLUE \ |
There was a problem hiding this comment.
Starting with "Please" looks like a command. Maybe the prompt can be more friendly.
There was a problem hiding this comment.
IMHO, using "Please" is kind of friendly.
| def show_help(self, cli_name, nouns, parser, is_group): | ||
| self.update_loaders_with_help_file_contents(nouns) | ||
| super(AzCliHelp, self).show_help(cli_name, nouns, parser, is_group) | ||
| print(SURVEY_PROMPT) |
There was a problem hiding this comment.
each time when typing "-h", print this prompt?
There was a problem hiding this comment.
yes, that's by design.
There was a problem hiding this comment.
Will users be bothered? Reduce frequency?
There was a problem hiding this comment.
Originally, we thought of providing an option to turn the survey prompt off. But since users can just ignore it, let's just leave it there and see how it goes. We can improve this when we have more feedback.
There was a problem hiding this comment.
Hi there!
Please consider this as feedback that this is kind of annoying :) Especially since that's a coloured prompt (whereas the actual help text is not).
I've filled in the survey… but I could only select "neither good nor bad" for all entries, as I've just started using the CLI (which is why I'm looking at the help).
Sorry for intruding on your PR, I'll go back to being quiet now, thanks!
There was a problem hiding this comment.
Thanks for the feedback. We'll look at then.
4 participants
Implement #11444