Merged
Conversation
* add routes, view and controller * add before action for 404 * remove put route and update, include analytics args for visit event * include step indicator in view * add spec and update controller * update spec * lint fix * update before action name and mock applicant * add more before actions and spec for them * update before action in ssn controller * lint fix * remove unused title * update test name * add feature spec and update address controller spec * lint fix
* LG-11152 Add Proofing Rate Metrics to MKMR changelog: Internal, Reporting, Add Proofing Rate Metrics
* Rename GpoMail#mail_spammed? to #rate_limited? [skip changelog] * Rename :confirm_mail_not_spammed to :confirm_mail_not_rate_limited * Rename translation tag alert_spam_warning_html to alert_rate_limit_warning_html * rename enter_code_step_spec methods that refer to rate limits * Rename shared examples 'gpo otp verification' to 'verification code entry'
* delete unused code * changelog: Internal, DocAuth, remove code that is not being used * combine lexis_nexis_response and true_id_response
* LG-11017: Add doc type and issuing country to event Technical Notes: - We had to update the `if` statement in the mock `result_response` so that if we have `classification_info` but it's not erroneous, we don't accidentally apply the `barcode error`. - Add a new yml file for testing the case where there is `classification_info` that exists and is not erroneous - had to use hash rocket syntax to keep keys as strings instead of symbols - We found that merging the `doc_type_and_issuing_country` after `to_h` did not work, as it added it to the hash returned by `to_h` rather than the `response`. By saving the output of the line as a variable and then passing that in to analytics, we were able to fix the issue. * changelog: Internal, Doc Auth, Add doc type and issuing country to PII validation event * Update keys to symbols * Use or statement * Lintfix * make classification_info public * LG-11017: use existing classification information available from response. * LG-11017: clean up. * LG-11017: test verification. * LG-11017: fix tests. * LG-11017: mock response always has alert setup. * LG-11017: some tests rely on the default behavior of the mock response. * LG-11017: ends earlier if condition satisfied. --------- Co-authored-by: Dawei Wang <daweiwang@navapbc.com>
changelog: Internal, Dependencies, Remove unused uglifier gem
In #9411 we moved all traffic from the old `/verify/review` path to the new `/verify/enter_password` path. We left the old paths around so that users getting redirected by old instances would not encounter a 404 error. Once the changes in #9411 has been deployed for a day there should not be any more users visitting `/verify/review` and we can merge this change to remove it. [skip changelog]
* LG-11425: remove from screen. * LG-11425: fix tests. * LG-11425: remove tests related. changelog: User-Facing Improvements, Doc Auth, Remove optional questions from capture screen.
* Removing unneeded redirects for in_person_proofing/ssn url * changelog: Internal, In-Person Proofing, removing redirects for old FSM based SSN step * Removing unecessary comment
We wrote this for Attempts API. but the code that calls it has been deleted. This was for a bespoke encoding requested by the IRS, and is overall very space-inefficient, so it's unlikely we will reuse this for anything. [skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.48 to 1.10.49. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.48...v1.10.49) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
changelog: Internal, Changelog Script, Remove temporary transitional code
changelog: Internal, Performance, Optimize size of application stylesheets
…9457) * The issue was actually integration not existing, not partner_account * Add output when things don’t exist to be removed changelog: Internal, Cleanup, Fix removing service providers when the associated integration doesn’t exist * Make lint happy
…IdV steps (#9465) * Add latest_step * Add test for latest_step to be document_capture_standard * Check input to latest_step and rename document_capture_standard to document_capture * Add more methods for steps * capture the user for later checks, e.g., IPP * add checks for a/b tests. sample check_steps for validation * changed request_letter to check address_step_complete * added letter enqueued method and test * created path_for_latest_step method * path_for_latest_step returns the path for the latest step to allow for redirects * add a path_allowed? method * memoize path_map, add url_options * create method #confirm_step_allowed * placed #confirm_step_allowed in idv_step_concern to check if a step is allowed. * to use this add before_action :confirm_step_allowed in every controller you want the check to appear in. * remove getting started ab test step * change pii_from_doc to applicant after verify info * rename allowed_step to idv::workflow_policy * idv/workflow_policy -> idv/flow_policy * check for path_allowed? in specs * make methods not called by our little api private * clean up path_to_step * use of struct for new steps hash with information * move #steps to private * First cut at using the flow policy * hybrid_flow_controller before actions changed * added an A/B test example * Introduces the Idv::StepInfo class, that each controller can define locally. Uses the controller name and action to resolve paths dynamically. * Fix IdvStepConcern#path_for_latest_step * Remove duplicate confirm_hybrid_handoff_needed method (and fix spec titles) * Remove step_needed? method * change path_allowed to controller_allowed * move the definition of the StepInfo to the controller for LinkSent and DocumentCapture * add phone_question to flow policy * fix phone_question_controller_spec * fix hybrid_handoff_controller_spec * Adds step_info_spec * updates to flow_policy_spec * Convert navigation_step into a class method. * use confirm_step_allowed * rename requirements to preconditions. use urls, not paths, for redirect. * populate the navigation_step methods for ssn through personal_key * add a key to StepInfo * make #latest_step private * "fix" the commented out specs for future steps * remove comments. rename step to key. * test #navigation_step for future controllers * Rename #navigation_step to #step_info * Fix PhoneQuestion feature specs by stubbing AbTests::IDV_PHONE_QUESTION.bucket changelog: Internal, Identity Verification, Add FlowPolicy to redirect users to their latest allowed step if they try to move ahead in the identity verification flow and use in the first few steps up to DocumentCapture --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
* add phone with camera to ab test analytics * add phone_with_camera to analytics spec * update ab_test_analytics_concern_spec to inclide phone_with_camera * test phone question to detect setting phone_with_camera in idv_session * remove phone_with_camera logging from spec when idv_session not available * [skip changelog] * log phone_with_camera in hybrid document capture * check referer if user decides not to confirm cancel initiated from hybrid handoff page * happy linting * remove use of referer for phone question redirect logic changelog: Internal, Logging, log phone_with_camera for phone question ab tests Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * refactor tests from referer to idv_session.phone_with_camera routing * ensure idv_session defined since module included in hybrid document capture * happy linting * update test to use idv_session and no longer referer --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Change "code" to "verification code" in all lanugages. changelog: User-facing Improvements, Verify by Mail, Update error message for incorrect code to use new 'verification code' language
changelog: Internal, Reporting, Adds Agency and SP metrics
* Try forced title content changelog: Internal, Accessibility, Add enforcement for unique page titles * Add missing titles for test routes * Add missing titles for SAML termination * Update specs for base template view * Add missing title for IdV mail only outage handling * Add missing title for verified personal key * Remove now-redundant accessibility matcher * Add missing titles for account reset * Add translations for new titles
changelog: Internal, Scripts, Fix error when querying cloudwatch from MKMR in dev and int
This commit changed the app to require templates to declare a title: 4d69e9d It looks like this was able to sneak through without a title declaration in the In-Person flow on in the address show template. This commit adds a title declaration to that template. [skip changelog]
aduth
approved these changes
Oct 31, 2023
mitchellhenke
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal