Skip to content

LG-11271 change mail spammed language to rate_limited #9454

Merged
soniaconnolly merged 6 commits intomainfrom
sonia-lg-11271-rename-mail-spammed
Oct 27, 2023
Merged

LG-11271 change mail spammed language to rate_limited #9454
soniaconnolly merged 6 commits intomainfrom
sonia-lg-11271-rename-mail-spammed

Conversation

@soniaconnolly
Copy link
Contributor

🎫 Ticket

LG-11271

🛠 Summary of changes

This is a code cleanup PR to align with our current language around rate limits and verification codes.

  • Rename GpoMail#mail_spammed? to #rate_limited?
  • Related renaming of translation tags and spec methods
  • Rename shared examples gpo otp verification to verification code entry

📜 Testing Plan

Automated testing in CI

@soniaconnolly soniaconnolly requested review from a team and jmax-gsa October 26, 2023 00:09
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified mail_spammed and mail_not_spammed no longer exist anywhere in the repo.

@soniaconnolly soniaconnolly merged commit 38ba5fb into main Oct 27, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-11271-rename-mail-spammed branch October 27, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants