LG-11427: add phone_with_camera to analytics#9461
Merged
Conversation
amirbey
changed the title
amirbey
requested review from
a team and
night-jellyfish
and removed request for
a team
dawei-nava
reviewed
Oct 27, 2023
| **analytics_arguments. | ||
| merge(phone_with_camera: true), | ||
| ) | ||
| idv_session.phone_with_camera = true |
Contributor
There was a problem hiding this comment.
@amirbey , so basically user is presented(based on bucket) this question, and answered with true or false. If user is not presented with question, this flag will be nil.
dawei-nava
reviewed
Oct 30, 2023
| return if request.referer == idv_link_sent_url | ||
| return if request.referer == idv_hybrid_handoff_url | ||
| return if request.referer == idv_hybrid_handoff_url(redo: true) | ||
| return if request.referer == idv_cancel_url(step: 'hybrid_handoff') |
Contributor
There was a problem hiding this comment.
Wondering whether we can consolidate
Contributor
Author
There was a problem hiding this comment.
hi @dawei-nava - @soniaconnolly and I are looking to refactor our implementation here 😄
charleyf
reviewed
Oct 30, 2023
Comment on lines
+89
to
+91
| def phone_with_camera | ||
| { phone_with_camera: phone_question_ab_test_bucket == :show_phone_question ? true : nil } | ||
| end |
Contributor
There was a problem hiding this comment.
- I think this should move into
phone_question_ab_test_concern - I think that everything we do here in
hybrid_mobile/document_capture_controller.rbwe also need to do inidv/document_capture_controller.rb?
Contributor
Author
There was a problem hiding this comment.
@charleyf - this is present because we don't have idv session here .. this logic is exclusive to the hybrid document capture
11 tasks
changelog: Internal, Logging, log phone_with_camera for phone question ab tests Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
soniaconnolly
approved these changes
Oct 30, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, talked through logging both phone_with_camera and the phone question bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11427
🛠 Summary of changes
Store phone_with_camera in idv_session and log in analytics for IdV events.
📜 Testing Plan
Bypass phone question page
Phone question page with camera
Phone question page without camera
NOTE: events not logged
hybrid document capture events
image upload submitted
image upload pii validation