Conversation
changelog: Internal, Performance, Optimize size of application stylesheets
mitchellhenke
approved these changes
Oct 30, 2023
Merged
Contributor
Author
|
So I think despite what the Chrome DevTools claims, the Edit: See #9632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes two styles which would have no effect, due to invalid combinations.
I came aware of these with automated validation tools in Chrome and VSCode.
I couldn't easily run an audit over all CSS with Chrome's validator (though I did find the source). Running VSCode's validator over the compiled CSS did reveal another upstream issue in USWDS, tracked at uswds/uswds#5587 .
📜 Testing Plan
Verify no regressions in appearance of unstyled buttons and success-bullet lists.