Skip to content

Removes abandoned Base16 code#9473

Merged
n1zyy merged 1 commit intomainfrom
mattw/debase16
Oct 27, 2023
Merged

Removes abandoned Base16 code#9473
n1zyy merged 1 commit intomainfrom
mattw/debase16

Conversation

@n1zyy
Copy link
Contributor

@n1zyy n1zyy commented Oct 27, 2023

We wrote this for Attempts API, but the code that calls it has been deleted. This was for a bespoke encoding requested by the IRS, and is overall very space-inefficient, so it's unlikely we will reuse this for anything.

[skip changelog]

We wrote this for Attempts API. but the code that calls it has
been deleted. This was for a bespoke encoding requested by the IRS,
and is overall very space-inefficient, so it's unlikely we will
reuse this for anything.

[skip changelog]
@n1zyy n1zyy requested a review from a team October 27, 2023 18:26
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲 gonna miss this code, it was fun to optimize! byeeee

@n1zyy
Copy link
Contributor Author

n1zyy commented Oct 27, 2023

🥲 gonna miss this code, it was fun to optimize! byeeee

byeee

@n1zyy n1zyy merged commit 0a7a2f7 into main Oct 27, 2023
@n1zyy n1zyy deleted the mattw/debase16 branch October 27, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants