The issue was actually integration not existing, not partner_account#9457
Merged
Jeremy1026 merged 3 commits intomainfrom Oct 30, 2023
Merged
The issue was actually integration not existing, not partner_account#9457Jeremy1026 merged 3 commits intomainfrom
Jeremy1026 merged 3 commits intomainfrom
Conversation
Sgtpluck
requested changes
Oct 26, 2023
Contributor
Sgtpluck
left a comment
There was a problem hiding this comment.
oh good catch! i have a little suggestion to add a conditional just to give folks a little more info.
lib/cleanup/destroyable_records.rb
Outdated
| stdout.puts '********' | ||
| stdout.puts 'Integration:' | ||
| stdout.puts integration.attributes.to_yaml | ||
| stdout.puts integration&.attributes.to_yaml |
Contributor
There was a problem hiding this comment.
In this instance, it might be nice to have a conditional
if integration.nil?
stdout.puts "No associated integration"
else
stdout.puts integration.attributes.to_yaml
end
lib/cleanup/destroyable_records.rb
Outdated
| stdout.puts '*******' | ||
| stdout.puts 'These are the IAA orders that will be affected: \n' | ||
| iaa_orders.each do |iaa_order| | ||
| iaa_orders&.each do |iaa_order| |
Contributor
There was a problem hiding this comment.
likewise here:
if iaa_order.nil?
stdout.puts "No IAA orders will be affected"
else
stdout.puts 'These are the IAA orders that will be affected: \n'
iaa_orders.each do |iaa_order|
stdout.puts "#{iaa_order.iaa_gtc.gtc_number} Order #{iaa_order.order_number}"
end
end
Contributor
Author
There was a problem hiding this comment.
I can get on board with more details being provided.
changelog: Internal, Cleanup, Fix removing service providers when the associated integration doesn’t exist
0e95d45 to
774849d
Compare
Sgtpluck
approved these changes
Oct 26, 2023
mmagsa
approved these changes
Oct 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10920
🛠 Summary of changes
There is additional checks required to have the rake task be able to continue through
destroyable_records.rb. The issue isintegrationis nil, notintegration.partner_accountas I initially assumed based on the error.