LG-11152 Add Proofing Rate Metrics to MKMR#9459
Merged
ThatSpaceGuy merged 4 commits intomainfrom Oct 26, 2023
Merged
Conversation
changelog: Internal, Reporting, Add Proofing Rate Metrics
ThatSpaceGuy
force-pushed
the
LG-11152-Proofing-Rates-MKMR
branch
from
4eb318e to
416f873
Compare
n1zyy
approved these changes
Oct 26, 2023
| end | ||
|
|
||
| def account_reuse_report | ||
| @account_reuse_report ||= Reporting::AccountReuseAndTotalIdentitiesReport.new(report_date) |
Contributor
There was a problem hiding this comment.
Not for this PR, but -- it is starting to feel really dirty that Reporting::AccountReuseAndTotalIdentitiesReport (and most other reports here) don't require an, erm, require, because they're local, but Reporting::ProofingRateReport does because it's in a separate reporting directory. I hope some day we can unify that.
zachmargolis
approved these changes
Oct 26, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, let's fix the naming I commented on before merging please!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Reporting, Add Proofing Rate Metrics
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11152
👀 Screenshots