Raise error when view missing title content block#9447
Merged
Conversation
changelog: Internal, Accessibility, Add enforcement for unique page titles
zachmargolis
approved these changes
Oct 25, 2023
Contributor
Author
|
I think I've tackled the last of the missing titles in 2f7ff9d . For extra assurance, I also manually stepped through every file in I'll need to get a couple translations for the missing titles before this is fully ready. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates base template to enforce the expectation that a controller view will assign a
content_for(:title), to satisfy descriptive purpose requirements of WCAG SC 2.4.2 Page Titled, something we already partially enforce through accessibility matchers in specs📜 Testing Plan
Build should pass.
Also verify that an error would occur when controller view doesn't include title, such as removing this line from the sign-in page:
identity-idp/app/views/devise/sessions/new.html.erb
Line 1 in 43e1303