Deploy RC 316 to Production#9249
Merged
mitchellhenke merged 24 commits intostages/prodfrom Sep 21, 2023
Merged
Conversation
changelog: User-Facing Improvements, MFA Setup, Add second MFA encouragement screen for single-MFA accounts
If brakeman fails, point developers toward what to do about it in Makefile [skip changelog] Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
…ount management of adding MFA (#9133) * changelog: Internal Fixes, Authentication, set up logging to differentiate between act creation and deletion * changelog: Internal, Authentication, update logging for clearer distinction between account creation and management in mfa * update analytic events * fix spec and analytic event description length * move password session setting after user session created * fix webauthn visit form * analytic properties * dont remove user registration method yet * update to ensure it returns false * fix to redirect * in account creation flow specs fixed * make sure to only delete session when at mfa_setup step * after skip path * add spec * Leverage to use completions controller * add new event params to completions event * remove pii * after sign in path * address comments, move helper method to concern * move back setup concern * include helper method through concern * change back to setup mfa concern * fix completions controller * fix specs * relocate method to setup concern
* Revert "Revert "LG-10886 remove ssn from flow session (#9182)" (#9209)" Fixed 50/50 state issue by adding :ssn to pii going to proof resolution job in deploy 314.2. This reverts commit 4f0ad04. * Don't use ||= when adding ssn to pii for proof resolution job If someone updates their SSN, we want it to be updated for the proofing job, so use =
…rch package (#9208) * changelog: Internal, In-Person Proofing, Re-export Alert component from Address Search package * Minor version bump * Publish identity-components package * Include react dom * Alias self * Use conditionNames instead * Make react-dom peer dependency
* Add ReportMailer#tables_report - Internal report mailer method to send CSV reports * Add layout, stylesheet for USWDS styles changelog: Internal, Reporting, Add helper to mail reports internally
* rename SessionDecorator to NullServiceProviderSession Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * rename ServiceProviderSessionDecorator to ServiceProviderSession * rename DecoratedSession to ServiceProviderSessionCreator * rename ApplicationController.decorated_session to decorated_sp_session We changed the naming to explicitly state that this is a sp session * add changelog changelog: Internal, Session Rename, rename decorated session and its children to service provider names * Rename ServiceProviderSessionCreator.call to create_session * fixup * update brakeman ignore * rename decorated_session to decorated_sp_session fixup --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* created text with translations for reenter password to send letter * add conditional for verifiy by mail title * add controller tests for title in review controller * add changelog changelog: User-Facing Improvements, IdV, update re-enter your password title content * fix spanish translation for header * create review_letter for titles * allow title to also change with gpo * move title and heading into private methods
* Remove unused address presenter method * Remove existing password reminder banner and add translations for new banner Changelog: User-facing Improvements, Identity Verification Re-enter Password, Add banner for users in verification by mail flow to remember their password * Add new banner only for users verifying by mail --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Adjust top and bottom margins on new banner on Re-enter Password screen during Verify by Mail. [skip changelog] Co-authored-by: Alexander Bradley <alexander.bradley@gsa.gov>
…de sign in language for clearer context (#9233)
…d review (#9235) The review profile rake task is used to pass or reject users after fraud review. We have a test case for users who running that task against a user who is not pending fraud review because they have undergone a more recent verification. Previously that test case actually tested a case where a user had an invalid profile state that was pending GPO verification. This should not be possible and raises an exception. It also did not match the spec description. This commit cleans up the spec to cover the case described in the spec description. In this case the user has reset their password and deactivated the fraud pending profile. Then they have created a new profile that is GPO pending. A new spec is also introduced to cover the code paths covered by the old test: a case where the profile is in an unexpected state and an exception is raised. [skip changelog] Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Event renamed to `IdV: proofing resolution result missing` Note: the old event name does not appear in any terraformed dashboards/metrics. [skip changelog]
* config FullAddressSearch to take in optional arg * config AddressSearch to take optional props * Include interface, update height of img * remove trailling period * Add in-person-locations tests for no results * fix linter error * changelog: Internal, In-person proofing, recongifure AddressSearch and FullAddressSearch to pass in No Locations Display else use default view * Increase version of identity-address-search
* Update Welcome to say 5 to 10 days changelog: User-facing Improvements, Identity Verification by mail, Update timeframe to say 5 to 10 days * Update PhoneErrors to say 5 to 10 days * Update RequestLetter to say 5 to 10 days * Update LetterEnqueued to say 5 to 10 days * Update EnterCode to say up to 10 days * Update Didn'tReceiveLetter to say up to 10 days * Update Phone Warning to say 5 to 10 days * Update ResendLetter to say 5 to 10 days * Update MailOnlyWarning to say 5 to 10 days * Change First Class Mail to First-Class Mail in translations * Remove strong tag from around phone warning message about by mail length of time The strong tag was unexpectedly in the view template, not the message itself. * Correct French translation for option_verify_by_mail_html (Phone Error) and a couple other tiny fixes. * Update translations to match ticket --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
…dress-search package (#9234) * Move files; no changes yet * Move full address search into npm package changelog: Internal, PO search in identity-site, Move full address entry PO search into identity-address-search package * Fix lint (and test) failures * Fix more lint failures * Make property naming more consistent * Trigger CI build
* LG-10427: add fileds in document capture session result to memorize failed auth image fingerprints. * LG-10427: calling extra_attributes before validation completion will cause stale attempts rate limiter data. * LG-10427: update test for capture session and result. * LG-10427: AssureID and TrueID services behave differently by using http status code. AssureID uses 440, 438, 439 for image metric errors, while TrueID doesn't. * LG-10427: refactor test response generation for AssureID. * LG-10427: use meta programming. Linter issue. * LG-10427: remove commented change. * LG-10427: remove accidental change. changelog: User-facing Improvement, Document Auth, Prevent resubmit failed images during a doc auth session. * LG-10427: implement client side validation. * LG-10427: fix test. * LG-10427: skip the warning screen when the backend detected duplicate image used. * LG-10427: add analytics event. * LG-10427: use i18n text. And avoid nested promises in acuant-capture.tsx. * LG-10427: update translation. fix test. * LG-10427: Linter, typo and test fix. * LG-10427: address comment and add tests for storing failed image fingerprints. * LG-10427: linter * changelog: User-facing Improvements, Document Authentication, Prevent resubmission of failed image * LG-10427: linter * LG-10427: add flag so we can facilitate tests in some cases. * LG-10427: flaky test? * LG-10427: linter. * LG-10427: linter. * LG-10427: order of events. * LG-10427: linter * LG-10427: address comments. * LG-10427: it should be a hash. * LG-10427: test fix and clean up. * LG-10427: wording. * LG-10427: wording. * LG-10427: rebase. * LG-10427: WIP, refactor with Andrew. * LG-10427: skip warning, and mark it can complete when different file used. * LG-10427: address comment, testing and type. * LG-10427: address comment, type. * LG-10427: type mismatches. * LG-10427: missing property in tests. * LG-10427: clean up directive.
[skip changelog]
…om_doc] (#9195) * Add idv_session.pii_from_doc to replace flow_session[:pii_from_doc] Now that we are not using the Flow State Machine, we can stop using flow_session. This is the last attribute to move out in the remote flow. changelog: Internal, Identity Verification, start moving pii_from_doc to idv_session
The fraud review pass/reject rake task is re-implemented in the ActionAccount tooling. #9194 added logging for the rake task. This commit adds the same logging to ActionAccount [skip changelog]
…und job schedule (#9240) * LG-10891 Add MultiRegionKmsMigration::UserMigrationJob to the background job schedule A previous commit added a class for re-encrypting single-region KMS ciphertexts on user records with a multi-region key. That job was not added to the job schedule so it could be tested in lower environments before being enabled. We have confirmed the job works as expected in lower environments. This commit also addresses LG-11030 by making the record count and statement timeout params for the migration jobs configurable with the IdentityConfig tooling. [skip changelog] * tweak the cron for the jobs so they run every 10 minutes instead of every 12 * whoops, there is no 10m cron value * Update config/initializers/job_configurations.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update config/initializers/job_configurations.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update config/initializers/job_configurations.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Add conditionalNames to webpack in address-search * changelog: Internal, IPP, Update webpack config inside address-search to be able to publish to npm
#9237) * Use Redis expiretime to avoid repeated TTL calls when building IdToken changelog: Internal, Performance, Use Redis expiretime to avoid repeated TTL calls when building IdToken * add ttl to token form analytics * also log ial * fix spec * add analytics events
mitchellhenke
requested review from
aduth,
allthesignals,
jmhooper,
mdiarra3,
soniaconnolly and
zachmargolis
mitchellhenke
requested review from
dawei-nava,
gina-yamada,
sheldon-b,
solipet and
theabrad
Contributor
|
PR #9229 "[Finish removing ssn from flow session (revert the revert)" already went out. Does it matter to have it in here? |
soniaconnolly
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal