LG-10850 Update all screens to say 5 to 10 days to get a letter

[soniaconnolly]

🎫 Ticket

LG-10850

🛠 Summary of changes

Update translations for the following screens that mention the length of time for Verify by Mail:

• Welcome
• Phone Warning
• Phone Error
• Request Letter
• Resend Letter
• Letter Enqueued
• Enter Code
• Didn't Get Your Letter
• Mail Only Warning

📜 Testing Plan

• Create account, start IdV
• Check Welcome screen
• Enter phone number to fail Phone Step (703-555-5555)
• Check Phone Warning and Phone Error screens
• Enter Verify By Mail flow
• Check Request Letter and Letter Enqueued screens
• Check Enter Code and Didn't Get Your Letter screen (add parameter of ?did_not_receive_letter=1 to url)
• Click to resend letter and check Resend Letter screen
• In application.yml set vendor_status_sms: full_outage and restart server
• Cancel and restart IdV and check Mail Only Warning screen

👀 Screenshots

After, Welcome:

Details

English	Spanish	French

After, MailOnlyWarning:

Details

English	Spanish	French

After, Phone Warning:

Details

English	Spanish	French

After, Phone Error:

Details

English	Spanish	French

After, Request Letter:

Details

English	Spanish	French

After, Letter Enqueued:

Details

English	Spanish	French

After, Enter Code:

Details

English	Spanish	French

After, Didn't Get Letter:

Details

English	Spanish	French

After, Send Another Letter:

Details

English	Spanish	French

[zachmargolis]

I don't expect this will change often, but seeing as we're changing this in a bunch of places, should we make these numbers configs and interpolate them in?

[soniaconnolly]

I don't expect this will change often, but seeing as we're changing this in a bunch of places, should we make these numbers configs and interpolate them in?

We're not changing how the app behaves, since these numbers depend on USPS. Just changing how we talk about it. I don't think a config makes sense in this case.

[zachmargolis]

I don't expect this will change often, but seeing as we're changing this in a bunch of places, should we make these numbers configs and interpolate them in?

We're not changing how the app behaves, since these numbers depend on USPS. Just changing how we talk about it. I don't think a config makes sense in this case.

In my mind, it's not about app behavior, it's about "don't repeat yourself" or "one source of truth" kind of maintainability wins

[soniaconnolly]

In my mind, it's not about app behavior, it's about "don't repeat yourself" or "one source of truth" kind of maintainability wins

Agree in general about having things in one place. For this change, it wouldn't have helped to have the numbers as configs, because we also changed from "business days" to "days". We could have one translation tag for "5 to 10 days" and one for "up to 10 days" and interpolate those in, but for translations we generally prefer repetition as far as I've seen to avoid unexpected results from one screen to another. Are there other examples of reused translation phrases?

[zachmargolis]

I was focused more on the numbers. But we do make sure to interpolate "Login.gov" everywhere as APP_NAME / %{app_name}, entire phrases don't make for good constants because not all languages have the same word/phrase boundaries/ability to combine

[soniaconnolly]

I was focused more on the numbers. But we do make sure to interpolate "Login.gov" everywhere as APP_NAME / %{app_name}, entire phrases don't make for good constants because not all languages have the same word/phrase boundaries/ability to combine

Agreed about whole phrases. Do you still want me to interpolate the numbers? I'm willing to do it.

[zachmargolis]

I was focused more on the numbers. But we do make sure to interpolate "Login.gov" everywhere as APP_NAME / %{app_name}, entire phrases don't make for good constants because not all languages have the same word/phrase boundaries/ability to combine

Agreed about whole phrases. Do you still want me to interpolate the numbers? I'm willing to do it.

I think it's worth a shot at least! I wouldn't consider it a hard requirement for this PR but I do think it would be more maintainable going forwards.

[soniaconnolly]

I think it's worth a shot at least! I wouldn't consider it a hard requirement for this PR but I do think it would be more maintainable going forwards.

I put in JIRA ticket LG-11048 and put in the notes we discussed in chat. It feels like a lot to add that to this PR, especially since it wasn't about just changing the numbers.

[solipet]

Sonia and I walked through all the screens and corrected the very few issues we found.

LGTM!